Received: by 10.223.185.116 with SMTP id b49csp2430058wrg; Mon, 5 Mar 2018 02:45:13 -0800 (PST) X-Google-Smtp-Source: AG47ELsU+tHzSKrqJKSbgCBQXDFWwFajxscBX3MH5wnPCHgeIvmLdt3GKbMkTOkVN+5oKK6tynNH X-Received: by 10.99.96.199 with SMTP id u190mr11879048pgb.231.1520246713072; Mon, 05 Mar 2018 02:45:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520246713; cv=none; d=google.com; s=arc-20160816; b=gFG0xiQGguFgPCyHfyrBXpOH0w8NeDdjM2pxGjf8St8x+W0TPuk2yZOlL//ZQQecHv qBohUZniX/kxpwkUCSMgPMRj7ZkToH3/jzcyvQiFLt13l3kFbL0gfRvN/YrB2+jBv3kV 4eImV2541Q4rjqFKengAR5fXa9DGtwYvUl0EwrYira7E45KUuzmxX8EsEzq9gVqWv2UJ n8sbZTRZLybDpd/Q5wOAv+ABf6lS1riGL8TaossH8FUnqSnJId5SnvkllTY/IMbvuIuh FbJ5BilgK3wscihhWwAj7KqLxDjspTzFNWsK7s3rVYzNSl+tVwZpG8xj+9gI7OxHSRd2 8ngA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=KcHLELX4vWnKFPHr4m/AaBrKYM4wkbH/VDqHf/qNIlo=; b=HOtiV98Skr6J1lF2PFFmcnhGcIS+NpPhAyI8xA4UWeT1ntPujg+oW41xrUDBQGoQbb f8+vkrQ1862kz4VhhnsW0xy0cg8wsQHcL6ly0vqccYnwZDviCIROSRzKhVzBqPPQIDG/ uzcP71C+SV0+r+OsVstjIi4L1YkcupmQ/XC5VtyojGXcE4vY9BAPS7pr53QpoGJUOYZn eVY0wterWNzjvMtRlF5hSV6IkDajhBx6+bDdJUp3/t6hjSFFZ5aRWPxTaqMmYjPVxttE oK7VSqXaoeFkGz1nMLHvI7KessMPCgdPfsef64Ojxm3oSLcd1J0Ott4XIG4u+eS/aDG/ uVeg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=u9uUvgLa; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n7si1035278pgv.831.2018.03.05.02.44.58; Mon, 05 Mar 2018 02:45:13 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=u9uUvgLa; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934358AbeCEKmT (ORCPT + 99 others); Mon, 5 Mar 2018 05:42:19 -0500 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:53952 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934264AbeCEKmR (ORCPT ); Mon, 5 Mar 2018 05:42:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=KcHLELX4vWnKFPHr4m/AaBrKYM4wkbH/VDqHf/qNIlo=; b=u9uUvgLayHcpdduiw5softeZt EqrEmUjg2Dq2P9JTPYd6ceDlPO1Hf9LfDIDOnr7euKfO+nRhgPLl1t83uf8Wupz8Tn10Iv9o4sGE5 FfqzQslf64dVBJIgOOVqSLglY2M3JgdStd1ZiqnCklabcWyX84xs/GBReLd4VRPp8+ink=; Received: from debutante.sirena.org.uk ([2001:470:1f1d:6b5::3] helo=debutante) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1esnZQ-0005dY-5N; Mon, 05 Mar 2018 10:42:16 +0000 Received: from broonie by debutante with local (Exim 4.90_1) (envelope-from ) id 1esnZP-0003kO-NA; Mon, 05 Mar 2018 10:42:15 +0000 Date: Mon, 5 Mar 2018 10:42:15 +0000 From: Mark Brown To: Sasha Levin Cc: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , Javier Martinez Canillas Subject: Re: [PATCH AUTOSEL for 4.9 112/219] ASoC: ssm4567: Add OF device ID table Message-ID: <20180305104215.GE8588@sirena.org.uk> References: <20180303222716.26640-1-alexander.levin@microsoft.com> <20180303222716.26640-112-alexander.levin@microsoft.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="8vCeF2GUdMpe9ZbK" Content-Disposition: inline In-Reply-To: <20180303222716.26640-112-alexander.levin@microsoft.com> X-Cookie: Do not write below this line. User-Agent: Mutt/1.9.3 (2018-01-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --8vCeF2GUdMpe9ZbK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Mar 03, 2018 at 10:29:00PM +0000, Sasha Levin wrote: > From: Javier Martinez Canillas >=20 > [ Upstream commit 71c314d7ef2442cd798584a3dece8151215e1777 ] >=20 > The driver doesn't have a struct of_device_id table but supported devices > are registered via Device Trees. This is working on the assumption that a > I2C device registered via OF will always match a legacy I2C device ID and > that the MODALIAS reported will always be of the form i2c:. >=20 > But this could change in the future so the correct approach is to have an > OF device ID table if the devices are registered via OF. Same here. --8vCeF2GUdMpe9ZbK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlqdHwYACgkQJNaLcl1U h9AU4Af/WP4P9ecsX6/9uBp5RxVo3cAKuziV9jOePq53+gG7IhkCHCrz11fjDd79 8TKYV8VHGq1lQ9xEhi6DXeuusU0eb6ZKZKxfz3zlxEtmxvD5TwJHT8vvHgsyAIO+ 1BKBbTC/ggI3yEab8/SaY8qI+shPoGnzy3xLEOBejaGvbNBhfoL1difA9s/J4+a7 S+zqzMzI2nypEoDhs6EuVCO6nnZoritXkKiNaUwvbwmOSpjUoAdleUiayoPSt/xX agsLRcQDblZaDQwAv4jbapHE5L7BVNf0qZbmwdtRgPd5AXEN/vhpvR802/5sXd0c wmegL5XZwAbGreZrOz47LrY4RIjk1A== =qe+D -----END PGP SIGNATURE----- --8vCeF2GUdMpe9ZbK--