Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <1520242120-2924-1-git-send-email-harish_kandiga@mentor.com>
References: <1520242120-2924-1-git-send-email-harish_kandiga@mentor.com>
From:   Ulf Hansson <ulf.hansson@linaro.org>
Date:   Mon, 5 Mar 2018 13:13:41 +0100
Message-ID: <CAPDyKFqL0tE3fdODbpo5Ci1_e=RbOfxZkTXKQ4XWo4FKHzwMiw@mail.gmail.com>
Subject: Re: [PATCH v3] mmc: Export host capabilities to debugfs.
To:     Harish Jenny K N <harish_kandiga@mentor.com>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Shawn Lin <shawn.lin@rock-chips.com>, avri.altman@wdc.com,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Vladimir Zapolskiy <Vladimir_Zapolskiy@mentor.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 5 March 2018 at 10:28, Harish Jenny K N <harish_kandiga@mentor.com> wrote:
> From: Abbas Raza <Abbas_Raza@mentor.com>
>
> This patch exports the host capabilities to debugfs
>
> Signed-off-by: Abbas Raza <Abbas_Raza@mentor.com>
> Signed-off-by: Andrew Gabbasov <andrew_gabbasov@mentor.com>
> Signed-off-by: Harish Jenny K N <harish_kandiga@mentor.com>
> ---
>
> Changes in v3:
> - Removed typecasting of &host->caps to (u32 *)
>
> Changes in v2:
> - Changed Author
>
>  drivers/mmc/core/debugfs.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/mmc/core/debugfs.c b/drivers/mmc/core/debugfs.c
> index c51e0c0..570c9e4 100644
> --- a/drivers/mmc/core/debugfs.c
> +++ b/drivers/mmc/core/debugfs.c
> @@ -289,6 +289,9 @@ void mmc_add_card_debugfs(struct mmc_card *card)
>
>         card->debugfs_root = root;
>
> +       if (!debugfs_create_x32("host_caps", S_IRUSR, root, &host->caps))
> +               goto err;
> +

This isn't the correct place to created the node(s). Please move this
to mmc_add_host_debugfs().

Moreover, I suggest you export both caps and caps2 in the same change,
there is no need to have two changes for that - and finally name the
nodes to "caps" and "caps2".

>         if (!debugfs_create_x32("state", S_IRUSR, root, &card->state))
>                 goto err;
>
> --
> 1.9.1
>

Kind regards
Uffe