Received: by 10.223.185.116 with SMTP id b49csp2630662wrg; Mon, 5 Mar 2018 06:17:59 -0800 (PST) X-Google-Smtp-Source: AG47ELu47bI3n+du6/fT9zjxfedcYiMDLwACIDMkuRnAnAqsmUqLnhKAyfAdEoDZAGBmF5oVtca5 X-Received: by 10.99.117.6 with SMTP id q6mr12276243pgc.146.1520259479804; Mon, 05 Mar 2018 06:17:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520259479; cv=none; d=google.com; s=arc-20160816; b=wAcAWvj0hcnQxVDZ2XX4HjFi0sijDgyplxJBLgFHyg6vvQd5V8wEsIsmR0i55ByNwq Ila4PKQ5/SGRY2udRAtZXpySC4hg+KaLuXTvtHPHC8UI72TcHmwFTz5bRGkDR/8jFaVM kYpn+NbgC90YAWlpRPxOO3pTVAkht1s6yPo3CWmHbnCvk2P8EwTCzIxms0emGxnaZeuf LWZZPbHP9A6CmX9ryj2bCErdXoerkx9X8xplqgrzNKpggX0GHGD3s3Gva4QMUwtz52RB YOWdbCzBuGnwUmSX3yWtdCxYpHD4dbF/xw4CgaagjoQLA8GOJoI3sAzAo/QcdGhb+wRN OASA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=t6KhAECr/I9lp7hO1J7Q8Kx0WY5EXl85P5OyvS/Vzy0=; b=xQrREfOCgOdBrfma3EUhKZiEo0peZAM8It0qK8YOJazaBMKh26CQFno7y6/xK4exQ4 advJXkl/ataKSwrk0C98uozdxuuspYtbmc8XM4YUHRb5o1HVO3gmvVyy54tYdqNz+iqZ lRntjf1tHdALzyp+ucGlb9gDinKIrITMxtv2R0WkwHi25lJvPr+28qbP99956+BxuCia gtJT6ZjTBqWiaanSfn/M6c732UHxUKcQTY28lC/Bms/PIvIvcR8+pyl8ZaqhHPzgtd66 vk1rBdkuGdSLFiWsNn3n8tdUJbqbXqdMtJqglDAKZGBmsX+7b/X9GS0VFtCRoglNY63P UJZA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w3si8355689pgb.754.2018.03.05.06.17.45; Mon, 05 Mar 2018 06:17:59 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964866AbeCENQt (ORCPT + 99 others); Mon, 5 Mar 2018 08:16:49 -0500 Received: from mail.x-arc.co.uk ([217.6.246.34]:37963 "EHLO root.phytec.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932084AbeCENQs (ORCPT ); Mon, 5 Mar 2018 08:16:48 -0500 Received: from idefix.phytec.de (idefix.phytec.de [172.16.0.10]) by root.phytec.de (Postfix) with ESMTP id EC07FA00316; Mon, 5 Mar 2018 14:16:49 +0100 (CET) Received: from augenblix.phytec.de ([172.16.0.56]) by idefix.phytec.de (IBM Domino Release 9.0.1FP7) with ESMTP id 2018030514164653-65304 ; Mon, 5 Mar 2018 14:16:46 +0100 From: Daniel Schultz To: lee.jones@linaro.org, linux-kernel@vger.kernel.org Cc: w.egorov@phytec.de Subject: [PATCH 1/2] mfd: rk808: Change DEV_OFF to DEV_OFF_RST for rk818 shutdown Date: Mon, 5 Mar 2018 14:16:40 +0100 Message-Id: <1520255801-8557-1-git-send-email-d.schultz@phytec.de> X-Mailer: git-send-email 2.7.4 X-MIMETrack: Itemize by SMTP Server on Idefix/Phytec(Release 9.0.1FP7|August 17, 2016) at 05.03.2018 14:16:46, Serialize by Router on Idefix/Phytec(Release 9.0.1FP7|August 17, 2016) at 05.03.2018 14:16:46, Serialize complete at 05.03.2018 14:16:46 X-TNEFEvaluated: 1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org After running "poweroff", the PMIC restarts the SoC instead of shutting it down. It seems like the description for those two register bits is swapped. After changing from DEV_OFF to DEV_OFF_RST, the system can poweroff correctly. Signed-off-by: Daniel Schultz --- drivers/mfd/rk808.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/rk808.c b/drivers/mfd/rk808.c index 216fbf6..d138721 100644 --- a/drivers/mfd/rk808.c +++ b/drivers/mfd/rk808.c @@ -418,7 +418,7 @@ static void rk818_device_shutdown(void) ret = regmap_update_bits(rk808->regmap, RK818_DEVCTRL_REG, - DEV_OFF, DEV_OFF); + DEV_OFF_RST, DEV_OFF_RST); if (ret) dev_err(&rk808_i2c_client->dev, "power off error!\n"); } -- 2.7.4