Received: by 10.223.185.116 with SMTP id b49csp2656749wrg; Mon, 5 Mar 2018 06:43:35 -0800 (PST) X-Google-Smtp-Source: AG47ELt1z5qkQOAH3wqcKvhW0vHUjVoXn/uS8D8GGcKdqm0gPtr6BTp1n2SuDXS05IGKd00mB6de X-Received: by 10.99.123.74 with SMTP id k10mr12470082pgn.217.1520261015153; Mon, 05 Mar 2018 06:43:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520261015; cv=none; d=google.com; s=arc-20160816; b=FtWrsadQB14eVUSZGMmEbXqz5uLBTLfUAQBbCdlEYMi57KvfvoEmbred1yA0TRisAC nbbnyCnK/s3GKiGdL6ttsOcnMIlWH+FigM9nCv2I6Z+rMq0cGAXzCdn4MjO7se1qxo+9 wqL3Aq4WfIxY2Yp7GYtxXsXrqVIUa35TWLXBc0Hf4sevYrRFfWrK4EdVankIdja5hRMT 07GW5Cn7rioJ/3xo+JTaE48WD5ARdv9qwng6f7VjvTqRAoq94gh4MTRIs4zu4Z6WnjCA 7rER4MQbtLEyqxN3S0Siich70GsnK2Y5BhAS8qD8sw6rWnTBG0iyyxjj6FGDvfPAJ5tQ N7Ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=tR9VunwjmiNpoPUmUOzFxGlK8ejdKejtqfDv8y0q1dk=; b=hhy55ZeFTEGry4bRh+iJ68AcAoW+a1Gfn8CqYSrOtjqj0d9BCCiLGUJWSLNNapmr7K R1uBFztll+onQlw86XJwUfBu4Zbkdd1EF4v38I70CrkjiRBMnzmOpFcA/zYNXxcgHlv/ vXUm4qi7vF8W8LZp4Ph2CLQx1B0v6sBOuugI8HjtelRUC6eeofMleZM6hxlO+PnBzVYC 5ZvnHmvQVJEupvlgPXlDuLH+vdg26zNMtE8tWTQyKNDFuGXFQst636n4lxL9ilFtz7+F I4iVnlKWL9w+lYYZd9jx7CcFtNReErFv8yLWaWtMr+qI7fV8b0PXsy0cZGDGxeggjUp0 kWWw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z7si10267307pfg.278.2018.03.05.06.43.21; Mon, 05 Mar 2018 06:43:35 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932182AbeCEOmJ (ORCPT + 99 others); Mon, 5 Mar 2018 09:42:09 -0500 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:36768 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751818AbeCEOmG (ORCPT ); Mon, 5 Mar 2018 09:42:06 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 311428182D1E; Mon, 5 Mar 2018 14:42:06 +0000 (UTC) Received: from treble (ovpn-122-109.rdu2.redhat.com [10.10.122.109]) by smtp.corp.redhat.com (Postfix) with SMTP id 48211111E3E9; Mon, 5 Mar 2018 14:42:03 +0000 (UTC) Date: Mon, 5 Mar 2018 08:42:03 -0600 From: Josh Poimboeuf To: Miroslav Benes Cc: Joe Lawrence , Petr Mladek , Jiri Kosina , Jason Baron , Jessica Yu , Evgenii Shatokhin , live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v8 7/8] livepatch: Correctly handle atomic replace for not yet loaded modules Message-ID: <20180305144203.2u3i2jzznsb7swsn@treble> References: <20180221132914.4809-1-pmladek@suse.com> <20180221132914.4809-8-pmladek@suse.com> <20180301102859.zwrt6w36ub474nb2@pathway.suse.cz> <7f920ec3-dfe0-6a4d-dd25-5d5c4fa75714@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.0.1 (2016-04-01) X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Mon, 05 Mar 2018 14:42:06 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Mon, 05 Mar 2018 14:42:06 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'jpoimboe@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 05, 2018 at 10:54:16AM +0100, Miroslav Benes wrote: > > I think this problem is contained to only replacement patches that need > > the nop-revert feature... if the replacement patch provides a new > > function definition, then it shouldn't be affected. > > > > Man, we need a regression test suite for all these cases :) > > Any volunteer? I'd strongly prefer that we get such selftests in place before merging any more major features... -- Josh