Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 5 Mar 2018 16:22:11 +0100
From:   Michael Moese <mmoese@suse.de>
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Greg KH <gregkh@linuxfoundation.org>,
        Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
        Johannes Thumshirn <jthumshirn@suse.de>,
        Andreas Geissler <andreas.geissler@men.de>,
        Ben Turner <ben.turner@21net.com>
Subject: Re: [PATCH v3] 8250-men-mcb: add support for 16z025 and 16z057
Message-ID: <20180305152211.x423tgtwfanuwvwo@linux.suse.de>
References: <20180305082235.12777-1-mmoese@suse.de>
 <CAHp75VfVm5B7NawwYdzNFkCgJG+2Ht8pkAL0Drr08GJ+p2ZVow@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAHp75VfVm5B7NawwYdzNFkCgJG+2Ht8pkAL0Drr08GJ+p2ZVow@mail.gmail.com>
User-Agent: NeoMutt/20170421 (1.8.2)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi, sorry.. my bad. Not my day today. I forgot to commit :/

I'll resend.

On Mon, Mar 05, 2018 at 05:17:04PM +0200, Andy Shevchenko wrote:
> On Mon, Mar 5, 2018 at 10:22 AM, Michael Moese <mmoese@suse.de> wrote:
> > Add support for two MEN UARTs (16z025 and 16z057) to the
> > 8250_men_mcb driver.
> > The 16z025 consists of up to four ports, the 16z057 has
> > exactly four ports. Apart from that, all of them share the
> > Port settings.
> 
> > Changes to v2:
> > Added include of linux/io.h due to finding of kbuild robot.
> 
> Hmm... Is it there?
> 
> >  static int serial_8250_men_mcb_probe(struct mcb_device *mdev,
> >                                      const struct mcb_device_id *id)
> >  {
> 
> >         mem = mcb_get_resource(mdev, IORESOURCE_MEM);
> 
> >         if (mem == NULL)
> >                 return -ENXIO;
> 
> Redundant.
> 
> > +       membase = devm_ioremap_resource(&mdev->dev, mem);
> > +       if (IS_ERR(membase))
> > +               return PTR_ERR_OR_ZERO(membase);
> 
> > +       for (i = 0; i < num_ports; i++) {
> 
> > +               /* ok, register the port */
> > +               data[i].line = serial8250_register_8250_port(&data[i].uart);
> > +               if (data[i].line < 0) {
> > +                       dev_err(&mdev->dev, "unable to register UART port\n");
> > +                       return data[i].line;
> > +               }
> > +               dev_info(&mdev->dev, "found MCB UART: ttyS%d\n", data[i].line);
> 
> Consider to use  struct uart_port::name instead.
> 
> > +       }
> >
> >         return 0;
> >  }
> >
> >  static void serial_8250_men_mcb_remove(struct mcb_device *mdev)
> >  {
> 
> > +       if (!data)
> > +               return;
> 
> When it's possible?
> 
> >  }
> 
> -- 
> With Best Regards,
> Andy Shevchenko


-- 
SUSE Linux GmbH, GF: Felix Imend?rffer, Jane Smithard, Graham Norton, HRB 21284 (AG N?rnberg)