Received: by 10.223.185.116 with SMTP id b49csp2740207wrg; Mon, 5 Mar 2018 08:01:03 -0800 (PST) X-Google-Smtp-Source: AG47ELt1Rm+JfTE7BETRBLK08fQsiuYTq5wwVbPd4ch/XsjtpNmCbzIMiVpNafTFlXSKmVJzedWE X-Received: by 2002:a17:902:820a:: with SMTP id x10-v6mr13712592pln.364.1520265663280; Mon, 05 Mar 2018 08:01:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520265663; cv=none; d=google.com; s=arc-20160816; b=HeLnfPD53C2gbhf/M7pUVK3PMkpQWHErqSNklufzhMj7Yua34+ADVrIsxtBJDik9NU JB6U39sEJdItA3c1JjMp9248fUFHqQyYSiW5hQbvDerHSeBQC4XQmCw+NU7bWBVWRe7X 1QXRUOkeXDSUP6/Ck7+xVGO3y7+AGr4ytdjSLIjoK2Xe22kH+uT9gInFTxBAlRz+aPU9 oPNGO5zC6tBGIMwEhB2I1hUxw9dchuQ3BNX3Och+pi8YOqsBwH9+Q9tpjTGeck7QfurZ OH4NB7UX0NdUsqfgsF9G8hvnqt3M9IvLhIh48p/UkbxzoZOcj+1Ix5skw8U7T9tHkTnx K6ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=2Xm3Ek708nD+leYSANaa+ll6wcV6vCTOw8JMomNtyag=; b=WbuHPqVxeuN9yJyxk/DKCPuQ5sILULgy6rizTkSGYXXtRC1PkDNK0Q4kWcM0GAdhEt sfRaQ7E9duPFKsXp92duT7VbDlwnJidcLDY/YdA+wxCjQ94vbinYzS9hWDro/s0/pGgp 4Lz3jCNWAWNw7y8GbxS4sWwcBY8lFQqHQeZf400gEQjv0w+W6jWnd/IW1iEcV2u+PAkL N8fCd2r3hkifQ3fUYzINoGFkJA+AVwYaCfuR/28wEAjR9CinGICEAcHy93SbYsZNxVWS Z0cfwW0JwtcwJSKuxhuWSuWjjd/zY4TP8lMEJ6p5O4/5uEQpmKSMpqaKmpmACesFyIAP bh9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=s0yKXvtD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e10si151014pgu.428.2018.03.05.08.00.48; Mon, 05 Mar 2018 08:01:03 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=s0yKXvtD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932099AbeCEP7w (ORCPT + 99 others); Mon, 5 Mar 2018 10:59:52 -0500 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:50370 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751490AbeCEP7u (ORCPT ); Mon, 5 Mar 2018 10:59:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=2Xm3Ek708nD+leYSANaa+ll6wcV6vCTOw8JMomNtyag=; b=s0yKXvtDq014IjG4Cc9oSRQW4 dkeYMzaHf/57s5A0iWu2gDD284ySE2tbecaY9P3zpwfvDt9XDq0LhGYNNt++GhFKhGHEW4sSYq4/Z Q+oqKJP74er7IdhqD999Rk0Ljz3t+KHfpAwmlgBfJLMspPi2G+xsAZ1ajiEezemxW6vnw=; Received: from debutante.sirena.org.uk ([2001:470:1f1d:6b5::3] helo=debutante) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1essWZ-0005k0-7u; Mon, 05 Mar 2018 15:59:39 +0000 Received: from broonie by debutante with local (Exim 4.90_1) (envelope-from ) id 1essWY-0004y4-8G; Mon, 05 Mar 2018 15:59:38 +0000 Date: Mon, 5 Mar 2018 15:59:38 +0000 From: Mark Brown To: Alexandre Belloni Cc: =?iso-8859-1?Q?Myl=E8ne?= Josserand , lgirdwood@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com, perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, michael@amarulasolutions.com Subject: Re: [PATCH v2 1/2] ASoC: codecs: Add support for PCM1789 Message-ID: <20180305155938.GL8588@sirena.org.uk> References: <20180305124817.7421-1-mylene.josserand@bootlin.com> <20180305124817.7421-2-mylene.josserand@bootlin.com> <20180305154910.GJ8588@sirena.org.uk> <20180305155715.GJ3035@piout.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="j3olVFx0FsM75XyV" Content-Disposition: inline In-Reply-To: <20180305155715.GJ3035@piout.net> X-Cookie: Do not write below this line. User-Agent: Mutt/1.9.3 (2018-01-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --j3olVFx0FsM75XyV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Mar 05, 2018 at 04:57:15PM +0100, Alexandre Belloni wrote: > On 05/03/2018 at 15:49:10 +0000, Mark Brown wrote: > > Please don't mix C and C++ style comments in a single comment like this > > - it looks unintentional. Just use the same style for the whole thing. > > You also don't need to include all the boilerplate with the SPDX header. > I think Linus made it clear that he wants the SPDX header to be a > C++ comment, the documentation has: Sure, so make the entire thing a C++ comment then. --j3olVFx0FsM75XyV Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEyBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlqdaWkACgkQJNaLcl1U h9CiUgf40Hp+gzXwR2TkhGpq5wjdnZSOKngsP8WUfonuZTnnEkE2ejOVjAMVgpOM U0ljr1dg/Hg6tfbWNFRYflY31V+PPjfw+KnPuqNxjNFYj1t5GTL3sTrjrLf8RwSU v1mgbevFejwxwk4vDhhdx869XZIiWUfnGk7vfAxJIQDi0BWfB6b31nBQmPv11sO0 pXi/l/ZBtmP29pfLoM1XxzKC3zwZ3dn9ESVkKMgKlnBUGGjsqHpNZTEmj+VB3KHL Sg9nTyqmF5zwiNBNnddqriWee+2M+/7ZUBUWj+inCCfC7mLkbFZfB43BHVfl20cl kY2El6N9CDLWgJHJUYA4Y8RQRhAe =er+z -----END PGP SIGNATURE----- --j3olVFx0FsM75XyV--