Received: by 10.223.185.116 with SMTP id b49csp2967790wrg; Mon, 5 Mar 2018 11:38:27 -0800 (PST) X-Google-Smtp-Source: AG47ELtMJPeyz6kK88NRyKQbgxqMiF4mxgmqrbyOtopJBjJ+fFd7HW/eWwxZ4E1Npk+RCy8o/H96 X-Received: by 10.99.138.74 with SMTP id y71mr13270653pgd.419.1520278707592; Mon, 05 Mar 2018 11:38:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520278707; cv=none; d=google.com; s=arc-20160816; b=q1EoGFc0sUeYDXfGpBLnAgVcGORQsjUoDQRGqpNuj6fKewDySNu/ZDXwehtCL56WCQ kRFFm8lstmW3/rwZVo9kJN6AO0XXyli0AaMUB4vp62qUwFNjXpDTCarqg69PqHaD5IAJ v9Q3zGsH8SDtf6MV80GRdVuABrVqSBe1PIHckoshOHXwQ/pL6g9rovSHptASZByY55Mg aIgOHSn6OpOVJ5NrPiL8VYFqoJwnsuO8Ld2Gbm5rCW4Fa9ytEhm8sDJU3oUe6UX7sknS ulMT+OKTRNG5QqioY2QCl90qHqAuIq9MqWT8qTAzMan/ocWnEjAU1b+vNiB4cHfvxOPl zKlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=ThwfKO81QuMtjgWN1sWYamzrMf8K6daY3gHs6Pk6uAw=; b=utfzD0/kMii/vv90gPSEA/oZwuTrkImmu3AKxJUrzD8uYqzYB+WaoX0KfxM3cjvaT8 FPgGFS50CHUgMc13yrwd1I3XGa24n00HM3TMOu641KCWzu+RZVateTm/m7I0clEknwiA PuA2IZ16t44+h6VN8BNBOwQJvYUf0ZQvQggm7VGNJDri2KRmvkGBLEGCLFKZPoltDwYY DE6RB3D/7L1yQMivWO8iVadc0d4JksMqh41woikLZXAHeDm8YmdAJOiT4OqzCip/W/Fi CEoWiaohPShvd73kTVvaUT3ds5NOwWSyBTozSrbfcXgwCxMID6F/cHrvwdza9s5JzdP2 aLAg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=bN8NbwtI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j6-v6si9616106pll.799.2018.03.05.11.38.12; Mon, 05 Mar 2018 11:38:27 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=bN8NbwtI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752460AbeCEThQ (ORCPT + 99 others); Mon, 5 Mar 2018 14:37:16 -0500 Received: from mail-pf0-f174.google.com ([209.85.192.174]:39665 "EHLO mail-pf0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751462AbeCEThO (ORCPT ); Mon, 5 Mar 2018 14:37:14 -0500 Received: by mail-pf0-f174.google.com with SMTP id u5so7653277pfh.6; Mon, 05 Mar 2018 11:37:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=ThwfKO81QuMtjgWN1sWYamzrMf8K6daY3gHs6Pk6uAw=; b=bN8NbwtI7iefTbtRS0+bKXYWMTgSlZcd2um3Z8AYyyxfqUluCm8P+hP2Iz+41d4YA4 0QcS4As8LzAFYiWxS6erB/O1c2LqixVGzml6Kv9uFDF9Wv3/Sg6xAWcfOewyAimku9jm pwgH+EfBNGJ4KjbDjY5wA1HaPLR3ofcWHKdFAWsyIDU1d1EHODaUsRydWL50NZ79hDQf TTJreQTsKVu8ROiLxO09DwrlA+e48Tylhxmvb48WZW+Kqr6DONK0yJtuRW/Doxqfuvaz GY0eXLQ3/0CUd3qG2UibB/xvLF16/4OoTOWA9kRJSxy2xZVyZhBXyTu3FpdoqPg1zydc tsvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=ThwfKO81QuMtjgWN1sWYamzrMf8K6daY3gHs6Pk6uAw=; b=lRzhmtD/BoElCCSExYh2pFxFVVyhVebkgNubMBU1+U6DOI1BurdwU+jjIQ1OIV0FBY QZLo0Ls8S4F9KDk7ruGRN0n+kIB8w4kXf6EZdJdWAmvSHo782gIqe8xKULpszrTv8Z/Z O4+QJbEhoNW1cuMxyrxUM0gcw7AhVNUpAgrju4ns28m9pRcWCDzDxIQF1FoaQkt0VOya vQoSdSCTicMF57bnKjdKdbGbvNPAufyP0bLIgAUfq3yhdIibpmaniP5qQkMyOQZNnY7L +8zCwuulonkz766A+hgl5vFDjNvrAxJRl+CvWiOaQAmurg/h32vCD8D9diLpm/3GZnHK Bixw== X-Gm-Message-State: APf1xPBAb7STurJjgz0G9xflIwHVQP6dzCsGrxcQT4LN6CSqdf9yI28n AvacrWSXZQyjcmIEXdqjWes= X-Received: by 10.101.80.193 with SMTP id s1mr12978204pgp.254.1520278633984; Mon, 05 Mar 2018 11:37:13 -0800 (PST) Received: from JF-EN-C02V905BHTDF.tld ([12.111.169.54]) by smtp.gmail.com with ESMTPSA id p16sm28453425pfd.77.2018.03.05.11.37.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Mar 2018 11:37:13 -0800 (PST) Subject: Re: [PATCH 2/7] genalloc: selftest To: Igor Stoppa , david@fromorbit.com, willy@infradead.org, keescook@chromium.org, mhocko@kernel.org Cc: labbott@redhat.com, linux-security-module@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-hardening@lists.openwall.com References: <20180228200620.30026-1-igor.stoppa@huawei.com> <20180228200620.30026-3-igor.stoppa@huawei.com> From: J Freyensee Message-ID: <488cc366-bd10-425c-ef62-ce8536e3c62a@gmail.com> Date: Mon, 5 Mar 2018 11:37:10 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180228200620.30026-3-igor.stoppa@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > + > +/* > + * In case of failure of any of these tests, memory corruption is almost > + * guarranteed; allowing the boot to continue means risking to corrupt > + * also any filesystem/block device accessed write mode. > + * Therefore, BUG_ON() is used, when testing. > + */ > + > + I like the explanation; good background info on why something is implemented the way it is :-). Reviewed-by: Jay Freyensee