Received: by 10.223.185.116 with SMTP id b49csp2999067wrg; Mon, 5 Mar 2018 12:11:52 -0800 (PST) X-Google-Smtp-Source: AG47ELviZ5QblBWr+fFkzc9K41OeLws9NA1elVKPhJC8vlKshrJPYihqiqklJ/D10m36W4n2u2ut X-Received: by 2002:a17:902:43e4:: with SMTP id j91-v6mr1626451pld.2.1520280712622; Mon, 05 Mar 2018 12:11:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520280712; cv=none; d=google.com; s=arc-20160816; b=0u95hh2ojBaLyM8dEZc3TGol21ekitHA8/Gi7lv/nMm6PkGigpXuC7etNCWfo3iBgn c0J6pjReCWEyCzye8+lwX5M9qs21L+eV8uSPZm3DFaelZ4XqvVqDGkhNJ4ke+X/W8tv+ QEYh/IOkXvPAJgyYVdVI2QGckx/bwt19ot3jDB8idWeXR9yPA2nPuZ6GWpMhcsfSTk9A DVewSv1qsuCzWncjwpR4zIvhBRPVo9fp+QbzX5IWsaiatZb5wPclmrIi90BIMrIq8uhw jo9I0r8YVTP/vQ1OSMn/he7nHTP2ywU52gpvM7r2JjIr3WqWKt/5LdoUGzqaiIW785Hp E7dQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-id:spamdiagnosticmetadata:spamdiagnosticoutput :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=10jO3OsGJlryjoDKIw+agVbpwc38QJzfp+Mp5UE7hNo=; b=iZOO4RyRRoaIO+vH0s4JvBQxDe9IM/ecSpjTp+kmXZWJfyJvP2tbi783u09zjRfVRj U1AM8lyzJHrFxbRXYnlCYJ+4eQ9T7OUfj8Kag+twDk37Fw7vZ+YuOzTA7F9c+/f7tR9x Nsz8xS0shlEw6CKFg8QN2sknpbA6KTsieOPIJRLiBQ06yPpmAC83NUPoDq0B3yAissMl 7i22Hfhz9M3fSGpbipt8njY8QMc8Mjtkbd8JwuFDKeL4bnHFfW0n2T1a5243wCfY/VxK mvle4G5A6gbL8vRd5jZiPvTIxyi13usj8F2Xnv8Fbp591bD3p37iYL9UeCxvNRzaWuup r9gQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=iBXwsSHS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b1si8731921pgn.191.2018.03.05.12.11.38; Mon, 05 Mar 2018 12:11:52 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=iBXwsSHS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753078AbeCEUKK (ORCPT + 99 others); Mon, 5 Mar 2018 15:10:10 -0500 Received: from mail-by2nam03on0108.outbound.protection.outlook.com ([104.47.42.108]:44876 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752321AbeCEUKI (ORCPT ); Mon, 5 Mar 2018 15:10:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=10jO3OsGJlryjoDKIw+agVbpwc38QJzfp+Mp5UE7hNo=; b=iBXwsSHSToJYx2807fHuGC+Wv6yjhy8wNUwnlkLjkIbuX5+iIgqkEvkxskpnbvsBnW8bZVHTxvm5or+vVRsj34It5Ni8H++tbjno3SbFVtH2/0ONmUmClAJMhJ/j9mcHrvOdrqmnijURv3azV66/StKP1DzU97Ny4mXkTCqpaZU= Received: from DM5PR2101MB1032.namprd21.prod.outlook.com (52.132.128.13) by DM5PR2101MB1047.namprd21.prod.outlook.com (52.132.128.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.588.1; Mon, 5 Mar 2018 20:09:29 +0000 Received: from DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::8063:c68a:b210:7446]) by DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::8063:c68a:b210:7446%2]) with mapi id 15.20.0588.001; Mon, 5 Mar 2018 20:09:29 +0000 From: Sasha Levin To: Mark Brown CC: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , Javier Martinez Canillas Subject: Re: [PATCH AUTOSEL for 4.9 111/219] ASoc: rt5645: Add OF device ID table Thread-Topic: [PATCH AUTOSEL for 4.9 111/219] ASoc: rt5645: Add OF device ID table Thread-Index: AQHTsz8G3m7zhT9nPUWUywJnKNOuCKPBdrOAgACeiIA= Date: Mon, 5 Mar 2018 20:09:29 +0000 Message-ID: <20180305200927.rdn35ktxxsnx2hu2@sasha-lappy> References: <20180303222716.26640-1-alexander.levin@microsoft.com> <20180303222716.26640-111-alexander.levin@microsoft.com> <20180305104203.GD8588@sirena.org.uk> In-Reply-To: <20180305104203.GD8588@sirena.org.uk> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DM5PR2101MB1047;7:5fRZTmORWW770FsrUTphprdXTFH/ECB6j7EE4U1pPB8+juHk3+bwg40E2IkCkVwlFKUhrvKUksaGswRVl/GlZQDYn05Q48F9rKoaPFO0Cc8YYpw2LEExUYTQ9K/ao8/E7fASXb9c3wqLtJNV//L+a1XDInD3bZNzm8HYQplYDaCAtmRJfyQ8Lqb8LAYLYp1ptCO1ft7+e6LynvCvu7FqMvx2Cw7twR2Xxtln2De79CXW2c7vvaFnamUqXdYOhmPd;20:hcpEPeTFcx7AqbZxkNivDfsPR0+YyzxHeDiLoaebmVVIeUxmLoPbn4BcFNoLCE/Eu+2MeM0kq/VVBEBNWxTHiTc7+sGZKK6Domm3tCKAhIcad50uG0TQarTHwaY9cUyqjaySvBqT9OtLY+Rb5AvXbPvMfDaRWg+cJBKBB7aTiuc= x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 884c0868-bb0c-4f95-7113-08d582d500a4 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603322)(7193020);SRVR:DM5PR2101MB1047; x-ms-traffictypediagnostic: DM5PR2101MB1047: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(7411616537696); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(61425038)(6040501)(2401047)(8121501046)(5005006)(93006095)(93001095)(3231220)(944501244)(52105095)(10201501046)(3002001)(6055026)(61426038)(61427038)(6041288)(20161123558120)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(6072148)(201708071742011);SRVR:DM5PR2101MB1047;BCL:0;PCL:0;RULEID:;SRVR:DM5PR2101MB1047; x-forefront-prvs: 06022AA85F x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(7916004)(39860400002)(346002)(396003)(376002)(39380400002)(366004)(189003)(199004)(81166006)(86612001)(86362001)(53936002)(6246003)(4326008)(8936002)(72206003)(10090500001)(14454004)(33716001)(1076002)(2900100001)(229853002)(6436002)(9686003)(66066001)(68736007)(6512007)(81156014)(8676002)(6486002)(76176011)(99286004)(25786009)(6116002)(54906003)(5250100002)(3846002)(6916009)(305945005)(2950100002)(316002)(105586002)(26005)(6506007)(33896004)(2906002)(97736004)(3280700002)(5660300001)(10290500003)(7736002)(106356001)(186003)(102836004)(478600001)(3660700001)(22452003)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5PR2101MB1047;H:DM5PR2101MB1032.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: Qb4uQD7ASu/Yx8Wjpg87XreAu7gvI2N4RsETb6P/c0HGAbm06dq5D0qpyUPMiKPl5HKUDD1riuUGNNWbQHElHoN0DTNu5jD6akTB2uVcMaed8+JcNzSw32ojPXnRvJpmAMbmjtvqTb+DSeBGw0e9/lmgTEn8TX6zwDSSLpTVcNDQpA/vMs6x/oqW4T/OTBTVFnZAQ3aIm3byIPdi083/SSyqJmorH7+w0/ZXRBqyp8dm4K82andMmKjt8xw+aqQ/osLa6LZhqYUavkiDe83PTPe0PsNoCPYwHnLH+JfTx30Tzn6Shtn54p2QK1SdTfN0ua1eCbrhZMcjKD4wGS8FcQ== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: <59F2CE3CB0A6DD44A4EBB79FD99F9934@namprd21.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 884c0868-bb0c-4f95-7113-08d582d500a4 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Mar 2018 20:09:29.2274 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR2101MB1047 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 05, 2018 at 10:42:03AM +0000, Mark Brown wrote: >On Sat, Mar 03, 2018 at 10:29:00PM +0000, Sasha Levin wrote: >> From: Javier Martinez Canillas >> >> [ Upstream commit 9ba2da5f5d18daaa365ab5426b05e16f1d114786 ] >> >> The driver doesn't have a struct of_device_id table but supported device= s >> are registered via Device Trees. This is working on the assumption that = a >> I2C device registered via OF will always match a legacy I2C device ID an= d >> that the MODALIAS reported will always be of the form i2c:. >> >> But this could change in the future so the correct approach is to have a= n >> OF device ID table if the devices are registered via OF. > >As the commit message itself says this is not fixing anything, it's >defence against future changes. I was under the impression that this refers to future HW changes rather than code, I'll drop all 3. Thanks! --=20 Thanks, Sasha=