Received: by 10.223.185.116 with SMTP id b49csp3096333wrg; Mon, 5 Mar 2018 14:07:53 -0800 (PST) X-Google-Smtp-Source: AG47ELvd3NDxn3EKDOC0TOAo4cj8krHDEEtG3eIbEQtck/yMK6F3vx2vx6X+cVXE7VB8NKLZAOfp X-Received: by 2002:a17:902:b712:: with SMTP id d18-v6mr9478644pls.417.1520287672878; Mon, 05 Mar 2018 14:07:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520287672; cv=none; d=google.com; s=arc-20160816; b=CDZztB2itkw2e2nPMGN0VB7/iv94ulAXmIEGKTkWtKLI/mnnpKr9vDdAsYhdjYN1ou 1NTk3844mr4iqOlQ3db75wYYk0cTUP43TcABSv3XHK/fWltudLsJZbX9vOcF2yjgdHmP jmd7KQqc6S2i3PSLpNTdKH2/LYPfGQzgy7l47ldLdxEI52HZVSvd7OsmzQnVQEumZaQX Gz8YgIaghU9S0EcTZZQEju8PB/yiSB1qO2PzkiUB9QC1I19RmdNHcH0AALxx0o524MOp zi2ToCadQKM7DOmy6Ogv5J1b3N4R+8tf3iRUtUvE6soxecrNRBzKPrni7STW+EF4IWGA WP0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:content-disposition :mime-version:message-id:subject:cc:to:from:date :arc-authentication-results; bh=PsG3mLM5O3/G6k5ZE/MTGPqv73kVWJEY/e4w9hyF1iw=; b=fRWGVYwYBDrMl5gtpB+5zQV+MM0pUtCBHsq+07vrugnIMKEFFLurgT4y6ReQKMi4d5 txaoclGk2IkEkGmRiB2fbgP7m/bnVZNp5qOT1kK49rETpJB7C1CJuaALXRgRf/oLmJ8f ChVpIkQo+AzKnEgFREwg7FUQeJQ42wBwhdH2TIo6zl8r2BqySox8wGQC8U4oUO4FV4Qn CS1/767KIQ2jpMRz1vCQOqnRMx9tDFhP4GfpllKhZuBdMmArJoEokTb4CeK4DFE6Q9Gl FH3flQIyxYiScvMQ+IqiKc2tugpOgLlqG6aTOpm2Ve7KKgXezYqN05uaiyLh1s3+Kx+g KdeA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g23si4559738pfb.87.2018.03.05.14.07.39; Mon, 05 Mar 2018 14:07:52 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753239AbeCEWFj (ORCPT + 99 others); Mon, 5 Mar 2018 17:05:39 -0500 Received: from gateway33.websitewelcome.com ([192.185.145.190]:39163 "EHLO gateway33.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753067AbeCEWFi (ORCPT ); Mon, 5 Mar 2018 17:05:38 -0500 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway33.websitewelcome.com (Postfix) with ESMTP id ACDB0112BD30 for ; Mon, 5 Mar 2018 16:05:37 -0600 (CST) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id syEjetltTRMsBsyEjeB6E6; Mon, 05 Mar 2018 16:05:37 -0600 Received: from 187-162-245-224.static.axtel.net ([187.162.245.224]:41312 helo=embeddedor) by gator4166.hostgator.com with esmtpa (Exim 4.89_1) (envelope-from ) id 1esyEj-002CHP-6k; Mon, 05 Mar 2018 16:05:37 -0600 Date: Mon, 5 Mar 2018 16:05:37 -0600 From: "Gustavo A. R. Silva" To: Dmitry Tarnyagin , "David S. Miller" Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH] caif_dev: use true and false for boolean values Message-ID: <20180305220537.GA15924@embeddedor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 187.162.245.224 X-Source-L: No X-Exim-ID: 1esyEj-002CHP-6k X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 187-162-245-224.static.axtel.net (embeddedor) [187.162.245.224]:41312 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 4 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Assign true or false to boolean variables instead of an integer value. This issue was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- net/caif/caif_dev.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/net/caif/caif_dev.c b/net/caif/caif_dev.c index e0adcd1..f2848d6 100644 --- a/net/caif/caif_dev.c +++ b/net/caif/caif_dev.c @@ -139,7 +139,7 @@ static void caif_flow_cb(struct sk_buff *skb) spin_lock_bh(&caifd->flow_lock); send_xoff = caifd->xoff; - caifd->xoff = 0; + caifd->xoff = false; dtor = caifd->xoff_skb_dtor; if (WARN_ON(caifd->xoff_skb != skb)) @@ -213,7 +213,7 @@ static int transmit(struct cflayer *layer, struct cfpkt *pkt) pr_debug("queue has stopped(%d) or is full (%d > %d)\n", netif_queue_stopped(caifd->netdev), qlen, high); - caifd->xoff = 1; + caifd->xoff = true; caifd->xoff_skb = skb; caifd->xoff_skb_dtor = skb->destructor; skb->destructor = caif_flow_cb; @@ -400,7 +400,7 @@ static int caif_device_notify(struct notifier_block *me, unsigned long what, break; } - caifd->xoff = 0; + caifd->xoff = false; cfcnfg_set_phy_state(cfg, &caifd->layer, true); rcu_read_unlock(); @@ -435,7 +435,7 @@ static int caif_device_notify(struct notifier_block *me, unsigned long what, if (caifd->xoff_skb_dtor != NULL && caifd->xoff_skb != NULL) caifd->xoff_skb->destructor = caifd->xoff_skb_dtor; - caifd->xoff = 0; + caifd->xoff = false; caifd->xoff_skb_dtor = NULL; caifd->xoff_skb = NULL; -- 2.7.4