Received: by 10.223.185.116 with SMTP id b49csp3110368wrg; Mon, 5 Mar 2018 14:24:25 -0800 (PST) X-Google-Smtp-Source: AG47ELsWxYGfELg9M4CvQG2AM8UTlq+aQwJqWN14l3us3Pl1OKfUAt1nf/wVHrvD/bg90Zy7b4+v X-Received: by 2002:a17:902:788e:: with SMTP id q14-v6mr14638819pll.396.1520288665764; Mon, 05 Mar 2018 14:24:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520288665; cv=none; d=google.com; s=arc-20160816; b=ttuxS0BfiGGBgsn75qK6sJ+hjkmdQk7Id5y5eDvqsb82Gvvrq/Vwfh3msmWQBREESE DzLELAVFYvZ4/Yhmq2yPAmoUfqrh82hrtWEJCPQ+PF2Jj569ECXFluqfAfp9AJHfcIj5 PxTrlpV9pYAOIgD/ys3/KlTTDTU83OGWz0gFsn1m6DMqDngj4yFYne3ncyrfMwR5xntV SpAgwSf3BUHX3ztpK1WfOpgsyDSSnf3gQLZUHeQRAaPDWMT3y9MIFI9pXPw/bMCVTXak grOSEPcFo28ByExDQ4WRiCaH/9JX2f9aNBtxjHNEbwLHA1ggCKkD0+u67zZF1Z70G/5L sy2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:arc-authentication-results; bh=9pYbrGa9qbqZ1apWnF8Ln3m+rZQ7MIshCzvQTbSG+sA=; b=ZUzRtfd4njagq2Iu2G4G9PXypOVr2a0ekPpAXflVMqsqZsg1gTA2Y00D3J55y9RUja nvJfyFbX84Nz0hQWzaJqzN0vTRXC4GM8g2diE3wed5S7tXR8FAacXoMyvpuyUMJ2nghZ 7QKfi2XxPGipIvtzP1z4l8OLq7tKYJ2Zdm0A2V8EKH1yrvMfP8+JMk4QdRCfQdzltF4Z y70Xqj8FJSQyt3UZwZVEC09VtZ/SSslgnTVOHJyt2EtQ44Kct9avv4/B1FrGJZA9O00j 2ZXO9putkuCdtcw804Y27AZ59/R0pgC23mwZNv0E8rQlvDO9Vjg/SL7p+x0Gyh1Jns14 XDlw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n18si10705822pfi.262.2018.03.05.14.24.11; Mon, 05 Mar 2018 14:24:25 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753162AbeCEWW5 (ORCPT + 99 others); Mon, 5 Mar 2018 17:22:57 -0500 Received: from gateway22.websitewelcome.com ([192.185.46.126]:15202 "EHLO gateway22.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753053AbeCEWWz (ORCPT ); Mon, 5 Mar 2018 17:22:55 -0500 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway22.websitewelcome.com (Postfix) with ESMTP id D6F60FDE8 for ; Mon, 5 Mar 2018 16:22:54 -0600 (CST) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id syVSeQpp6KqqrsyVSe2qEt; Mon, 05 Mar 2018 16:22:54 -0600 Received: from 187-162-245-224.static.axtel.net ([187.162.245.224]:59312 helo=[192.168.15.106]) by gator4166.hostgator.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.89_1) (envelope-from ) id 1esyVS-002SPy-Bx; Mon, 05 Mar 2018 16:22:54 -0600 Subject: Re: [PATCH] netfilter: ipt_ah: return boolean instead of integer To: Pablo Neira Ayuso Cc: Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Alexey Kuznetsov , Hideaki YOSHIFUJI , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20180213142557.GA9008@embeddedor.com> <20180305221027.vmailsqb5gkvxmcg@salvia> From: "Gustavo A. R. Silva" Message-ID: Date: Mon, 5 Mar 2018 16:22:49 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180305221027.vmailsqb5gkvxmcg@salvia> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 187.162.245.224 X-Source-L: No X-Exim-ID: 1esyVS-002SPy-Bx X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 187-162-245-224.static.axtel.net ([192.168.15.106]) [187.162.245.224]:59312 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 19 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/05/2018 04:10 PM, Pablo Neira Ayuso wrote: > On Tue, Feb 13, 2018 at 08:25:57AM -0600, Gustavo A. R. Silva wrote: >> Return statements in functions returning bool should use >> true/false instead of 1/0. >> >> This issue was detected with the help of Coccinelle. > This one didn't get in time for the previous merge window. > > Now applied, thanks. Great. Thanks, Pablo. -- Gustavo