Received: by 10.223.185.116 with SMTP id b49csp3113350wrg; Mon, 5 Mar 2018 14:28:23 -0800 (PST) X-Google-Smtp-Source: AG47ELtQg70DigpSY1dHezUt9WnC1Lw34w1a79amtPtLCyW1IdXxK+ua7KOIbgOV2Dk11hDATv6q X-Received: by 2002:a17:902:a613:: with SMTP id u19-v6mr14083859plq.92.1520288903430; Mon, 05 Mar 2018 14:28:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520288903; cv=none; d=google.com; s=arc-20160816; b=xpP2XGiT5n9hTqYDVWLwNY7lU7GagjL8/8IBmJ3boDcLqemDBqIgPKniLmBiFh5JTJ 0MGKWbWO2l5Z+4oIwdB9cgozmZfvpQVAxC0dOyPcUtAnFsrT3MFZday+S+/lIlq6Q+J4 oOnadFri4Y8wiQkgev+B4GwXXuGAQ+Pi0lpVrZ/Bvz3qeIb9lOA7fK2jUb+NudN8Ev2P K+9oONsZKDTWzts8VpZyQp4kHKhJnpJuo6K6CItl+emtqc4k/XAPlhbtSN+Di8n8meWb K1XYXpVTV8EMa6gkgiuifDUJ8vuMo3PxCqAavB1eRnuRD+YJytZD6dgVnlE1hEG+lJYP 2JTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=KUVeEYd2UDbvZwIj76J5RS/uh5RVpKV8w+PYPGjsb/I=; b=MfUJ3WML+YDbwtDZgFMYBp/wH3uEDHxUSBZqPb4XmkscdD69dGRhGcQQSqJORsFDjq O0wWM3kyRg8QJTNXcrEYlX0WbnHxN2XBKvP6bZhk4SxKyDkf1W3J7LvpLXU3omBq2ccy wkL8RBKSCPT+zUBExGvXdSb6cBVCd3bPNY+hkv0BwlxR3u1lsRVSBYBXXRYS3hPJp0Qa jIL43iQA6I5vVKLtUTnoE4tRc0adJzJFSlcvJoBL3tgcQ3kaop9di1Ek5a4zqO2VBfqB 6+AiJWbS63REdtYViuY96r3z0WH+rqYMKvWJwrGslazwkTZtQnvGYesf6iWHT1vN/dPo I1Fg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j9-v6si9923510pll.326.2018.03.05.14.28.09; Mon, 05 Mar 2018 14:28:23 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753559AbeCEWYm (ORCPT + 99 others); Mon, 5 Mar 2018 17:24:42 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:37626 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753492AbeCEWYg (ORCPT ); Mon, 5 Mar 2018 17:24:36 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: eballetbo) with ESMTPSA id 4D8CC273342 From: Enric Balletbo i Serra To: architt@codeaurora.org, inki.dae@samsung.com, thierry.reding@gmail.com, hjc@rock-chips.com, seanpaul@chromium.org, airlied@linux.ie, tfiga@chromium.org, heiko@sntech.de Cc: hshi@chromium.org, wzz@rock-chips.com, hl@rock-chips.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, dianders@chromium.org, linux-rockchip@lists.infradead.org, orjan.eide@arm.com, m.szyprowski@samsung.com, Enric Balletbo i Serra Subject: [PATCH v4 23/38] drm/bridge: analogix_dp: Fix timeout of video streamclk config Date: Mon, 5 Mar 2018 23:23:15 +0100 Message-Id: <20180305222324.5872-24-enric.balletbo@collabora.com> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180305222324.5872-1-enric.balletbo@collabora.com> References: <20180305222324.5872-1-enric.balletbo@collabora.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: zain wang The STRM_VALID bit in register ANALOGIX_DP_SYS_CTL_3 may be unstable, so we may hit the error log "Timeout of video streamclk ok" since checked this unstable bit. In fact, we can go continue and the streamclk is ok if we wait enough time, it does no effect on display. Let's change this error to warn. Cc: Douglas Anderson Signed-off-by: zain wang Signed-off-by: Sean Paul Signed-off-by: Thierry Escande Reviewed-by: Andrzej Hajda Signed-off-by: Enric Balletbo i Serra --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c index c93a0d125b87..2493a580e655 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c @@ -921,8 +921,9 @@ static int analogix_dp_config_video(struct analogix_dp_device *dp) done_count = 0; } if (timeout_loop > DP_TIMEOUT_LOOP_COUNT) { - dev_err(dp->dev, "Timeout of video streamclk ok\n"); - return -ETIMEDOUT; + dev_warn(dp->dev, + "Ignoring timeout of video streamclk ok\n"); + break; } usleep_range(1000, 1001); -- 2.16.1