Received: by 10.223.185.116 with SMTP id b49csp3117345wrg; Mon, 5 Mar 2018 14:33:06 -0800 (PST) X-Google-Smtp-Source: AG47ELss5NDrpUWild6sljA3loMRVb/8vPtRrcx8GWwFDYCUHLy3S0WTzEcDRIFnskD/bSNC6dSs X-Received: by 2002:a17:902:7e44:: with SMTP id a4-v6mr6488313pln.392.1520289186630; Mon, 05 Mar 2018 14:33:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520289186; cv=none; d=google.com; s=arc-20160816; b=pbEtdDHso+DIl5HwkK+UhdzQsvdNL3l1nNVfk3ZublAcZCreWp0PggEfdqwaZUiKpe 4vsLk8MUnmmqeLeCg/3jb1qiE19iGVPMRUd2MART2A7VC4zfEuTrZmQZj0MzD2JAv+kx eoWoKw6lF8kA1sl4KgvzUnBdor8K/oNIFsWDNdRa48G6Fx3/D1KsuD7QgJIgKhud1BgY 9L4AcvosbvNbPUlZTNb8Adpgviio2+qqM8B701JANiDRBF62trzm1j3A6Qt2Oujh4SSm l6zjwXY/PxStJ/3oUljq8G68VEU+hTwzBi3UVqFeirjFHb4e2h8XvbnPCbkeXODJxCrs Pvcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=mhTwlcbJ1biYCBCt74eilS7tqp8+bhDPlJO7bTNMN1A=; b=Dla9oGm9ldmt30qIq0QhF5WmYypuoH/jez6248D+ODbWUnAU6ge0rvoLJPO/V42zgA Z+t6pmmAHnOI6V30AzKQnbAG6NdVWOjTshsQVTDwOe57t0chHBvux3f/g6vA/Ayt0DrW VPg/FUnmvmD4txBPnHVemFqG9F9cQkWcTkZpkA68INKJjAmzhWVN/ddHhm2hjQD6NSDP r//YWM3KKRfr8oi1rIhN2dOqIGql5g4NfPI85Nf2aXNwxms5/lVpKoWrkT3jei+ZUexW B6UMO0oNF34tXE/e/04CYscQ6MILaGkaO6Rms3VgzPp0PzZNUohZ6sT5m3zMwV85wd48 kdmA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s1-v6si6218530plr.671.2018.03.05.14.32.52; Mon, 05 Mar 2018 14:33:06 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932663AbeCEWbR (ORCPT + 99 others); Mon, 5 Mar 2018 17:31:17 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:37330 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753356AbeCEWXz (ORCPT ); Mon, 5 Mar 2018 17:23:55 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: eballetbo) with ESMTPSA id 63AE3273342 From: Enric Balletbo i Serra To: architt@codeaurora.org, inki.dae@samsung.com, thierry.reding@gmail.com, hjc@rock-chips.com, seanpaul@chromium.org, airlied@linux.ie, tfiga@chromium.org, heiko@sntech.de Cc: hshi@chromium.org, wzz@rock-chips.com, hl@rock-chips.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, dianders@chromium.org, linux-rockchip@lists.infradead.org, orjan.eide@arm.com, m.szyprowski@samsung.com, =?UTF-8?q?St=C3=A9phane=20Marchesin?= , Enric Balletbo i Serra Subject: [PATCH v4 09/38] drm/bridge: analogix_dp: Move enable video into config_video() Date: Mon, 5 Mar 2018 23:23:01 +0100 Message-Id: <20180305222324.5872-10-enric.balletbo@collabora.com> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180305222324.5872-1-enric.balletbo@collabora.com> References: <20180305222324.5872-1-enric.balletbo@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Lin Huang We need to enable video before analogix_dp_is_video_stream_on(), so we can get the right video stream status. Cc: 征增 王 Cc: Stéphane Marchesin Signed-off-by: Lin Huang Signed-off-by: Sean Paul Signed-off-by: Thierry Escande Reviewed-by: Andrzej Hajda Signed-off-by: Enric Balletbo i Serra --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c index 5a2e35dc41e3..f9661b410cb9 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c @@ -819,11 +819,10 @@ static int analogix_dp_config_video(struct analogix_dp_device *dp) if (analogix_dp_is_slave_video_stream_clock_on(dp) == 0) break; if (timeout_loop > DP_TIMEOUT_LOOP_COUNT) { - dev_err(dp->dev, "Timeout of video streamclk ok\n"); + dev_err(dp->dev, "Timeout of slave video streamclk ok\n"); return -ETIMEDOUT; } - - usleep_range(1, 2); + usleep_range(1000, 1001); } /* Set to use the register calculated M/N video */ @@ -838,6 +837,9 @@ static int analogix_dp_config_video(struct analogix_dp_device *dp) /* Configure video slave mode */ analogix_dp_enable_video_master(dp, 0); + /* Enable video */ + analogix_dp_start_video(dp); + timeout_loop = 0; for (;;) { @@ -948,9 +950,6 @@ static void analogix_dp_commit(struct analogix_dp_device *dp) DRM_ERROR("failed to enable the panel\n"); } - /* Enable video */ - analogix_dp_start_video(dp); - dp->psr_enable = analogix_dp_detect_sink_psr(dp); if (dp->psr_enable) analogix_dp_enable_sink_psr(dp); -- 2.16.1