Received: by 10.223.185.116 with SMTP id b49csp3183855wrg; Mon, 5 Mar 2018 16:01:18 -0800 (PST) X-Google-Smtp-Source: AG47ELtIxyRKj/pyqA9zECiyPp+TqMYU31XR71XqY/zZHIq7DLENLlpHwYMWn3S3jxJOzueuaa9E X-Received: by 10.98.253.17 with SMTP id p17mr16994206pfh.105.1520294478178; Mon, 05 Mar 2018 16:01:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520294478; cv=none; d=google.com; s=arc-20160816; b=j5RbDdlzdwTKEjFEAObfmIYS0x/RZLqnzqRDXBhgOWsDfT50Wf/kIh3oFru6lOXYVP 2qiYUdk076Hb288MyjpFWIYK+LZA3okhH9JHUZu44pq4+L1iaCK9jilG/JtNlvoafi2M v5lm+rUyddePsa/wJfYbJqeTxKLWZPinfmd+0kpbW2xCNUYUaI7YnAycoVwHcD/9MQ6G jRUqvivBZRdfoA38jQeDpUCVevyGU291a/js+KpYcQ8ctLa6jRNvbTwKR15BwiGl8e7O l0NKvY5fDPIgtkKTUUmwISykfj5dnTPO7ScArDfFzlP7LxU7xbrlYZIDqKXvYbzc0kVx w8xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :arc-authentication-results; bh=tfaYh9BSJR4mQeXpIajjowa/3zFiretyklkYWdlSSQ8=; b=uDUVyHlDvOFBAkipyoMc6d/HUm2HDbjFwFF3MiONHQx4467kzMC3X7f901GJWtX0n3 ljQghDqXzOjpR7fr09LLyEwvxVTezHtxg0f4gOBYfu88eHHrkuKRNv5aVdDjG/IPT/pL jWuQrDbV8F4aXzu9wYCSO/cEa7qpgQ7LZgrHTmbdf+z8P+myww4lpWiyNj/zT8BZO95u Gk+GSUYFKXpMmF3/21f46teSqT6rP4sZ9kn+71x8UkHK4a/hLx19Hj0nOyyXAi9PCobN ZuRyz1jSXZeCUjRtfZUsB2qcXtf630WpcIPo071IdR2lBMIkde0AM6jzPlZfMTPxTeud aKng== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n6-v6si3755368plp.574.2018.03.05.16.01.03; Mon, 05 Mar 2018 16:01:18 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932751AbeCFAAM (ORCPT + 99 others); Mon, 5 Mar 2018 19:00:12 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:43332 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932243AbeCFAAL (ORCPT ); Mon, 5 Mar 2018 19:00:11 -0500 Received: from akpm3.svl.corp.google.com (unknown [104.133.9.71]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id CF3E31389; Tue, 6 Mar 2018 00:00:10 +0000 (UTC) Date: Mon, 5 Mar 2018 16:00:09 -0800 From: Andrew Morton To: frowand.list@gmail.com Cc: Rob Herring , Michal Hocko , Catalin Marinas , Pavel Tatashin , Vlastimil Babka , cpandya@codeaurora.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 2/3] memblock: add memblock_free() alloc when CONFIG_HAVE_MEMBLOCK is not set Message-Id: <20180305160009.d24507e7b02ccb8be9dbc091@linux-foundation.org> In-Reply-To: <1520208889-3908-3-git-send-email-frowand.list@gmail.com> References: <1520208889-3908-1-git-send-email-frowand.list@gmail.com> <1520208889-3908-3-git-send-email-frowand.list@gmail.com> X-Mailer: Sylpheed 3.6.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 4 Mar 2018 16:14:48 -0800 frowand.list@gmail.com wrote: > From: Frank Rowand > > When CONFIG_HAVE_MEMBLOCK is not set, an error version of > memblock_alloc() exists. Add the matching memblock_free(). > > Signed-off-by: Frank Rowand > --- > > Andrew or Michal, can you please ack this patch to be accepted > by Rob? > > > With "of: add early boot allocation of > of_find_node_by_phandle() cache" applied, kbuild test robot reports > tilex architecture build error due to no prototype for memblock_free(). > > The version of the patch that kbuild test robot reported was > "[PATCH v4 2/2] of: add early boot allocation of > of_find_node_by_phandle() cache". An updated version of that > patch is now patch 3/3 of this series. > > ... > > --- a/include/linux/memblock.h > +++ b/include/linux/memblock.h > @@ -432,6 +432,10 @@ static inline unsigned long memblock_reserved_memory_within(phys_addr_t start_ad > return 0; > } > > +static inline int memblock_free(phys_addr_t base, phys_addr_t size) > +{ > + return 0; > +} > #endif /* CONFIG_HAVE_MEMBLOCK */ > > #endif /* __KERNEL__ */ Acked-by: Andrew Morton