Received: by 10.223.185.116 with SMTP id b49csp3223768wrg; Mon, 5 Mar 2018 16:58:24 -0800 (PST) X-Google-Smtp-Source: AG47ELvOIWKu7wNDMSFYPgQDQXJmioUSYWh4UrEqbJ7rOuH/GVQRTDUF67xAz4OfFa9wAWBI+Nqq X-Received: by 2002:a17:902:2c43:: with SMTP id m61-v6mr14936140plb.387.1520297904323; Mon, 05 Mar 2018 16:58:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520297904; cv=none; d=google.com; s=arc-20160816; b=OAIJlUJGmiIiByrrzSyKbjTanJqs5AaMeTR0a/J+VGndiwY1R9Czf574ZQOnshH1n2 fORHyfcBIBvCnD+qdRWDtZ5OSwBqJ0Iz3+G/eGOzlG5jpzDntwAnQWULiAQpmLExqMrR E4OPJ+EXKlFOPkMvdGdsImfBmmCFFzDE9Ag5APQN0zNxtExsnS/ajFSIV0hQyELY2pyA iGL9vcTcy3u9BJC2uoA6GgjIQTvxv/Q6dsN29Stcx3prYJcuYesZHOSQEutzIBoGoHOL HTw5es6KJPmXeQVC2H9i1JmKC8N24d0yud2rT5RrIcR08C3IIP7ZGkL1TZsSpGagRSpS uB4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=JUmsGhjW07tBrRvAuEPKzlT3DIDScCgUbm8qCqrQmWE=; b=xPlayWajQ2ESfNNisNWH9pPhUetF5jjI5SM1LsN1F9R2kaexzqqxF4RoKw8RjGFC6/ d7OMh5bjFYYSRA30ts5J4cBm04l3KJPVl5aL9HcT3rkdMtq0781kznKLsMBPqCjM0aTp eMt7b+0dHxpYai1Tr6aUPmzqblN1pLr8p67V+4Rb25vGhXoC3yPn3T+4oLQxd7kabSEw shDrLV9OWgmGV24uBoNc08GsC1l0lbW/Qc+kpsWpw5YJEi9H7GeBfxwgWCxJE1T29Gyr SGz9qMiVFLy9Cw1Anufcpg8/5vwrnO90HihmvetB+xu9dB41ORnNI9UiAzadn0vvX4V9 SYFA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v3si9064269pgq.608.2018.03.05.16.58.10; Mon, 05 Mar 2018 16:58:24 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932505AbeCFAzu (ORCPT + 99 others); Mon, 5 Mar 2018 19:55:50 -0500 Received: from mga09.intel.com ([134.134.136.24]:47981 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932430AbeCFAzt (ORCPT ); Mon, 5 Mar 2018 19:55:49 -0500 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Mar 2018 16:55:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,429,1515484800"; d="scan'208";a="205753568" Received: from theros.lm.intel.com (HELO linux.intel.com) ([10.232.112.164]) by orsmga005.jf.intel.com with ESMTP; 05 Mar 2018 16:55:48 -0800 Date: Mon, 5 Mar 2018 17:55:48 -0700 From: Ross Zwisler To: Johannes Thumshirn Cc: Dan Williams , Linux Kernel Mailinglist , Linux NV-DIMM Mailing List Subject: Re: [PATCH] acpi, nfit: remove redundant __func__ in dev_dbg Message-ID: <20180306005548.GB15227@linux.intel.com> References: <20180302122049.13900-1-jthumshirn@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180302122049.13900-1-jthumshirn@suse.de> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 02, 2018 at 01:20:49PM +0100, Johannes Thumshirn wrote: > Dynamic debug can be instructed to add the function name to the debug > output using the +f switch, so there is no need for the nfit module to > do it again. If a user decides to add the +f switch for nfit's dynamic > debug this results in double prints of the function name like the > following: > > [ 2391.935383] acpi_nfit_ctl: nfit ACPI0012:00: acpi_nfit_ctl:nmem8 cmd: 10: func: 1 input length: 0 > > Thus remove the stray __func__ printing. > > Signed-off-by: Johannes Thumshirn I looked through this and this all looked right to me. Reviewed-by: Ross Zwisler