Received: by 10.223.185.116 with SMTP id b49csp3351541wrg; Mon, 5 Mar 2018 19:58:46 -0800 (PST) X-Google-Smtp-Source: AG47ELtpvjeQrA/TZibtlC9a/hvsFojzohDHDJBdlu2KKmwsuE63TUU2GEJzL97Kkq+BCEwvKnZJ X-Received: by 2002:a17:902:6bcc:: with SMTP id m12-v6mr5491674plt.101.1520308726094; Mon, 05 Mar 2018 19:58:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520308726; cv=none; d=google.com; s=arc-20160816; b=afpybhTOW1/qCMA68O5tymv1oZHHgSkM/Rv61WBDhA3coOEeaWhlHmjVw0EeHTV+tO wgw7N6Yejj0nvu8cPp1nw4cm0oDYzTBUfRa9To8lpvHZRsS7rCEpt40CQ9chpY+/yyWc dMXVWt0vzoWbeiu/h8trhg37Q/cXezFUI1epcCM9AlUEA5gRP2sDwHcOqHr5QhwQEH1v wFEKVp5ckxg657ljzvKE1xesvBq3aZODxHbxvikHRKjUzI9KYCXBOBUUweP5cRj+tDPi h7T843Z4NYq07gY8kEewxdSbAdwugFV6uL3mTsB7MWvVyXQ1ByDh1dyvglxxuCFOE0u6 W9sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=Zns0xa84nDzyh7bDFx5oIZGIH/2ievDoJjbPDI3V2xg=; b=FAMJMLPU20GlYa8qHDzRIGMjB6pPzsl15Ph/guT+Ri7/iBPttRWtp2XU+vAxp9SX8R x/+MCyWD/QWC+n/RX+FwAbqOXTFdQqrVuP+tz2j8ECmaLDK6g/27foyqElA4ymgkLhGT VDeBzALz1nvEFhWGzlibBVVeaYQSKFqEY++hPGrNTHvA5rn2jOHPW6TAyk2bg0LOiJV5 IB8jz6h1U5WBgMGDoH5LtlUNUbsXnzxZoJF5INEViL/ZQx6QbJFcC6xCRwHoE4Mo0n/j RMp3B47HBvLy+oRfKiR4XLSJHE8TaiVDM3tB7hrXqCalj9EDBM2DiHF/Fp/7pVFw6l2a A32Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u6-v6si10509278pld.129.2018.03.05.19.58.31; Mon, 05 Mar 2018 19:58:46 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932408AbeCFD5k (ORCPT + 99 others); Mon, 5 Mar 2018 22:57:40 -0500 Received: from mga18.intel.com ([134.134.136.126]:55292 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752719AbeCFD5j (ORCPT ); Mon, 5 Mar 2018 22:57:39 -0500 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Mar 2018 19:57:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,430,1515484800"; d="scan'208";a="180210140" Received: from theros.lm.intel.com (HELO linux.intel.com) ([10.232.112.164]) by orsmga004.jf.intel.com with ESMTP; 05 Mar 2018 19:57:38 -0800 Date: Mon, 5 Mar 2018 20:57:38 -0700 From: Ross Zwisler To: Dan Williams Cc: linux-nvdimm@lists.01.org, Johannes Thumshirn , Ross Zwisler , linux-kernel@vger.kernel.org Subject: Re: [PATCH] device-dax: remove redundant __func__ in dev_dbg Message-ID: <20180306035738.GD15227@linux.intel.com> References: <152029856688.39547.15137553409024621536.stgit@dwillia2-desk3.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <152029856688.39547.15137553409024621536.stgit@dwillia2-desk3.amr.corp.intel.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 05, 2018 at 05:09:32PM -0800, Dan Williams wrote: > Dynamic debug can be instructed to add the function name to the debug > output using the +f switch, so there is no need for the dax modules to > do it again. If a user decides to add the +f switch for the dax modules' > dynamic debug this results in double prints of the function name. > > Reported-by: Johannes Thumshirn > Reported-by: Ross Zwisler > Signed-off-by: Dan Williams Looks good to me. Reviewed-by: Ross Zwisler