Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 6 Mar 2018 17:21:54 +0530
From:   Vinod Koul <vinod.koul@intel.com>
To:     Qi Hou <qi.hou@windriver.com>
Cc:     dan.j.williams@intel.com, fmh6jj@gmail.com,
        fmhess@users.sourceforge.net, jassisinghbrar@gmail.com,
        rmk+kernel@arm.linux.org.uk, dmaengine@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: pl330: fix a race condition in case of
 threaded irqs
Message-ID: <20180306115153.GS15443@localhost>
References: <1520298817-19870-1-git-send-email-qi.hou@windriver.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1520298817-19870-1-git-send-email-qi.hou@windriver.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Mar 06, 2018 at 09:13:37AM +0800, Qi Hou wrote:
> When booting up with "threadirqs" in command line, all irq handlers of the DMA
> controller pl330 will be threaded forcedly. These threads will race for the same
> list, pl330->req_done.
> 
> Before the callback, the spinlock was released. And after it, the spinlock was
> taken. This opened an race window where another threaded irq handler could steal
> the spinlock and be permitted to delete entries of the list, pl330->req_done.
> 
> If the later deleted an entry that was still referred to by the former, there would
> be a kernel panic when the former was scheduled and tried to get the next sibling
> of the deleted entry.

Applied, thanks

-- 
~Vinod