Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 6 Mar 2018 14:20:12 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Jonas Gorski <jonas.gorski@gmail.com>
Cc:     Sasha Levin <Alexander.Levin@microsoft.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH AUTOSEL for 4.9 002/219] spi/bcm63xx: make spi subsystem
 aware of message size limits
Message-ID: <20180306142012.GB13586@sirena.org.uk>
References: <20180303222716.26640-1-alexander.levin@microsoft.com>
 <20180303222716.26640-2-alexander.levin@microsoft.com>
 <20180305102310.GC8588@sirena.org.uk>
 <20180305200744.afw64js6wnmyfqrb@sasha-lappy>
 <20180305203533.GP8588@sirena.org.uk>
 <CAOiHx=mmwzDeHq7Vsz-C+ButW34-b1HJgEhGManfz3Cs3WRm8w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="yNb1oOkm5a9FJOVX"
Content-Disposition: inline
In-Reply-To: <CAOiHx=mmwzDeHq7Vsz-C+ButW34-b1HJgEhGManfz3Cs3WRm8w@mail.gmail.com>
User-Agent: Mutt/1.9.3 (2018-01-21)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--yNb1oOkm5a9FJOVX
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Mar 06, 2018 at 02:42:43PM +0100, Jonas Gorski wrote:
> On 5 March 2018 at 21:35, Mark Brown <broonie@kernel.org> wrote:

> > It's exposing more capability information but it's in the "how did this
> > ever work without the fix" range, and I'd worry that this might cause us
> > to do something like start exercising handling code in client drivers
> > that had never been tested.  Not that I can immediately see any client
> > drivers in mainline that actually pay attention...  :/

> I would assume that most spi client drivers use short messages, so
> they aren't affected unless the max message size is really short.
> m25p80 on the other hand will do arbitrarily large transfers/reads, so
> there it was supported first.

There's a bunch of SPI drivers that do firmware downloads which I'd
expect to be affected, the limit the device has is tiny so it's
relatively easy to bump into it.  It's very rare for devices to be so
limited so unfortunately client drivers don't generally check though.

--yNb1oOkm5a9FJOVX
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlqeo5sACgkQJNaLcl1U
h9AQlAf+PKFnqNyb0gydb+DCmkATY/te2KH/VI8Vgq9KpYSJpDIlHPvRjq0PC6LZ
WFxb2+swqs0nOo6zDvMulFnxGt4oP5DimepjOm8ttZj54Htn8vUE+A/p3u6bD9fm
7u9X/O/RmtWDhwuANqxrjd4WAKSYv291ImqfOqSZ4D17PxuPZz9PMvxKstq/kIyD
QhqBxiBey/6wMTLatm4qdmbqoKVn5RdOdWZN7w12w6YBb41H95VL4q/AHFthartp
uocMEmMJf5omrqueS5QMzIDiS2haHE0Ldnuf1Q2rLaSM/+rkgICe5Ii7BOAvAH76
ORHfnPgSOlEBM63AyBr+rW65Bz24eg==
=i/6N
-----END PGP SIGNATURE-----

--yNb1oOkm5a9FJOVX--