Received: by 10.223.185.116 with SMTP id b49csp4027312wrg; Tue, 6 Mar 2018 08:41:42 -0800 (PST) X-Google-Smtp-Source: AG47ELvnleevh5FXmfFB1ivCXE21078vGkYjKKZwEUCYQyGqzCZDYlNnd0y0O8w3qNFQ9bItMVUl X-Received: by 10.98.13.211 with SMTP id 80mr19620923pfn.69.1520354502066; Tue, 06 Mar 2018 08:41:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520354502; cv=none; d=google.com; s=arc-20160816; b=nUPl2w1tI87zT0GIeK6FJNzrFeI4k2gKC0VzyGI6s7q+UEXu9FEODOU6OefQ4viyUO aS+yOcluPD/BUHp0oTlSHqQEaYNAROsVsItz9vRcQAmU9B2at1x5MCkaOqt1Ryc0/8zN I/gmwTyu1tlRlyvIUAJq+BOpEfsu7Q28KVlHp/+Q/DhyX/mEnmN22jE8jkv3MzD11/J8 7biwQMY6+8k5BHBmt0mLvDU6Fegkqv3cjCOIodPBrnqBDlUEOF+uF9fVfwhOyz96MwIM LU3bzyL3GMGncrhQW9QRsyCLvaUgDnWim5ZeNPYnj5pDx8edwlonMk1AwYiZtkpeFBXQ s2pw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:references:message-id :content-transfer-encoding:cc:date:in-reply-to:from:subject :mime-version:dkim-signature:arc-authentication-results; bh=xej838XUU8OlolOXiLTDzuJ+nuGoKjCFBh2nrNi7J6k=; b=Xc5TInn3AcboAp4B2CiASkHkN+SyGc10UnErLQ9kuk1CaFVYl0DNYsZjzbpA3iU6a9 qWsxnNviOk4r2gWtbdwfR/Pdhh87oZUfLnEg4mZvdTKcBRrRqSzgyVQMPokClIUz6LNx w8U9eoxge7QuQfzkNSNfnkyeskz/D+zi67ao2uod5oDkvopcFOGaORbblC33ssU7FPK4 pxybg1u8I0M6EduuOxOTFHRZVm+M3U+X6V8awoi+ws58k5e44kOmY2vLXkQF6ERd5zPU quPmy6fDgkuasP4a4uzRj94nwVmt83amK80DlbPa0i4mtnbE0jnBiWibmuYa5mckN7Ej rARQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=temperror (no key for signature) header.i=@exactcode.de header.s=x header.b=nFjSbfg8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r59-v6si11412270plb.69.2018.03.06.08.41.25; Tue, 06 Mar 2018 08:41:42 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=temperror (no key for signature) header.i=@exactcode.de header.s=x header.b=nFjSbfg8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753772AbeCFQkX (ORCPT + 99 others); Tue, 6 Mar 2018 11:40:23 -0500 Received: from mx.exactcode.de ([144.76.154.42]:47664 "EHLO mx.exactcode.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752784AbeCFQkW (ORCPT ); Tue, 6 Mar 2018 11:40:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=exactcode.de; s=x; h=References:Message-Id:Content-Transfer-Encoding:Cc:Date:In-Reply-To:From:Subject:Mime-Version:Content-Type; bh=xej838XUU8OlolOXiLTDzuJ+nuGoKjCFBh2nrNi7J6k=; b=nFjSbfg8BKRHPyI/Ejg8wt0mgRqi4nMmEMcanKVl0OfI54+3Eti8+mQrMK2tZP1cp+8glNmMZeyWEo8zQ6yyxgILHWYz8DmyXwBal+dvy29UO9ORYMwX7HJ576+ZVCLpXfqVuzxUM7Q51KVR+X1nYsnxSRZk5S9mcrDRJGKh7A8=; Received: from exactco.de ([90.187.5.221]) by mx.exactcode.de with esmtp (Exim 4.82) (envelope-from ) id 1etFe2-0008H1-OF; Tue, 06 Mar 2018 16:40:54 +0000 Received: from [192.168.2.174] (helo=[192.168.2.174]) by exactco.de with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.54) id 1etEci-0006TF-La; Tue, 06 Mar 2018 15:35:34 +0000 Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: [PATCH] k10temp support for AMD Ryzen w/ Vega gfx From: =?windows-1252?Q?Ren=E9_Rebe?= In-Reply-To: <4938bed8-e612-959a-1b72-29dba0839ceb@roeck-us.net> Date: Tue, 6 Mar 2018 17:40:14 +0100 Cc: linux-hwmon@vger.kernel.org, Clemens Ladisch , linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <1769691A-DD1D-4641-B7BA-62C1BA571EBF@exactcode.de> <20180305230350.GA13099@roeck-us.net> <4938bed8-e612-959a-1b72-29dba0839ceb@roeck-us.net> X-Mailer: Apple Mail (2.1878.6) X-Spam-Score: 0.3 (/) To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 06 Mar 2018, at 11:06, Guenter Roeck wrote: > On 03/05/2018 10:48 PM, Ren=E9 Rebe wrote: >> Hi, >> On 06 Mar 2018, at 00:03, Guenter Roeck > wrote: >>> On Mon, Mar 05, 2018 at 11:38:24PM +0100, Ren=E9 Rebe wrote: >>>> Hi, >>>>=20 >>>> This enables k10temp for the new AMD Ryzen APUs w/ Vega Mobile Gfx. >>>> Tested on Ryzen 5 2500U, the temperature looked plausible. >>>>=20 >>>> Signed-off-by: Ren=E9 Rebe > >>>>=20 >>>> PS: 1st RFC - might get white-space damaged, will resend when = ACKed. >>>> Sorry my Xemacs/Mew broke. >>>>=20 >>>> --- linux-4.15/drivers/hwmon/k10temp.c.vanilla2018-03-05 = 22:22:30.974331180 +0000 >>>> +++ linux-4.15/drivers/hwmon/k10temp.c2018-03-05 22:24:17.186327291 = +0000 >>>> @@ -40,6 +40,10 @@ >>>> #define PCI_DEVICE_ID_AMD_17H_DF_F30x1463 >>>> #endif >>>>=20 >>>> +#ifndef PCI_DEVICE_ID_AMD_17H_RR_NB >>>> +#define PCI_DEVICE_ID_AMD_17H_RR_NB0x15d0 >>>> +#endif >>>> + >>>> /* CPUID function 0x80000001, ebx */ >>>> #define CPUID_PKGTYPE_MASK0xf0000000 >>>> #define CPUID_PKGTYPE_F0x00000000 >>>> @@ -89,6 +93,8 @@ >>>> { 0x17, "AMD Ryzen Threadripper 1950", 10000 }, >>>> { 0x17, "AMD Ryzen Threadripper 1920", 10000 }, >>>> { 0x17, "AMD Ryzen Threadripper 1910", 10000 }, >>>> +{ 0x17, "AMD Ryzen 5 2500U with Radeon Vega Mobile Gfx", 20000 }, >>>> +{ 0x17, "AMD Ryzen 7 2700U with Radeon Vega Mobile Gfx", 20000 }, >>>=20 >>> Do you have a confirmation that the temperature offset is correct ? >> I tried all of the three currently used offsets and this was looked = the most plausible. >> For me having some indication of temperature is better than having = none at all. >> Maybe some contact at AMD can shed some light on it, too? >=20 > Per the information I got (not from AMD), those CPUs are not supposed = to have an offset. >=20 > Does the system have a Super-IO chip ? If so, what temperature does it = report ? > Also, what temperatures do you see with 0 offset ? hm, interesting =96 as other Ryzens were marked with this offsets I did = not imagine the mobile ones would have none, =85 Without offset it would mean the ideapad 720s would idle after fresh = boot in a (really) cold room at a little over 40=B0C. The machine does not feel that warm, but maybe it is under the heatsink = (my boot w/ full-disk encryption takes a bit)? Should I resend the patch without the offsets as baseline for other = users to test? Without the chipset PCI ID it obviously currently does = not match on those new mobile machines, ... Ren=E9 --=20 ExactCODE GmbH, Lietzenburger Str. 42, DE-10789 Berlin http://exactcode.com | http://exactscan.com | http://ocrkit.com | = http://t2-project.org | http://rene.rebe.de