Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Cc:     Sudeep Holla <sudeep.holla@arm.com>,
        linux-arm-kernel@lists.infradead.org, lorenzo.pieralisi@arm.com,
        hanjun.guo@linaro.org, rjw@rjwysocki.net, will.deacon@arm.com,
        catalin.marinas@arm.com, gregkh@linuxfoundation.org,
        mark.rutland@arm.com, linux-kernel@vger.kernel.org,
        linux-riscv@lists.infradead.org, wangxiongfeng2@huawei.com,
        vkilari@codeaurora.org, ahs3@redhat.com, dietmar.eggemann@arm.com,
        morten.rasmussen@arm.com, palmer@sifive.com, lenb@kernel.org,
        john.garry@huawei.com, austinwc@codeaurora.org,
        tnowicki@caviumnetworks.com
Subject: Re: [PATCH v7 04/13] arm64/acpi: Create arch specific cpu to acpi id
 helper
To:     Jeremy Linton <jeremy.linton@arm.com>, linux-acpi@vger.kernel.org
References: <20180228220619.6992-1-jeremy.linton@arm.com>
 <20180228220619.6992-5-jeremy.linton@arm.com>
From:   Sudeep Holla <sudeep.holla@arm.com>
Organization: ARM
Message-ID: <6763fdb6-92ac-c9cd-0cbc-e641e785b2d9@arm.com>
Date:   Tue, 6 Mar 2018 17:13:46 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <20180228220619.6992-5-jeremy.linton@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 28/02/18 22:06, Jeremy Linton wrote:
> Its helpful to be able to lookup the acpi_processor_id associated
> with a logical cpu. Provide an arm64 helper to do this.
> 

This patch on it's own is good, but it's quite generic and made to look
at it again. Sorry for missing this earlier.

Can we use "per_cpu(processors, cpu)->acpi_id" at call sites instead ?
Or you can make that a generic helper using above expression ?

-- 
Regards,
Sudeep