Received: by 10.223.185.116 with SMTP id b49csp4249308wrg; Tue, 6 Mar 2018 12:22:16 -0800 (PST) X-Google-Smtp-Source: AG47ELvJs1nMLuomLvGILwhRLUQQ52gU6PKDKTZmcnC7ft0f1I3aQQs3xAPFP/bQ8kfe+a7LjUWx X-Received: by 10.98.36.25 with SMTP id r25mr20324554pfj.106.1520367736215; Tue, 06 Mar 2018 12:22:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520367736; cv=none; d=google.com; s=arc-20160816; b=Pfgs/d5ehUY46BhkqgT+1KnJHXa426fs6MF22+MkIOnGpFhdebbd1l1FIZk1GIYptY uHOoWaP4+wJmv3vJCVLdXrWH1om92UjXAjcdfZ1UQBi09lMyAyigxg9E5Jyuiy2AIN95 qqOCRBt9AXSXx9vZbXTys86+e5DFdO3hl/1+l7fKiZvfxS10a/QHjdvGvBNg9fb4hxqK qp7cVHIntcekpo4tX/CiwNTIXIPsjTflXjTlcjBf6lUt2AB9dP5QWlt0FhQ2dDhlXfAl mggrIhhsosSxGkAvCrQMWkHNx80Y97ARcVEZ9zM9imzE38IDKaA/XcdPDzoNOvgTo0NY GVJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=cwu+uy8K2E3EnKCX9syT1ChXkX1qhWP9AmFmPL1faYE=; b=HHCSgoZDMcTeW6pB/swa+ovnGnSAkbZost9whsDeGkGmCkJ0XsPY48nAgaD/iuwKIk KG4mcLl0ZviPvZtGkSAn/Ixks9RLU1GJTyHU9pFqqFgp6ecD4dXkzJywExUSBeeGTCdd sW1wX33hB2Ph+lWJmihCv0yQh5CQhkCHW6mVryEdAF0pQjeRe0sWYZahF1FyL/XhYNKN Od1WPny1BI39/d6sXZySt2jmia8mrAvFvjSo1Fv4UJnUPQOCFyq+T6XzZxOc+K3OkVTO L6RUCp+u32WTcDPUev3pPIDfW+zHIJAbIsXtPiqELzmrvQikR7w3YqU3e+/UEAk60xKM SLyg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d15-v6si11989337pln.186.2018.03.06.12.22.01; Tue, 06 Mar 2018 12:22:16 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932656AbeCFUUj (ORCPT + 99 others); Tue, 6 Mar 2018 15:20:39 -0500 Received: from mail.bootlin.com ([62.4.15.54]:48333 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750797AbeCFUUi (ORCPT ); Tue, 6 Mar 2018 15:20:38 -0500 Received: by mail.bootlin.com (Postfix, from userid 110) id 734CB2073C; Tue, 6 Mar 2018 21:20:35 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.bootlin.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0 Received: from localhost (unknown [88.191.26.124]) by mail.bootlin.com (Postfix) with ESMTPSA id 115D5203B4; Tue, 6 Mar 2018 21:20:35 +0100 (CET) Date: Tue, 6 Mar 2018 21:20:36 +0100 From: Alexandre Belloni To: Denis OSTERLAND Cc: "a.zummo@towertech.it" , "linux-kernel@vger.kernel.org" , "mgr@pengutronix.de" , "devicetree@vger.kernel.org" , "linux@roeck-us.net" , "jdelvare@suse.com" , "linux-rtc@vger.kernel.org" , "kernel@pengutronix.de" Subject: Re: [PATCH v3 2/4] rtc: isl1208: switch to rtc_register_device Message-ID: <20180306202036.GH3035@piout.net> References: <1520246373-19023-1-git-send-email-Denis.Osterland@diehl.com> <1520246373-19023-3-git-send-email-Denis.Osterland@diehl.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1520246373-19023-3-git-send-email-Denis.Osterland@diehl.com> User-Agent: Mutt/1.9.3 (2018-01-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/03/2018 at 10:43:53 +0000, Denis OSTERLAND wrote: > From: Denis Osterland > > Fix possible race condition. > It is not allowed to return with an error code after RTC is registered. > > Suggested-by: Alexandre Belloni > Signed-off-by: Denis Osterland > Reviewed-by: Michael Grzeschik > --- > drivers/rtc/rtc-isl1208.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > Applied, thanks. -- Alexandre Belloni, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com