Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Quytelda Kahja <quytelda@tamalin.org>
To:     gregkh@linuxfoundation.org, dan.carpenter@oracle.com
Cc:     devel@driverdev.osuosl.org, christian.gromm@microchip.com,
        chris@engineersdelight.de, linux-kernel@vger.kernel.org,
        Michael.Fabry@microchip.com, Quytelda Kahja <quytelda@tamalin.org>
Subject: [PATCH] staging: most: Remove unnecessary usage of BUG_ON().
Date:   Tue,  6 Mar 2018 17:31:41 -0800
Message-Id: <20180307013141.23080-1-quytelda@tamalin.org>
In-Reply-To: <20180306094728.xbhamhpwdphv6kju@mwanda>
References: <20180306094728.xbhamhpwdphv6kju@mwanda>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

There is no need for the calls to BUG_ON() in this driver, which are
used to check if mbo or mbo->context are NULL; mbo is never NULL, and
if mbo->context is NULL it would have already been dereferenced and
oopsed before reaching the BUG_ON().

Signed-off-by: Quytelda Kahja <quytelda@tamalin.org>
---
 drivers/staging/most/core.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/staging/most/core.c b/drivers/staging/most/core.c
index 0ab2de5ecf18..3afc25a61643 100644
--- a/drivers/staging/most/core.c
+++ b/drivers/staging/most/core.c
@@ -915,7 +915,6 @@ static void arm_mbo(struct mbo *mbo)
 	unsigned long flags;
 	struct most_channel *c;
 
-	BUG_ON((!mbo) || (!mbo->context));
 	c = mbo->context;
 
 	if (c->is_poisoned) {
@@ -1018,8 +1017,6 @@ static void most_write_completion(struct mbo *mbo)
 {
 	struct most_channel *c;
 
-	BUG_ON((!mbo) || (!mbo->context));
-
 	c = mbo->context;
 	if (mbo->status == MBO_E_INVAL)
 		pr_info("WARN: Tx MBO status: invalid\n");
-- 
2.16.2