Received: by 10.223.185.116 with SMTP id b49csp4685674wrg; Tue, 6 Mar 2018 22:14:32 -0800 (PST) X-Google-Smtp-Source: AG47ELsH+y7t1ZQHY/MgFSMynkUIA9ki4VKBhbL3wnzzw7x6A1yC7PthUh3suf2b54yfYEiYvTG6 X-Received: by 2002:a17:902:4103:: with SMTP id e3-v6mr15557555pld.172.1520403272397; Tue, 06 Mar 2018 22:14:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520403272; cv=none; d=google.com; s=arc-20160816; b=Ebjvb8w7EWqtCAiqWyj32ebqEJpfRqjwRX7VY3pqFKwcB+MAWMB+xT2L6NboVxVswI 7ogXA7m8N5bl+kF3lMR+IAR2Nw4n+3ZRqG4ay8WGlv29T5zIfRi3m0T4JqVoOA+LC30V WaaX40qtC5CWvkv1i+OvL/+EsRGgfAXRCXYCWbeqiEugtsFrhl7RL7NnDhAdrC7lIkOd D7sBTYe1aS3wkOaNdR2N0a9tXsIz5XeJGYZvOGbYx23ZzBFN0JAXk0LPZpWrdih5x1fN ByO+zPGrqGC+aBEZN0om3OA8p8eIHoVBaUsE0VlV0zAW8IfsEaUo08q0VJxgXZmfF0Da gEJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:message-id:date:cc:to:from:subject:dmarc-filter :arc-authentication-results; bh=XcE7f2wRf6Yo6turBrzj9qpp0MHgJF7CDE9TB9PqfmY=; b=kM5MITQd8ERObL/leLbDhHvfQ7DGP9dJHLgdHLQcqgewFqG9pMv+Otf5iHoC1haUlJ jzDQS+3J1zkFyI9dDVNowOKH+wfBzuUrvb/bwR15jjeklIyL6l2p9mg+EJOThUa9KpRY PysV55BpdEPte9TajTjDCalH8llmaYWvYyZiPgpmfy9+HV8HZdudQFntQ9VhUpqgRujd nI2e6THOnPFx55CJb6EJDKCsXzvceXrgR4dT5IPxIsHhMowXhPAhb3bjVy+Z0r1VY8Xk 73ifU3+CqmtU1Esr+DT8YnzyIteLzxCg9yGBTVV9HsmMEIUk5XFMjP3EUTw1HbIP38vf 5C1A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bb6-v6si12221709plb.512.2018.03.06.22.14.17; Tue, 06 Mar 2018 22:14:32 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751090AbeCGGN1 (ORCPT + 99 others); Wed, 7 Mar 2018 01:13:27 -0500 Received: from mail.kernel.org ([198.145.29.99]:42336 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750951AbeCGGNY (ORCPT ); Wed, 7 Mar 2018 01:13:24 -0500 Received: from localhost (unknown [50.35.13.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 29238206B2; Wed, 7 Mar 2018 06:13:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 29238206B2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=helgaas@kernel.org Subject: [PATCH v1 0/9] PCI: Simplify PCIe port driver From: Bjorn Helgaas To: linux-pci@vger.kernel.org Cc: linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , linux-pm@vger.kernel.org, Keith Busch , Sinan Kaya , Lukas Wunner Date: Wed, 07 Mar 2018 00:13:23 -0600 Message-ID: <152040297576.240786.1532465558381209070.stgit@bhelgaas-glaptop.roam.corp.google.com> User-Agent: StGit/0.18 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an attempt to move a few things out of the port driver. Patches 1-2 move a workaround for a BIOS PME issue from the port driver to the PCI core, so it doesn't depend on CONFIG_PCIEPORTBUS. Patch 3 extends that workaround so it works for Root Complex Event Collectors. I haven't seen reports of this being a problem, but I think we should handle Event Collector PMEs the same as Root Port PMEs. Patch 4 disables the port driver completely for "pcie_ports=compat". We used to register the driver, claim port devices, enable them, etc., as part of supporting the above BIOS workaround. Patch 5 removes a port driver link order dependency. Patch 6 removes the unused VC service. Patch 7 simplifies the _OSC code path by keeping more of the details in the ACPI pci_root.c driver. Patch 8 removes an unnecessary #include. Patch 9 removes the "pcie_hp=nomsi" parameter. This was added to work around an issue when shutting down devices, but a later patch fixed the root cause, and I don't think we need such a specific parameter any more (we still have "pci=nomsi"). --- Bjorn Helgaas (9): PCI/PM: Move pcie_clear_root_pme_status() to core PCI/PM: Clear PCIe PME Status bit in core, not PCIe port driver PCI/PM: Clear PCIe PME Status bit for Root Complex Event Collectors PCI/portdrv: Disable port driver in compat mode PCI/portdrv: Remove pcie_port_bus_type link order dependency PCI/portdrv: Remove unused PCIE_PORT_SERVICE_VC PCI/portdrv: Simplify PCIe feature permission checking PCI/portdrv: Remove unnecessary include of PCI/portdrv: Remove "pcie_hp=nomsi" kernel parameter Documentation/admin-guide/kernel-parameters.txt | 4 - drivers/acpi/pci_root.c | 13 +++- drivers/pci/pci-driver.c | 60 ++++++++++++++++++ drivers/pci/pci.c | 9 +++ drivers/pci/pci.h | 1 drivers/pci/pcie/Makefile | 3 - drivers/pci/pcie/portdrv.h | 27 -------- drivers/pci/pcie/portdrv_acpi.c | 2 - drivers/pci/pcie/portdrv_bus.c | 56 ----------------- drivers/pci/pcie/portdrv_core.c | 77 ++++++++++------------- drivers/pci/pcie/portdrv_pci.c | 40 +----------- drivers/pci/probe.c | 10 +++ include/linux/pci.h | 3 + include/linux/pcieport_if.h | 4 - 14 files changed, 131 insertions(+), 178 deletions(-) delete mode 100644 drivers/pci/pcie/portdrv_bus.c