Received: by 10.223.185.116 with SMTP id b49csp4687711wrg; Tue, 6 Mar 2018 22:17:20 -0800 (PST) X-Google-Smtp-Source: AG47ELumPzJNZ1xG7j+eTZQYD0QhaE1uqZ1GQr4EfokbwmfVR6KKi8E9wyihNhbUF2W8EZIDSr/1 X-Received: by 2002:a17:902:a607:: with SMTP id u7-v6mr18922425plq.367.1520403440626; Tue, 06 Mar 2018 22:17:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520403440; cv=none; d=google.com; s=arc-20160816; b=y1kKfiCsR6Qsie3dN7Rs+f+/LnTqrkr+EvAlGS6d2X7ObO+kGLSd44ngk3Hv8lKiyw bIwKEryC0tAmLx3ak38u216OL4hEHkiQ/wd07AWPEpv17/8rDxCWDGsbMAFv/kIBM8Ut 8P8cT/940zCodPnzZyFioXWV89fMlfGQPzMdBBuAndNX/DPqO2LWpzXbrr4fAQuHclnj XjAF/Vg8WRmleCQngxChXfS/Bm8S3T43nxg7uIUn01QCEuSxCVRIceFQpxzhJM+Yw+HH 25jNDQtdg+DqFN3xe+kIxHb7IWP1YsLK90I0BFqAKwLoapcvbOBlfbY+k/DLiqPBO6CQ noKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:cc:to:from :subject:dmarc-filter:arc-authentication-results; bh=f75wQY4nbljV36jP1FiMby5ZLiskILPLsVQrBWuhqZM=; b=E1vtdGa7ezh9A8KAVjUI4kCzKLawCJXouorm4MgiK9xf875y3ttgFPIc1/wbilEoqU H4UExb2V/jIl82sManOdkEuE+XKlFa1Ag/x5XhK5PWtClVhwMpy1tFubcMEMl9IELu8M LJ6lOZ3/ptOTmXuSNaT7c/kBdIjvo/t2dRI/ZQteCQPRz28+wRqPZyPSttP+f/jfqIpC /vkTEyvJ8kAagJW67lOhtCAPR4Bn64H+Quyee4UNe6E/KT3pw1JMpY49NXqVHpIzN65I Sb1BrAdi1+0PQQjK9WPkpcPjEdGf7Ynby5hI6eddKYGsxnNhoU2pOLqpfVTmNP9u4BJv thFg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x7si11001577pgo.122.2018.03.06.22.17.06; Tue, 06 Mar 2018 22:17:20 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751141AbeCGGNf (ORCPT + 99 others); Wed, 7 Mar 2018 01:13:35 -0500 Received: from mail.kernel.org ([198.145.29.99]:42386 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750803AbeCGGNa (ORCPT ); Wed, 7 Mar 2018 01:13:30 -0500 Received: from localhost (unknown [50.35.13.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A321421770; Wed, 7 Mar 2018 06:13:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A321421770 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=helgaas@kernel.org Subject: [PATCH v1 1/9] PCI/PM: Move pcie_clear_root_pme_status() to core From: Bjorn Helgaas To: linux-pci@vger.kernel.org Cc: linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , linux-pm@vger.kernel.org, Keith Busch , Sinan Kaya , Lukas Wunner Date: Wed, 07 Mar 2018 00:13:29 -0600 Message-ID: <152040320934.240786.9241781859071768363.stgit@bhelgaas-glaptop.roam.corp.google.com> In-Reply-To: <152040297576.240786.1532465558381209070.stgit@bhelgaas-glaptop.roam.corp.google.com> References: <152040297576.240786.1532465558381209070.stgit@bhelgaas-glaptop.roam.corp.google.com> User-Agent: StGit/0.18 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bjorn Helgaas Move pcie_clear_root_pme_status() from the port driver to the PCI core so it will be available even when the port driver isn't present. No functional change intended. Signed-off-by: Bjorn Helgaas --- drivers/pci/pci.c | 9 +++++++++ drivers/pci/pci.h | 1 + drivers/pci/pcie/portdrv.h | 2 -- drivers/pci/pcie/portdrv_pci.c | 9 --------- 4 files changed, 10 insertions(+), 11 deletions(-) diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index f6a4dd10d9b0..120e3393fc35 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -1683,6 +1683,15 @@ int pci_set_pcie_reset_state(struct pci_dev *dev, enum pcie_reset_state state) } EXPORT_SYMBOL_GPL(pci_set_pcie_reset_state); +/** + * pcie_clear_root_pme_status - Clear root port PME interrupt status. + * @dev: PCIe root port or event collector. + */ +void pcie_clear_root_pme_status(struct pci_dev *dev) +{ + pcie_capability_set_dword(dev, PCI_EXP_RTSTA, PCI_EXP_RTSTA_PME); +} + /** * pci_check_pme_status - Check if given device has generated PME. * @dev: Device to check. diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h index fcd81911b127..813ca2c895d8 100644 --- a/drivers/pci/pci.h +++ b/drivers/pci/pci.h @@ -71,6 +71,7 @@ void pci_update_current_state(struct pci_dev *dev, pci_power_t state); void pci_power_up(struct pci_dev *dev); void pci_disable_enabled_device(struct pci_dev *dev); int pci_finish_runtime_suspend(struct pci_dev *dev); +void pcie_clear_root_pme_status(struct pci_dev *dev); int __pci_pme_wakeup(struct pci_dev *dev, void *ign); void pci_pme_restore(struct pci_dev *dev); bool pci_dev_keep_suspended(struct pci_dev *dev); diff --git a/drivers/pci/pcie/portdrv.h b/drivers/pci/pcie/portdrv.h index a854bc569117..a4fc44d52206 100644 --- a/drivers/pci/pcie/portdrv.h +++ b/drivers/pci/pcie/portdrv.h @@ -34,8 +34,6 @@ void pcie_port_bus_unregister(void); struct pci_dev; -void pcie_clear_root_pme_status(struct pci_dev *dev); - #ifdef CONFIG_HOTPLUG_PCI_PCIE extern bool pciehp_msi_disabled; diff --git a/drivers/pci/pcie/portdrv_pci.c b/drivers/pci/pcie/portdrv_pci.c index fb1c1bb87316..4413dd85e923 100644 --- a/drivers/pci/pcie/portdrv_pci.c +++ b/drivers/pci/pcie/portdrv_pci.c @@ -50,15 +50,6 @@ __setup("pcie_ports=", pcie_port_setup); /* global data */ -/** - * pcie_clear_root_pme_status - Clear root port PME interrupt status. - * @dev: PCIe root port or event collector. - */ -void pcie_clear_root_pme_status(struct pci_dev *dev) -{ - pcie_capability_set_dword(dev, PCI_EXP_RTSTA, PCI_EXP_RTSTA_PME); -} - static int pcie_portdrv_restore_config(struct pci_dev *dev) { int retval;