Received: by 10.223.185.116 with SMTP id b49csp4853966wrg; Wed, 7 Mar 2018 02:05:06 -0800 (PST) X-Google-Smtp-Source: AG47ELvitY6VIETDMekHFl6WoMYgjxVahphIwvI38gP9L9cg+uRzTxSc4Gr3mO5SPk7Ksj93KO0s X-Received: by 2002:a17:902:20c2:: with SMTP id v2-v6mr19822329plg.82.1520417106581; Wed, 07 Mar 2018 02:05:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520417106; cv=none; d=google.com; s=arc-20160816; b=EOnbm7o2mPUZNUPw6oKBDxDvA9BlUgUh6ElWLf2aZntcznRvRJIAC9Dg2IAJnkdoJC 2wWP4VRsjQW8yRTlrygI2krj1APuQu9391vxMTDl5NpDNe80COcivcskXmqqa2tnbEX0 SVQIAu8ytG216ER3jxXiam99Ja9eWrTXWeMlx99jXOXfdWlRMJk2mQoW1DpVpIaAvDwl nCtYhmCos1MkB0V2YN/FQgjMV/48AeJf/KKAqQx4SzfwBDh+/wJ+Jw9UFSfEKCo18sju MAHDMlPZXnbVXAMy/1FqQGsPHwhPtked5xrkOv1xuUQE24LwttuylTZHb6eJ8fboPnDt C+6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=FTgv+Dof566wPee0ZZBr96Xr6JkACLIRdEByHEjkRGc=; b=JgnP7I/iLETQE/C+UERR59B5QhNYDKyLTPEEvPBAyCKrUcAfEnQGK1Ak2xnQikM6XL f0dU0OGlUJV6nVsTKHgHK8hHBwNZ71sL7wEX/y2DkUHs8+TDBcba0n4/WUelgcfL1XbD LaOiumKot/cCss2XMkG5vBtpC1hzPG0L3DQPn/ARFrgIiflreausdrBhVwzjEJXhJx07 kaA+6Wz0jC+CiDxzibNqBBg7MTX9zGaYsyZm+nI0E0vMaKICHNfDhdUwEEljc8jJgQtb PcQo60n2H3PnPdG/lARsMd7XnnF7cLXerYvF86E7GZmiqv5YBGOhmSh2FwlF8L/9gI7a wYOg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=IQmO7l2U; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n3si13517246pfi.302.2018.03.07.02.04.52; Wed, 07 Mar 2018 02:05:06 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=IQmO7l2U; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754129AbeCGKCW (ORCPT + 99 others); Wed, 7 Mar 2018 05:02:22 -0500 Received: from mail-io0-f194.google.com ([209.85.223.194]:45106 "EHLO mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751127AbeCGKCS (ORCPT ); Wed, 7 Mar 2018 05:02:18 -0500 Received: by mail-io0-f194.google.com with SMTP id m22so2376346iob.12; Wed, 07 Mar 2018 02:02:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=FTgv+Dof566wPee0ZZBr96Xr6JkACLIRdEByHEjkRGc=; b=IQmO7l2UIDd03YI3P0CW9YeWFKXfxFg9qJsmpfsRks1GYL4Q9/13fn5Kfd69pm2dFs ZSEfw7GgmHdWlWlbrTEr4BaxCbNR3k6B/I4ZUOqDp7tPF8jP7tlopWHRQY/7UgBYiX/3 cQk922ZbOC8c0Pq85nrnW1VgI9G97ASdy2+048rO5IPbxVBFsZKi0UTHvgpFw3/8v/Ov aUMPruz0+7sUXYqN++nvKFpzIT1SDbKMlotS4xRVqk0JCL4lW8ZrnO4n5RA4ahxHQBIX +PGmWu4Ks1BsYsWlz6WnRX0VWVJK7MFl0y+Mk/bRGK0GT6aFovUCIoxUsH6IaZVanAG+ rD+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=FTgv+Dof566wPee0ZZBr96Xr6JkACLIRdEByHEjkRGc=; b=SnRX5kpv6lMoJ+FPwv5nxb6c48kVlbQSFayd3dyNgaR5inWpXt+PyUeUhPOCIqVWqS M4l5vS5FvP0bThr4G0LaF+9i4S9keicYHcJWw/3SuICb9i1+OuY7bOfQ6F1XpXLIOBYm 8vmsB0almAwZj50nTNK6c6MdCxphQu+T+nCe5NQG0B2+/eDQ0wzeYptDjPMUG5KIK+dj ChEemLmxzQpWVWsXX51pX0ZohcvE51yipDtNrc+FXw81zEC03/fKqtVjWe268fkZ5JyK oZtJCLtU7KY1WD3EujubKu8wxegsUUp5YGV3sebGaa7P4izGAMS0kp6sImVjAWSbKtzR am0Q== X-Gm-Message-State: APf1xPDKtXXTDjTd9+XyXvIP7epaGyj23yEqaUs8dgUFhxrmFQjBGHC8 QXBhJ7+kR6m3o+ZhxegiuodHeQ== X-Received: by 10.107.3.164 with SMTP id e36mr26266520ioi.51.1520416937957; Wed, 07 Mar 2018 02:02:17 -0800 (PST) Received: from symbol-HP-Z420-Workstation.zebra.lan ([149.23.17.254]) by smtp.googlemail.com with ESMTPSA id 12sm3463211itm.0.2018.03.07.02.02.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 07 Mar 2018 02:02:17 -0800 (PST) From: Arvind Yadav To: m@bues.ch Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org Subject: [PATCH] ssb:: use put_device() if device_register fail Date: Wed, 7 Mar 2018 15:31:30 +0530 Message-Id: X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org if device_register() returned an error! Always use put_device() to give up the reference initialized. Signed-off-by: Arvind Yadav --- drivers/ssb/main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c index 65420a9..c4449e0 100644 --- a/drivers/ssb/main.c +++ b/drivers/ssb/main.c @@ -521,6 +521,7 @@ static int ssb_devices_register(struct ssb_bus *bus) ssb_err("Could not register %s\n", dev_name(dev)); /* Set dev to NULL to not unregister * dev on error unwinding. */ + put_device(dev); sdev->dev = NULL; kfree(devwrap); goto error; -- 1.9.1