Received: by 10.223.185.116 with SMTP id b49csp5004700wrg; Wed, 7 Mar 2018 04:58:31 -0800 (PST) X-Google-Smtp-Source: AG47ELuy8ahfUZj56+15Va/LmMKRcNBJBhmuNBPSOWZt0uqGX9bQv8BwmVklAICIZrByN64Z6W5c X-Received: by 10.167.128.80 with SMTP id y16mr22310366pfm.91.1520427511505; Wed, 07 Mar 2018 04:58:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520427511; cv=none; d=google.com; s=arc-20160816; b=ekwfMDCjBSVWZl23ZgGyfIFkbHoq7iwWti6+eD+UzYzehQKVMUrCqTSQxiPrCeHyfJ VhISX1MAqrQRzSRXGtHVag6nGo9HqfmTTBZGvRH9Tnr8qhyoYVZH8p2dOSGD2+/sizzJ Tsw6hjhYY/rPFGghLTZ8Z/Rtik9C3st2r+RgU1hvg1BBRcPqpodEMFFcMF8gi80MpTTK 8dMGcxqlg2z/qNWUxTDruvLmZkF/3lbjpv2l4T0zgeWFNhJJN5jmOv3I8GhZQylZFOxH jjbPQ08McVXOuvRv3rzZ5NXexVud2GRhdqZkDPPphASHY+8PnXOkg+nqmRT2UUhWVdtJ Lvig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=0mGK/2FWX0bmxoLWBBtqwCA912GSXcll1hrtzQFIIP8=; b=KgOKlHoZ+/HfModSbEql6u+gd0zM6Z6ki7BdZk73cg8nvtSCJ405WXeQpZCcQmzvyX WNmSeggZRFrXszWsnHo3KsjOz9tcsTyeGC5OBgLGjjRarOQNiLZqRRLQ7MOuXPPZwz5J WW7zDl5EhmNvdK7Yli8s7HkJWAMNtPRiWZBg2Ugulx0ZBaoyLov6w4em/1AJIDFm2KAm /GCVhskn+3fAWIf65Ogj+sZCsnHNm5igP54ZGIkxmRonkEV4w80mKkK58JEU84ETF3T0 WSnzfPo9+HKiUFRjKPWvmuo95cNzZxXra3cQCuNtFZH/MBGZFnIii58Bf0eKpEgiD+Yz mAbA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z14si11321635pge.393.2018.03.07.04.58.17; Wed, 07 Mar 2018 04:58:31 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754432AbeCGM5O (ORCPT + 99 others); Wed, 7 Mar 2018 07:57:14 -0500 Received: from a.mx.secunet.com ([62.96.220.36]:50718 "EHLO a.mx.secunet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751159AbeCGM5L (ORCPT ); Wed, 7 Mar 2018 07:57:11 -0500 Received: from localhost (localhost [127.0.0.1]) by a.mx.secunet.com (Postfix) with ESMTP id 7EA3E2018E; Wed, 7 Mar 2018 13:57:10 +0100 (CET) X-Virus-Scanned: by secunet Received: from a.mx.secunet.com ([127.0.0.1]) by localhost (a.mx.secunet.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GK0XJgc-_usQ; Wed, 7 Mar 2018 13:57:09 +0100 (CET) Received: from mail-essen-01.secunet.de (mail-essen-01.secunet.de [10.53.40.204]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a.mx.secunet.com (Postfix) with ESMTPS id 1A8BD20082; Wed, 7 Mar 2018 13:57:09 +0100 (CET) Received: from gauss2.secunet.de (10.182.7.193) by mail-essen-01.secunet.de (10.53.40.204) with Microsoft SMTP Server id 14.3.382.0; Wed, 7 Mar 2018 13:57:08 +0100 Received: by gauss2.secunet.de (Postfix, from userid 1000) id BD5233180985; Wed, 7 Mar 2018 13:57:08 +0100 (CET) Date: Wed, 7 Mar 2018 13:57:08 +0100 From: Steffen Klassert To: CC: Herbert Xu , "David S. Miller" , Alexey Kuznetsov , "Hideaki YOSHIFUJI" , , , Artem Savkov Subject: Re: [PATCH net] xfrm: Verify MAC header exists before overwriting eth_hdr(skb)->h_proto Message-ID: <20180307125708.rb55ny6rhxqgstpy@gauss3.secunet.de> References: <1520190232-7208-1-git-send-email-yossiku@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1520190232-7208-1-git-send-email-yossiku@mellanox.com> User-Agent: NeoMutt/20170609 (1.8.3) X-G-Data-MailSecurity-for-Exchange-State: 0 X-G-Data-MailSecurity-for-Exchange-Error: 0 X-G-Data-MailSecurity-for-Exchange-Sender: 23 X-G-Data-MailSecurity-for-Exchange-Server: d65e63f7-5c15-413f-8f63-c0d707471c93 X-EXCLAIMER-MD-CONFIG: 2c86f778-e09b-4440-8b15-867914633a10 X-G-Data-MailSecurity-for-Exchange-Guid: 594905A7-8D47-4050-A687-B7CD44B7BABC Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 04, 2018 at 09:03:52PM +0200, yossiku@mellanox.com wrote: > From: Yossi Kuperman > > Artem Savkov reported that commit 5efec5c655dd leads to a packet loss under > IPSec configuration. It appears that his setup consists of a TUN device, > which does not have a MAC header. > > Make sure MAC header exists. > > Note: TUN device sets a MAC header pointer, although it does not have one. > > Fixes: 5efec5c655dd ("xfrm: Fix eth_hdr(skb)->h_proto to reflect inner IP version") > Reported-by: Artem Savkov > Tested-by: Artem Savkov > Signed-off-by: Yossi Kuperman Applied, thanks Yossi!