Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] Fix for hanging si2168 in PCTV 292e, making the code
 match
To:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        Nigel Kettlewell <nigel.kettlewell@googlemail.com>
Cc:     linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
References: <59C10A00.2070000@googlemail.com>
 <20171214124841.7943b325@vento.lan>
From:   Antti Palosaari <crope@iki.fi>
Message-ID: <e169f37e-8ca9-bd28-74c8-b8e7a12beb54@iki.fi>
Date:   Wed, 7 Mar 2018 15:23:52 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <20171214124841.7943b325@vento.lan>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 12/14/2017 04:48 PM, Mauro Carvalho Chehab wrote:
> Em Tue, 19 Sep 2017 13:13:52 +0100
> Nigel Kettlewell <nigel.kettlewell@googlemail.com> escreveu:
> 
>> [re-sending as plain text]
>>
>> Fix for hanging si2168 in PCTV 292e USB, making the code match the comment.
>>
>> Using firmware v4.0.11 the 292e would work once and then hang on
>> subsequent attempts to view DVB channels, until physically unplugged and
>> plugged back in.
>>
>> With this patch, the warm state is reset for v4.0.11 and it appears to
>> work both on the first attempt and on subsequent attempts.

It is comment which is wrong. With firmware 4.0.11 it works well without 
need of download it every time. But firmware 4.0.19 needs to be 
downloaded every time after device is put to sleep.
Probably your issue is coming from some other reason.


>>
>> (Patch basis Linux 4.11.9 f82a53b87594f460f2dd9983eeb851a5840e8df8)
> 
> Patch is missing a Signed-off-by. See:
> 	https://elinux.org/Developer_Certificate_Of_Origin).
> 
> 
>>
>> ---
>>    drivers/media/dvb-frontends/si2168.c | 2 +-
>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/media/dvb-frontends/si2168.c
>> b/drivers/media/dvb-frontends/si2168.c
>> index 680ba06..523acd1 100644
>> --- a/drivers/media/dvb-frontends/si2168.c
>> +++ b/drivers/media/dvb-frontends/si2168.c
>> @@ -582,7 +582,7 @@ static int si2168_sleep(struct dvb_frontend *fe)
>>           dev->active = false;
>>
>>           /* Firmware B 4.0-11 or later loses warm state during sleep */
>> -       if (dev->version > ('B' << 24 | 4 << 16 | 0 << 8 | 11 << 0))
>> +       if (dev->version >= ('B' << 24 | 4 << 16 | 0 << 8 | 11 << 0))
>>                   dev->warm = false;
>>
>>           memcpy(cmd.args, "\x13", 1);
>> --
>> 2.9.4
>>
> 
> 
> 
> Thanks,
> Mauro
> 

regards
Antti

-- 
http://palosaari.fi/