Received: by 10.223.185.116 with SMTP id b49csp5200855wrg; Wed, 7 Mar 2018 07:54:59 -0800 (PST) X-Google-Smtp-Source: AG47ELuFNFHUbY9Z6uKTugXlKsKy5gI2QeNAwjWWoSYa2EaDa1XJkRqen6M5kyMAKJFMMuY4haQ4 X-Received: by 2002:a17:902:6717:: with SMTP id f23-v6mr12904107plk.188.1520438099890; Wed, 07 Mar 2018 07:54:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520438099; cv=none; d=google.com; s=arc-20160816; b=U0Q4ElpEi6HpYKkzyY2sF7cxQszlis6260u99YBWU89UnzH08gMZwXE+Pqv6CB9eQX xQclt/VmCscopAeWXDTIKjUx+fdyRqM8ztN4aITjiv96HaoP7x3Gun68O5RyAJFWz3pX ta5aYK5iby+pwT7sysqQSJiJfeZqMMD3qG2+Qw2coERbLQ+MkYAGYtveahiKlnACQpyw B+exsozbyvQkYaE7TTJXofy+KUkkJwTweoiEQUUG6onUc++Ih38tFxKhW4nLtGczGfLk JoCuk6Wbkb8YHn5D9YHFFTpwlW90tll/JoFBr5LQl8DUlg6W8zZ36BHgdDgfbCIZsSKt mjNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature :arc-authentication-results; bh=kjDWGBT0rXjcMcrmjUpCFGYWIUrOObcElu8lo5qRNdE=; b=QiRExinXBLmc8xQiO5MrnnzKG1xvuanqvUrdTDJu87CevWfJoT/obf0ep2oi2pvQNl RvGeGRkxoy6HJHtbl9+VxuLz4UBnjgc0TQ9gPlx37QUyFBjnadjBCL3ttF3c42mZ6p1j bjM8lLG72nkWhD9hU7aH3R1Yp3ecmqZNBzkf/z0nUnH1uA0ckeD+mBFkwq2FAAQe28MF mkZwKPmCZhHF1DbNHiNQTnTIpIACC3eOPdMP1qzNVPRtRTGQGSJ+Z1nY5lYiT5m800iE m5Z2bsmPUwbE8Il40hu4XF2OvDeJE1CzwhTOWUhn0Bw5gBKQXLNoPvJUPt6xc+B3YvPe vM1A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=WyMR3y2I; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p6si13999966pfg.96.2018.03.07.07.54.45; Wed, 07 Mar 2018 07:54:59 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=WyMR3y2I; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934280AbeCGPx0 (ORCPT + 99 others); Wed, 7 Mar 2018 10:53:26 -0500 Received: from mail-wr0-f195.google.com ([209.85.128.195]:41172 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934262AbeCGPxU (ORCPT ); Wed, 7 Mar 2018 10:53:20 -0500 Received: by mail-wr0-f195.google.com with SMTP id f14so2658767wre.8 for ; Wed, 07 Mar 2018 07:53:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=kjDWGBT0rXjcMcrmjUpCFGYWIUrOObcElu8lo5qRNdE=; b=WyMR3y2Ivzf4dVbE8OxSuMrzeBYKuAPNlD8Tmml4HHBTUBNXgEnZZBhL6tm7BGaib0 S+dA8lfW83YiIxLLIYy0mZ4nXHgd7rOjDpLrp1eJcddE5jdSb04F6ChBzZObuRWkPtny YD9SbJIk2Q6QJBflDuyslPYHilEiS+bdm/+S8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=kjDWGBT0rXjcMcrmjUpCFGYWIUrOObcElu8lo5qRNdE=; b=RqkT40kPZrJSMZ0n3y8s4lA1s+Q581RvMFWCQHSdROxCuSVjVn9ikN80yM3WaFnJtd QpEdGlnWXGZeKKYywdtoq/kFUpZHRB4yMM7lF8Set620DQf9WeUJXJIOgBu3xdZeVLTp 5JdIlqdv0YcA2tybz3wJAT+cooX300N+FP2a503m0wsI8Y+tw+hc4GDMyVppgX5VDnwJ YEaYOUO1ZO+0AIZ5zrsD9racFjZFwjs1FANMWCtKd9N+lORR9C0d9VwzncfW6o6/cOs0 CaFhEHK8mY8+O0orim6QPGM3jQYW+T0efCxltbD1e+/FaR4wBkw5DeFmuNuyJQ2T+ag9 y9Lg== X-Gm-Message-State: APf1xPCImxyahn4Js/7g5RpU3pLSHNfa2bL0uUKgots8NWqZdcX2YpNa S2+yiQVD9Ys1SYIJDiu2Jqkwtg== X-Received: by 10.223.160.125 with SMTP id l58mr18680186wrl.264.1520437999169; Wed, 07 Mar 2018 07:53:19 -0800 (PST) Received: from dell ([2.27.35.218]) by smtp.gmail.com with ESMTPSA id w17sm18785218wrb.12.2018.03.07.07.53.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 07 Mar 2018 07:53:18 -0800 (PST) Date: Wed, 7 Mar 2018 15:53:17 +0000 From: Lee Jones To: Enric Balletbo i Serra Cc: groeck@chromium.org, andy.shevchenko@gmail.com, kernel@collabora.com, gwendal@chromium.org, linux-kernel@vger.kernel.org, Douglas Anderson , Benson Leung , Olof Johansson Subject: Re: [PATCH v3 3/8] mfd: cros_ec: Don't try to grab log when suspended Message-ID: <20180307155317.nnqfbnrf2w6wlgk4@dell> References: <20180226102606.15093-1-enric.balletbo@collabora.com> <20180226102606.15093-4-enric.balletbo@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180226102606.15093-4-enric.balletbo@collabora.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 26 Feb 2018, Enric Balletbo i Serra wrote: > From: Douglas Anderson > > We should stop our worker thread while we're suspended. If we don't > then we'll get messages like: > > cros-ec-spi spi5.0: spi transfer failed: -108 > cros-ec-spi spi5.0: cs-deassert spi transfer failed: -108 > cros-ec-ctl cros-ec-ctl.0.auto: EC communication failed > > Signed-off-by: Douglas Anderson > Signed-off-by: Enric Balletbo i Serra > Reviewed-by: Andy Shevchenko > --- > > Changes in v3: > - [3/8] Add Reviewed-by Andy Shevchenko. > > Changes in v2: > - [3/8] That patch is new in this series. > > drivers/mfd/cros_ec_dev.c | 4 ++++ > drivers/platform/chrome/cros_ec_debugfs.c | 20 ++++++++++++++++++++ > include/linux/mfd/cros_ec.h | 2 ++ > 3 files changed, 26 insertions(+) I plan to make this patch 1/X and send it out as a pull-request. Acked-by: Lee Jones -- Lee Jones Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog