Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 7 Mar 2018 15:53:53 +0000
From:   Lee Jones <lee.jones@linaro.org>
To:     Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc:     groeck@chromium.org, andy.shevchenko@gmail.com,
        kernel@collabora.com, gwendal@chromium.org,
        linux-kernel@vger.kernel.org,
        Douglas Anderson <dianders@chromium.org>,
        Benson Leung <bleung@chromium.org>,
        Olof Johansson <olof@lixom.net>
Subject: Re: [PATCH v3 3/8] mfd: cros_ec: Don't try to grab log when suspended
Message-ID: <20180307155353.rtpvuxnbu2oxioz2@dell>
References: <20180226102606.15093-1-enric.balletbo@collabora.com>
 <20180226102606.15093-4-enric.balletbo@collabora.com>
 <20180307155317.nnqfbnrf2w6wlgk4@dell>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20180307155317.nnqfbnrf2w6wlgk4@dell>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 07 Mar 2018, Lee Jones wrote:

> On Mon, 26 Feb 2018, Enric Balletbo i Serra wrote:
> 
> > From: Douglas Anderson <dianders@chromium.org>
> > 
> > We should stop our worker thread while we're suspended.  If we don't
> > then we'll get messages like:
> > 
> >   cros-ec-spi spi5.0: spi transfer failed: -108
> >   cros-ec-spi spi5.0: cs-deassert spi transfer failed: -108
> >   cros-ec-ctl cros-ec-ctl.0.auto: EC communication failed
> > 
> > Signed-off-by: Douglas Anderson <dianders@chromium.org>
> > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> > ---
> > 
> > Changes in v3:
> > - [3/8] Add Reviewed-by Andy Shevchenko.
> > 
> > Changes in v2:
> > - [3/8] That patch is new in this series.
> > 
> >  drivers/mfd/cros_ec_dev.c                 |  4 ++++
> >  drivers/platform/chrome/cros_ec_debugfs.c | 20 ++++++++++++++++++++
> >  include/linux/mfd/cros_ec.h               |  2 ++
> >  3 files changed, 26 insertions(+)
> 
> I plan to make this patch 1/X and send it out as a pull-request.
> 
> Acked-by: Lee Jones <lee.jones@linaro.org>

In fact better still, could you do that and add a note below the ---
to that affect please?

-- 
Lee Jones
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog