Received: by 10.223.185.116 with SMTP id b49csp5274221wrg; Wed, 7 Mar 2018 09:03:26 -0800 (PST) X-Google-Smtp-Source: AG47ELvbf/l3pxZPXIdC5EmSbcywobS6tTfUvkyAQY5MOaJVjd0koORHvar5DE/D8do+kC4hlIih X-Received: by 10.99.170.5 with SMTP id e5mr17966383pgf.92.1520442206225; Wed, 07 Mar 2018 09:03:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520442206; cv=none; d=google.com; s=arc-20160816; b=Hll2J3p5SsCMz0BXSl57fS4P1y/q0hEg7Cf50Gi8kolNzmX9yusWq5I5sZt6HocgaR WxkiniCknq+Lfj3+zdRUnDeZxFqIZPztNuAZqndGtiDiYqsF0wXXEGAhif5KhJwLBP9d A2aeXTw48BRT8+Ui7gVoTFLvVsevjIFIJ9H7tZAM+B53k1C4Dy7mzuAqMSZiYgNA9GaK BmC/TWPjcOI0Oo4wVvu5Ailo5AnBlwcrZFalEhY0wH5SrYmLUaHVqWltJb90UVaO4ww0 kVqQD/pbIZkuUwPqXvDNBRwMpoIW+7cZ2lNR+qnJWXj4hVVrEZpNEpwpBvbKqCh6vOlE ha8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=kbNb5cmDCbJ3yd4wNa/ggfeSrJ5x2fEWCbLiCuHTTtk=; b=X0xotTU91O+l8VjPmELZDdYXhIOw9+cy7NGoWgaUAOJGftH+myVqwVutupiTtyKAQ3 xqwBy8VVPly55g8ghNwDL5W7tJl5z3pP37kt4zAi9/CKcbc6IrIDM5U4mbGEP2oHf9VW Ge91eQhQrjp+7IJaOQoz5nRCTWkIBPHw3KPLFUnJbITFkioox5cxhcpr9pDVovO0eWzv lQohp1gc5Ji7Ou95V3DuXhWv7q0J74BaTHwBk3PTfvr3Alv5oF4e7Rjwmcv3WOcLjdlm wGRxIwvBNbrcceIParvq3fj5TKbljCi65DcuO3/bcTDKwn2DJXGz6EdZipckiUjl44/K lu/g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r15si13887908pfh.230.2018.03.07.09.03.07; Wed, 07 Mar 2018 09:03:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933999AbeCGRBx (ORCPT + 99 others); Wed, 7 Mar 2018 12:01:53 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:54140 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933468AbeCGRBt (ORCPT ); Wed, 7 Mar 2018 12:01:49 -0500 Received: from localhost (67.110.78.66.ptr.us.xo.net [67.110.78.66]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id DB04F12170950; Wed, 7 Mar 2018 09:01:48 -0800 (PST) Date: Wed, 07 Mar 2018 12:01:47 -0500 (EST) Message-Id: <20180307.120147.195464731584241423.davem@davemloft.net> To: arushisinghal19971997@gmail.com Cc: jdmason@kudzu.us, jakub.kicinski@netronome.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, oss-drivers@netronome.com, outreachy-kernel@googlegroups.com Subject: Re: [PATCH v2] net: ethernet: Drop unnecessary continue From: David Miller In-Reply-To: References: <20180303161456.GA20194@seema-Inspiron-15-3567> <20180307.103901.1771176275743006915.davem@davemloft.net> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 07 Mar 2018 09:01:49 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arushi Singhal Date: Wed, 7 Mar 2018 22:22:13 +0530 > Yes I know it's for the inner loop. > But I am not able to find, where I am wrong here You are making what is essentially a nop change to a piece of code, which if you had instead read carefully would have instead inspired you to fix a real genuine bug instead.