Received: by 10.223.185.116 with SMTP id b49csp5276305wrg; Wed, 7 Mar 2018 09:05:07 -0800 (PST) X-Google-Smtp-Source: AG47ELtsJq1jkOrsFbep7+SR07MM0WAI1yp0uPYAwxMcn/Ax86q0/BwR9W4aKHFEeVhej6QD9d31 X-Received: by 2002:a17:902:b582:: with SMTP id a2-v6mr20651442pls.353.1520442307465; Wed, 07 Mar 2018 09:05:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520442307; cv=none; d=google.com; s=arc-20160816; b=v0yYG9ftfdCsKvRqlnTDXnKSwxc1X2ybO5dJaZYTDoKxThNpoGm24jpNhtkdJ+BMT2 YwV+swEmz9eODXf67os0MQBOSbXr4q66Iy1O7cFQzcgpU+3nHksHtk1MDjZBGTWU+oZN 32uZgunLLyvp4vzlnuXzSyCw54qXToTb5KROARnfYwdpSK95piXYYcHnHmmGMK6VI3Em qFfh6QHb6cT0WZavClgofRnVS5CPQ7uKXNH33APaDN/6676bjTu8FKiaUWzeJSXZ3ey1 HmMi+Egyjitl0PN1KX2GbpGwc7E56YfkLuo2ESu81HuIhg1yN2GY8UGFUUKE9WJKlhKA OKyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=bkGq3fTeiQXObbHTpOgx5zLgCmdMWJWSZc2XeQDu2Pc=; b=ya1Xa/Cad/pjWe0EdtTLLwo09Pvlo7b14d9Kmb+UGf0ssdzylsjnIUF9mjHjaqaNZc v7GogyOfoOHQpJmutBB5rYEY7oz1ARQJaTCi/JCZLUpl01MGqmSA2992ReHWm2Lvlsrg ++eA+4btBuj7dmRc1L14TcBk6of4CbQ5qaK+NyUjdv0OCvUn6mFiN4EMkTVRCEEbwnqC Aw5c7uw9SmsC2pQexpQnlmGhMJGk9QyaUfH94MV+HeHBWzIwgYFgYSjlgw0UPT8iXpuN v/sXuM2nFgoTJJK70pYtjKgClVeih/YIM/kYHDMV7SH26WMR5/T3R724FtOi0Eu0EsEa vM8w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 15-v6si11716748pla.342.2018.03.07.09.04.45; Wed, 07 Mar 2018 09:05:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934068AbeCGRCC (ORCPT + 99 others); Wed, 7 Mar 2018 12:02:02 -0500 Received: from mail.x-arc.de ([217.6.246.34]:39980 "EHLO root.phytec.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933468AbeCGRB6 (ORCPT ); Wed, 7 Mar 2018 12:01:58 -0500 Received: from idefix.phytec.de (idefix.phytec.de [172.16.0.10]) by root.phytec.de (Postfix) with ESMTP id C3E47A00420; Wed, 7 Mar 2018 18:01:59 +0100 (CET) Received: from augenblix.phytec.de ([172.16.0.56]) by idefix.phytec.de (IBM Domino Release 9.0.1FP7) with ESMTP id 2018030718015555-77159 ; Wed, 7 Mar 2018 18:01:55 +0100 From: Daniel Schultz To: lee.jones@linaro.org Cc: zyw@rock-chips.com, zhangqing@rock-chips.com, chenjh@rock-chips.com, linux-kernel@vger.kernel.org, w.egorov@phytec.de Subject: [PATCH v2 1/2] mfd: rk808: Change DEV_OFF to DEV_OFF_RST for rk818 shutdown Date: Wed, 7 Mar 2018 18:01:49 +0100 Message-Id: <1520442110-28420-1-git-send-email-d.schultz@phytec.de> X-Mailer: git-send-email 2.7.4 X-MIMETrack: Itemize by SMTP Server on Idefix/Phytec(Release 9.0.1FP7|August 17, 2016) at 07.03.2018 18:01:55, Serialize by Router on Idefix/Phytec(Release 9.0.1FP7|August 17, 2016) at 07.03.2018 18:01:55, Serialize complete at 07.03.2018 18:01:55 X-TNEFEvaluated: 1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org After running "poweroff", the PMIC restarts the SoC instead of shutting it down. It seems like the description for those two register bits is swapped. After changing from DEV_OFF to DEV_OFF_RST, the system can poweroff correctly. Signed-off-by: Daniel Schultz --- Changes: v2: Re-submit with recipients from Rockchip. drivers/mfd/rk808.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/rk808.c b/drivers/mfd/rk808.c index 216fbf6..d138721 100644 --- a/drivers/mfd/rk808.c +++ b/drivers/mfd/rk808.c @@ -418,7 +418,7 @@ static void rk818_device_shutdown(void) ret = regmap_update_bits(rk808->regmap, RK818_DEVCTRL_REG, - DEV_OFF, DEV_OFF); + DEV_OFF_RST, DEV_OFF_RST); if (ret) dev_err(&rk808_i2c_client->dev, "power off error!\n"); } -- 2.7.4