Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] cxgb3: remove VLA
To:     David Miller <davem@davemloft.net>, gustavo@embeddedor.com
Cc:     santosh@chelsio.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20180306053934.GA17162@embeddedgus>
 <20180307.122541.1396477885969641264.davem@davemloft.net>
From:   "Gustavo A. R. Silva" <garsilva@embeddedor.com>
Message-ID: <2dbb7aba-4e12-c4df-363e-b65fcbb16d0e@embeddedor.com>
Date:   Wed, 7 Mar 2018 11:30:39 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <20180307.122541.1396477885969641264.davem@davemloft.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 03/07/2018 11:25 AM, David Miller wrote:
> From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
> Date: Mon, 5 Mar 2018 23:39:34 -0600
> 
>> In preparation to enabling -Wvla, remove VLA and replace it
>> with dynamic memory allocation.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> 
> All of these lengths are limited by the encoding of the field in the
> VPD, which is a u8, and thus 255 bytes.
> 
> Please just change the 'len' argument to these functions to a u8 and
> use a 256 byte buffer on the stack.
> 
> Thanks.
> 


OK. I got it.

Thanks for the feedback.
--
Gustavo