Received: by 10.223.185.116 with SMTP id b49csp5310755wrg; Wed, 7 Mar 2018 09:36:42 -0800 (PST) X-Google-Smtp-Source: AG47ELuwfZfvSb1iXpEEgg2gnNCmirUS1xwOX6XlIqwWx9zuJWoP34/VoV/gsNa2gjauKjIhBLaF X-Received: by 10.99.101.69 with SMTP id z66mr18959377pgb.347.1520444202309; Wed, 07 Mar 2018 09:36:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520444202; cv=none; d=google.com; s=arc-20160816; b=CDTu9nIS8Z5SRk7XkElOQ5pbqjxTk/8NXf8PLrF97HhTbfvnh7wmTxlZ2jPKkiEHQT aJ6f5wpSnWb4/SfESg7loRPxoGGE360q87mMLuCurqzN9ZUq+jDZLEAT/Z175aiAdKNR oRiILBUA9CjBz4uXcH+aEgYQunVsfe329dFJ2dW6i9kOZr4q0ua3m2X07rBKEsZBiwQD 03WQiicXtVN4dS7hvgpctX6FIkdaMhUbEiwKowtObTdfBpdckCCoK0QTGSrbxxoCv+Wg liKzpP5ZzBLqtLlb3LvjKLcNUcmECogMI0s77BgEIrI/x7pgj83yheoRhkWPxLW9qCPv Jm7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=tKpzicdglTSL4ydJ3lBgsfRmYfA29jM1GsiVDerWo14=; b=Fn6tvBNdh3yrYfo6oJUwTrOSXw9ZMxVtjhbuKf2C5wdXjlhFsVTx7SSswp8IlI6+I3 3nS0xCuvX0+owwfjMb9VvosAFGRT0m/Jp97/itG2tRYIZnMgXiYus0RVNUAc1OhCNIzB PlrTFDPVjXGTKyabqgb38Ss5K1Y59tOCBKlcfdijNZ/WppdoTwOz2EU852RW36l3Sk1s p9zsb+3OAkkxhHiDtUeWVnB2P2f/BlHmoI17nE6facJBsjuydZ7bCPrMrbak8Nij1EAe SdVDyEIo2Dan11j3A6m6sWfPrBp3rNwMX8v2a+RQsob1DsA1erABu3UuxSbHbEjNgJ5t rXKQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=GsIvAG7W; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c16-v6si2646922plo.771.2018.03.07.09.36.27; Wed, 07 Mar 2018 09:36:42 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=GsIvAG7W; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933575AbeCGRfX (ORCPT + 99 others); Wed, 7 Mar 2018 12:35:23 -0500 Received: from merlin.infradead.org ([205.233.59.134]:47134 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932759AbeCGRfV (ORCPT ); Wed, 7 Mar 2018 12:35:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=tKpzicdglTSL4ydJ3lBgsfRmYfA29jM1GsiVDerWo14=; b=GsIvAG7WAJO0IaQdd6beJZL9e /4irzAV+D1E46ltnLihJtJLLx0qwjtTZg3+29J9F+JKlxvD+iLvlX+Wq13+wun5C5Ck0tHZ1C2Thr QXwB3f0mPS9l4obgkwBP1Rz72TplBTDTeGMZUeM9VHX/plc2nK6lRTi+8jD8YZp/oqvDjz4hnPx/y FZ/qcsMEliKZwzURTQz7wdPS9xkeH3rfRX5SOn/TTD5XQ8/y474ShDczoUbxGCTv6RwTqX9gtBP3V EPNC5CZCavA5dGEk6YpRg8GbvrAkrUDGRgEMaTgSymPV2ilCT/+cvui3/7EaCg88kWLkQ+btpU030 7q1YslRhw==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.89 #1 (Red Hat Linux)) id 1etcy3-0008Ra-C8; Wed, 07 Mar 2018 17:35:07 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id A15902029FA14; Wed, 7 Mar 2018 18:35:04 +0100 (CET) Date: Wed, 7 Mar 2018 18:35:04 +0100 From: Peter Zijlstra To: Patrick Bellasi Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Ingo Molnar , "Rafael J . Wysocki" , Viresh Kumar , Vincent Guittot , Paul Turner , Dietmar Eggemann , Morten Rasmussen , Juri Lelli , Todd Kjos , Joel Fernandes , Steve Muckle Subject: Re: [PATCH v5 1/4] sched/fair: add util_est on top of PELT Message-ID: <20180307173504.GP25181@hirez.programming.kicks-ass.net> References: <20180222170153.673-1-patrick.bellasi@arm.com> <20180222170153.673-2-patrick.bellasi@arm.com> <20180306185851.GG25201@hirez.programming.kicks-ass.net> <20180307113149.GA2211@e110439-lin> <20180307122437.GM25181@hirez.programming.kicks-ass.net> <20180307152458.GE2211@e110439-lin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180307152458.GE2211@e110439-lin> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 07, 2018 at 03:24:58PM +0000, Patrick Bellasi wrote: > Maybe that's the tricky bit: we remove the value we enqueued, _not_ > the current util_avg. Notice we use _task_util_est(p)... with the > leading "_". ARGH, ok let me try that again ;-)