Received: by 10.223.185.116 with SMTP id b49csp5330822wrg; Wed, 7 Mar 2018 09:57:55 -0800 (PST) X-Google-Smtp-Source: AG47ELsaTI8OllEQ14KGU2wvsyLJFMi7hvP9lt/6ikShKgQz2bQ7z7Q4orVg2NpueycejAV/GxWO X-Received: by 2002:a17:902:e65:: with SMTP id 92-v6mr21169197plw.268.1520445475731; Wed, 07 Mar 2018 09:57:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520445475; cv=none; d=google.com; s=arc-20160816; b=NHl6JoekjJyy0XRxha83E7pfhOWYAo+UwlFbtmxCpYF9lTTohrxNPF8kKIPKpqApeC CP8lx2B/HukKb7JW2cSJxua7/XQVjEJsoJejSKDBfo1skhTW4SxisrPVRr7v3aoDrJnm FmJaJcvNLW/SGuicaAesJ3/UZT9/Gmw4/OojrUTXGO6LGlpn3kANF0PiHVPkaDyYBAS/ 0E43n7SFpPWgYGUmqtExhbelxOoMwcchaiLrgHU33foGMIz3ngJW35QTq5m0gogrNhnG aXX1X79R4SmC5C4/J4I7aH2V6MjPe+oStIAne9sHCyji4OUjQoMCbRP7goNRELS2ZSgN N+oA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:arc-authentication-results; bh=i4h+tnMqPqw1uz9EFmmRD5RU5+bkvASa12hxgOa9Ei4=; b=Jpb+aIe5Nze9H2KH+UGbRwCyWKBXzCLgnm3hdLv2DBNax3EwbGMetGP4+IazmuStQr G0rj5lIPdjif+0Se6XyGDBDAfV4p5dTmUnWmVVkOSIW0mfhVH6tlf4nFq3Gly/6Jehp7 AJ2wDp9JKo1rhGlzZGzy12AcQAJQAm3y3wHYjIjdExgw26/EdcLmbVrd9/TpHmQ1rtlL OsdKbzw2pQ/8vYNCYiZNtQv7YvCz09ERgDYVsAKWrwrtbBGT3S0C0PYmRVLb9V2Zn19M 3h6rZXvn5xUJEQJiHxWd4krg0qBy+v3RJzAbarc26utzcbt7iN78flseOKUKeUiAty4A X3Hg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r4si11688505pgs.323.2018.03.07.09.57.41; Wed, 07 Mar 2018 09:57:55 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754507AbeCGR4r (ORCPT + 99 others); Wed, 7 Mar 2018 12:56:47 -0500 Received: from vps-vb.mhejs.net ([37.28.154.113]:46764 "EHLO vps-vb.mhejs.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753168AbeCGR4p (ORCPT ); Wed, 7 Mar 2018 12:56:45 -0500 Received: by vps-vb.mhejs.net with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.90_1) (envelope-from ) id 1etdIt-0007a6-2t; Wed, 07 Mar 2018 18:56:39 +0100 Subject: Re: [PATCH] X.509: unpack RSA signatureValue field from BIT STRING To: David Howells Cc: Herbert Xu , "David S. Miller" , Tom Lendacky , Gary Hook , keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org References: <88da0c24-385c-64a9-6d56-36696d433bc7@maciej.szmigiero.name> <30085.1520437454@warthog.procyon.org.uk> From: "Maciej S. Szmigiero" Message-ID: <593f6dbe-4ab4-0149-43d9-388cf0fee9f3@maciej.szmigiero.name> Date: Wed, 7 Mar 2018 18:56:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <30085.1520437454@warthog.procyon.org.uk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07.03.2018 16:44, David Howells wrote: > Maciej S. Szmigiero wrote: > >> + if (!strcmp(ctx->cert->sig->pkey_algo, "rsa")) { > > I'm going to change this to '== 0' rather than '!'. No problem. > David > Thanks, Maciej