Received: by 10.223.185.116 with SMTP id b49csp5367726wrg; Wed, 7 Mar 2018 10:31:44 -0800 (PST) X-Google-Smtp-Source: AG47ELsPyM+E15NccJDda2z6qdI+bJJ3QTVoPH7CDIYqwTb6+Q4E296h1X8kOO5RFRWno9m7PHOA X-Received: by 10.101.66.76 with SMTP id d12mr18718866pgq.234.1520447504444; Wed, 07 Mar 2018 10:31:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520447504; cv=none; d=google.com; s=arc-20160816; b=TdWamqVCor2/oO91RWq0T5qm0wgkdPOPYaxLtqZ8cViuShFHWodrLOmL+Yc1f3pWEt N3um6AlyfkL0Y9JnH4LAY3JDYuQqCaCQbiDD7tl7kWWrl/lC06KaNcTL1zVcKsAXgMQ4 5NO1P6qGU6OPN36/tNLyYEVpJjaHZp26f2mj/XRnQKovGzzj2uzCqYPnxQH8Er1uhxD8 mEsS7tFNU0mipEHq0TZqgHaSkfMmcFWNJi0fm1RYHaMAAiZAT+Ld4Moqys0Yb3bai9Hr oEKm8qtVBQIAMS2lPr1Lk+RTkf0gjSyzMXe82N4p3Cy+qUwHri9tXFybXXsfdmaOScMi M7hA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:date:cc:to:from:subject:message-id :dkim-signature:arc-authentication-results; bh=lOe2g1DLbutws4+/rzdxKBtrOGT/6VtfkdbCng5FxIw=; b=WKZB97xxE1uxw4tFXvVESs2xSVDxT1i4aSJFQn64hzPbp52Y4Fk2hhPd+aWqVYUb4/ ppPOJTn7o9dGLsKb2rAZHnlKbJAwQGKHFg3u+k67DJp8BCYtlMsn+k5txdvPq6C4IQVC jGkYj6aE/P0/w3AdObAPY+RQsKkXK1NVT7g48w8eiC3ycO+pXtD0/P4owoaL7klAqzUN ImLxY9yoSMuFRNQ9X/aemWOtoPQRMAG5OUPsvrJiMrqDgQ+IaUjP85JKNkFf0+Y8jrzq 6gbnl0bWE/pcQ1u/8cJGDDDY8LrFMtESA0Wu+41vmktD3okpJ44WPMYaBoZc7L1BfTlF aecQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@hansenpartnership.com header.s=20151216 header.b=RNNFx0zz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=hansenpartnership.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k15si14113712pfi.174.2018.03.07.10.31.29; Wed, 07 Mar 2018 10:31:44 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@hansenpartnership.com header.s=20151216 header.b=RNNFx0zz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=hansenpartnership.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754562AbeCGSaT (ORCPT + 99 others); Wed, 7 Mar 2018 13:30:19 -0500 Received: from bedivere.hansenpartnership.com ([66.63.167.143]:50948 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754312AbeCGSaR (ORCPT ); Wed, 7 Mar 2018 13:30:17 -0500 Received: from localhost (localhost [127.0.0.1]) by bedivere.hansenpartnership.com (Postfix) with ESMTP id D2E348EE180; Wed, 7 Mar 2018 10:30:16 -0800 (PST) Received: from bedivere.hansenpartnership.com ([127.0.0.1]) by localhost (bedivere.hansenpartnership.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GEjnofvNE_oD; Wed, 7 Mar 2018 10:30:16 -0800 (PST) Received: from [153.66.254.194] (unknown [50.35.65.221]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by bedivere.hansenpartnership.com (Postfix) with ESMTPSA id 273828EE0D3; Wed, 7 Mar 2018 10:30:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=hansenpartnership.com; s=20151216; t=1520447416; bh=lOe2g1DLbutws4+/rzdxKBtrOGT/6VtfkdbCng5FxIw=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=RNNFx0zznU+JAak5YUYCzVakEMeIgsQJJNw4mHJINpVFJmwJXdxbwxWEy3/78TJnq AUVXX7e9EfnUlaTpelza0gfwXPiQ9FIL8J+AvqnrOBCOLBSOkxK4bBu3yFq/tqHIr1 sNOiFFUdevrDHR+5ZOGKfQmU3pbvI1zt14JRZ3Wk= Message-ID: <1520447415.5558.12.camel@HansenPartnership.com> Subject: Re: [PATCH 6/6] lib/scatterlist: Drop order argument from sgl_free_n_order From: James Bottomley To: Tvrtko Ursulin , linux-kernel@vger.kernel.org Cc: Tvrtko Ursulin , Bart Van Assche , Hannes Reinecke , Johannes Thumshirn , Jens Axboe , "Nicholas A. Bellinger" , linux-scsi@vger.kernel.org, target-devel@vger.kernel.org Date: Wed, 07 Mar 2018 10:30:15 -0800 In-Reply-To: <20180307124712.14963-7-tvrtko.ursulin@linux.intel.com> References: <20180307124712.14963-1-tvrtko.ursulin@linux.intel.com> <20180307124712.14963-7-tvrtko.ursulin@linux.intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2018-03-07 at 12:47 +0000, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin Firstly, I don't see any justifiable benefit to churning this API, so why bother? but secondly this: > We can derive the order from sg->length and so do not need to pass it > in explicitly. Is wrong.  I can have a length 2 scatterlist that crosses a page boundary, but I can also have one within a single page, so the order cannot be deduced from the length. James