Received: by 10.223.185.116 with SMTP id b49csp5493317wrg; Wed, 7 Mar 2018 12:44:47 -0800 (PST) X-Google-Smtp-Source: AG47ELtzLUNvbGe2hh4u2ebgdVNLHrFGcRWOMCYZts0BCJqclIw0zZM9dcn8Sq1/VCZIA10cbMlF X-Received: by 2002:a17:902:22f:: with SMTP id 44-v6mr21393148plc.418.1520455487102; Wed, 07 Mar 2018 12:44:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520455487; cv=none; d=google.com; s=arc-20160816; b=YS8x8Hmt3EhzfniTQ31o9zLl+/zp+Qiu/vMMRHExPpqLd4Lz6UtdSr+5dfCipY6paS kGrzKbpBWwc4Q4INDZy7o69V/x7TV1H2vK1Ri0yD4RkS3gC/L3/jmj2OQ9wXRnDP1rmG b/EXk0h+yjYdTVTj5RmqpdhmADFr3Qwvj1f9eIfJb/ZbSq4RBRbFCN5kuUDAbL2p0Owk 5YrdLm6Sm96jXirbwo3c5STvtTRaYXi0JswYHOAjecnpLKmibve9hSCO7kvhVFv3Yzzj I54mk6S1/POg/5UyEiVTBMVCo6e7nE3YI11Pt/lA8rDTJVGkmcRkvjgCTKWmzvj4Kibu BYxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=UW93qry9GVQckCsd2b0jLokbEt/fxSWT022e2QwWN0c=; b=Y8VkPeEVVqIdJ2oyKv+JEUHzAUynlNfrBy1N/mu9L5rUP0Vq6O3uxpB9NsgJYTUHSd OuAfUvdRb4jfZiqAsjEo5RzNAo+Hnwx2UX227+MgX0k8zRHTY99+hWIMEF4nO6qpzEyQ gss+h8OxFnEYMhpeDOIUoekrKeTgqZ6Ko929gZdoY3acwhxMZf11gdHphHSrW4YmULW9 B7PNV5EJ7wW8NiDdYBbKOlba4kiN24EcaffTUczThxIHzOiROoo09CQo12Ew1ea8O4ml M0Iqn0VZd75yedeRQQqdl216bevLOc9KweWRbfXcmZ8AaxkkE57DDkXAx5wEF1Kck1ZS iWqg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=samsung.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h34-v6si13501877pld.26.2018.03.07.12.44.32; Wed, 07 Mar 2018 12:44:47 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=samsung.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964788AbeCGUmy (ORCPT + 99 others); Wed, 7 Mar 2018 15:42:54 -0500 Received: from osg.samsung.com ([64.30.133.232]:62167 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934747AbeCGUmv (ORCPT ); Wed, 7 Mar 2018 15:42:51 -0500 Received: from localhost (localhost [127.0.0.1]) by osg.samsung.com (Postfix) with ESMTP id ECB3C3FBC6; Wed, 7 Mar 2018 12:42:50 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at dev.s-opensource.com X-Amavis-Alert: BAD HEADER SECTION, Duplicate header field: "References" Received: from osg.samsung.com ([127.0.0.1]) by localhost (localhost [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XLd_eAU0CTaV; Wed, 7 Mar 2018 12:42:49 -0800 (PST) Received: from localhost.localdomain (c-24-9-64-241.hsd1.co.comcast.net [24.9.64.241]) by osg.samsung.com (Postfix) with ESMTPSA id 119EE3FBAE; Wed, 7 Mar 2018 12:42:49 -0800 (PST) From: Shuah Khan To: valentina.manea.m@gmail.com, shuah@kernel.org, gregkh@linuxfoundation.org Cc: Shuah Khan , yuyang.du@intel.com, k.opasiak@samsung.com, nobuo.iwata@fujixerox.co.jp, julien.boibessot@armadeus.com, jdieter@lesbg.com, peter.senna@gmail.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/3] usbip: usbip_host_common: Use new error codes to return request status Date: Wed, 7 Mar 2018 13:42:25 -0700 Message-Id: <396a52023e61a8f68e66dd9d37c44ea06fd731a4.1520455011.git.shuahkh@osg.samsung.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Currently ST_OK and ST_NA are the only values used to communicate status of a request from a client. Use new error codes to clearly indicate what failed. For example, when client sends request to import a device that isn't export-able, send ST_DEV_BUSY to the client. Signed-off-by: Shuah Khan --- tools/usb/usbip/libsrc/usbip_host_common.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/usb/usbip/libsrc/usbip_host_common.c b/tools/usb/usbip/libsrc/usbip_host_common.c index 6ff7b601f854..dc93fadbee96 100644 --- a/tools/usb/usbip/libsrc/usbip_host_common.c +++ b/tools/usb/usbip/libsrc/usbip_host_common.c @@ -234,14 +234,17 @@ int usbip_export_device(struct usbip_exported_device *edev, int sockfd) switch (edev->status) { case SDEV_ST_ERROR: dbg("status SDEV_ST_ERROR"); + ret = ST_DEV_ERR; break; case SDEV_ST_USED: dbg("status SDEV_ST_USED"); + ret = ST_DEV_BUSY; break; default: dbg("status unknown: 0x%x", edev->status); + ret = -1; } - return -1; + return ret; } /* only the first interface is true */ -- 2.14.1