Received: by 10.223.185.116 with SMTP id b49csp5650331wrg; Wed, 7 Mar 2018 15:50:37 -0800 (PST) X-Google-Smtp-Source: AG47ELu+9tWIYosLrEC1ngaTqfl14oxs7mf0COyYwxzFoom5nO+AF88R0zmwbm0uKibkTSe034Q+ X-Received: by 2002:a17:902:8b85:: with SMTP id ay5-v6mr22509415plb.329.1520466637364; Wed, 07 Mar 2018 15:50:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520466637; cv=none; d=google.com; s=arc-20160816; b=wsSPxosELh5mYznltPBumvJ9aL3J+oYdwI/MYBAF8ZC9JXAMeQQsTHassKus/PlUAI u3CTJVNfeiJtPH3ifCjQsBPklT19fk8DDOH586DQR27eUBpSkjFyA3KFGxquN+xIcy9Z rS35swgSVj3ahxRzzfK3tnwLGfjxoIad1J9yKTiXwTHKVTC2OJBIf3KwZ0FqkVqo0UKC vYRDztwDalD8EFxgBhzy7UAcsc4mwMoM3KnLf1copcrJZWcOoSTGRAes3ZPTvknD7nIu vBeGIrweJOEhwAQEuvcmniV1qjkr8LH9oPpfr9x5iB+07vBXJgpAp7LD1NNxPT72zkB4 l8rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=lICjDqLdnrdOxr4YpUU3Se5UlZ5TuAoopBOhZO7VVPY=; b=C1dB82o9y08TqoDOl/3CCBDv2uy1hGq7SGMau2TzOlC7PzknGaR392855sR77ckT1k MkUTP8qfDuatFLSRL5cJP6kpUbQr+dnp/JB1lgM3YJ/DN30lZ8DZBtG1fZBY7g4kfDuB euZtzauBpbJiNmx5h0qDnY/JJW7QkiCPf6Nooj01vJm1KzhCob0G+15RfREpJD8UiIBa 6tmqwFg5sJqiXveU9Cogs7Pe8DXnQyObd+jtKPmJLuWeDTpwQ9dq1pqLLJM6by3jKD8U 2XG6cxkgjtiOqSXrz3ldlNH7FlbHSda2enDxdhSRrKMi5HaQmk63cycl279FG/FXRI8W +M6Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j15si11910966pgv.676.2018.03.07.15.50.22; Wed, 07 Mar 2018 15:50:37 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754973AbeCGXt3 (ORCPT + 99 others); Wed, 7 Mar 2018 18:49:29 -0500 Received: from mga04.intel.com ([192.55.52.120]:36606 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754771AbeCGXt2 (ORCPT ); Wed, 7 Mar 2018 18:49:28 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Mar 2018 15:49:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,437,1515484800"; d="scan'208";a="32169350" Received: from sbauer-z170x-ud5.lm.intel.com (HELO sbauer-Z170X-UD5) ([10.232.112.135]) by FMSMGA003.fm.intel.com with ESMTP; 07 Mar 2018 15:49:27 -0800 Date: Wed, 7 Mar 2018 16:24:29 -0700 From: Scott Bauer To: Jonas Rabenstein Cc: Jonathan Derrick , Jens Axboe , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] block: sed-opal: fix u64 short atom length Message-ID: <20180307232428.hv3zkcxldbu5w3tx@sbauer-Z170X-UD5> References: <1520379912.4178.83.camel@intel.com> <20180301132700.1279-1-jonas.rabenstein@studium.uni-erlangen.de> <20180307165556.2618-1-jonas.rabenstein@studium.uni-erlangen.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180307165556.2618-1-jonas.rabenstein@studium.uni-erlangen.de> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 07, 2018 at 05:55:56PM +0100, Jonas Rabenstein wrote: > The length must be given as bytes and not as 4 bit tuples. > > Signed-off-by: Jonas Rabenstein > --- > v2: > - use fls64 > - shorten loop body > --- > block/sed-opal.c | 11 ++++------- > 1 file changed, 4 insertions(+), 7 deletions(-) > Reviewed-by: Scott Bauer Your two patches should be sent to stable for 4.14. I can queue those up and do it, or if you want to you can do it as well. Let me know what you prefer!