Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Kevin Hilman <khilman@baylibre.com>
To:     Jerome Brunet <jbrunet@baylibre.com>
Cc:     Neil Armstrong <narmstrong@baylibre.com>,
        linux-amlogic@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] amlogic: meson-gx-socinfo: Update soc ids
Organization: BayLibre
References: <1518620335-17716-1-git-send-email-narmstrong@baylibre.com>
        <1518689694.2883.68.camel@baylibre.com>
Date:   Wed, 07 Mar 2018 17:08:33 -0800
In-Reply-To: <1518689694.2883.68.camel@baylibre.com> (Jerome Brunet's message
        of "Thu, 15 Feb 2018 11:14:54 +0100")
Message-ID: <7ho9jzgyr2.fsf@baylibre.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Jerome Brunet <jbrunet@baylibre.com> writes:

> On Wed, 2018-02-14 at 15:58 +0100, Neil Armstrong wrote:
>> Updates the Amlogic Meson SoCs IDs for the Armv8 based SoCs.
>> It includes the new families and packages.
>> 
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>> ---
>>  drivers/soc/amlogic/meson-gx-socinfo.c | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>> 
>> diff --git a/drivers/soc/amlogic/meson-gx-socinfo.c b/drivers/soc/amlogic/meson-gx-socinfo.c
>> index f2d8c3c..a7efe30 100644
>> --- a/drivers/soc/amlogic/meson-gx-socinfo.c
>> +++ b/drivers/soc/amlogic/meson-gx-socinfo.c
>> @@ -33,6 +33,10 @@ static const struct meson_gx_soc_id {
>>  	{ "GXL", 0x21 },
>>  	{ "GXM", 0x22 },
>>  	{ "TXL", 0x23 },
>> +	{ "TXLX", 0x24 },
>> +	{ "AXG", 0x25 },
>> +	{ "GXLX", 0x26 },
>> +	{ "TXHD", 0x27 },
>>  };
>>  
>>  static const struct meson_gx_package_id {
>> @@ -47,6 +51,10 @@ static const struct meson_gx_package_id {
>>  	{ "S905L", 0x21, 0xc0 },
>>  	{ "S905M2", 0x21, 0xe0 },
>>  	{ "S912", 0x22, 0 },
>> +	{ "962X", 0x24, 0x10 },
>> +	{ "962E", 0x24, 0x20 },
>> +	{ "A113X", 0x25, 0x37 },
>> +	{ "A113D", 0x25, 0xd0 },
>>  };
>>  
>>  static inline unsigned int socinfo_to_major(u32 socinfo)
>
> Tested on my s400 board which, according to the marking, features an AXG A113D.
> AXG is detected correctly but the package id read is 0x22 instead of 0xd0.

Neil, can you update accordingly?  Have you seen 0xd0 on other A11x
chips?  or is this from the docs?

Kevin