Received: by 10.223.185.116 with SMTP id b49csp5727524wrg; Wed, 7 Mar 2018 17:26:54 -0800 (PST) X-Google-Smtp-Source: AG47ELsYzX4e8GhMSGCnPl3WJbkru0iMV3UcrgIeW3sRMHSdw6CYQXl9gOhV7AdPhgKX/piSUbUE X-Received: by 2002:a17:902:2c43:: with SMTP id m61-v6mr22350475plb.387.1520472414780; Wed, 07 Mar 2018 17:26:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520472414; cv=none; d=google.com; s=arc-20160816; b=fQYa/fXR0GtTxUrQBGyyZOxnMxfan2B5WHoN0Yuzx7tnmrBWaE9kLKJyauTjSrn2Vj xjvqi7EBW9/t4ZefAfQALDZlr9DdigXZfOu3PJbCycfDHH0ZnvMb+SskwlhjFdF6e9As uU/f7pQK4Mewwf/2bthXE80IYeAM3xMJ7Vjc96VwxkX+XSnvBl44LlMl8eUDsqrMOFGS Fezc+PFrv6sXWA2jMYqpBC5qAVU3fvwxGMC9vkNdVe+T6d5wIlJsV26VD2fvTqpZQfWV fjA9Ea/3l05UCAggjcfGDEqWA4L0zrEjwgOdbvkSMzMaJptJZCxiMa1qQ8hbjzzvCgtv 7H8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dmarc-filter :arc-authentication-results; bh=p3/vtctABeykhUBZMZ9BPobId7g9tEYS62QUTIH4kYI=; b=i/Rsdziyv3GxMRLavpbILsrHC9iYCp46fuxIVZc8eZJx1z/oqikZJMBsCLwBMUOwrs Uo75PxOK1aAY9T+D5+nti1mUSnEg5vP4Jzo6cUOhTCgIJu+H0hMLdhZHpi8a3SUbrubl U0f7EtGg1VEbQ6Se+H1o+nPT31Bf7urSZOYJnus+5bD/NMkL/ysQr8GYfAuok7azE1Of kKdyisW1lKRAeBbhkBWO52LKxIs8uPtLWEp8H7Fv0zfk+9OhiAqLQ3qwD8uQf4cOSwXR 7LkNqU0hLn2/d75Yc/SQ6O0KX3Q9f4tZTMvVgqsy6lgrtTQB1UvQeibGCmrBu/39brCp HZ/Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a190si12233211pge.436.2018.03.07.17.26.40; Wed, 07 Mar 2018 17:26:54 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934520AbeCHBZQ (ORCPT + 99 others); Wed, 7 Mar 2018 20:25:16 -0500 Received: from mail.kernel.org ([198.145.29.99]:58756 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933351AbeCHBZP (ORCPT ); Wed, 7 Mar 2018 20:25:15 -0500 Received: from mail-qk0-f175.google.com (mail-qk0-f175.google.com [209.85.220.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4D9DF2172D; Thu, 8 Mar 2018 01:25:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4D9DF2172D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=robh@kernel.org Received: by mail-qk0-f175.google.com with SMTP id d206so5052220qkb.3; Wed, 07 Mar 2018 17:25:14 -0800 (PST) X-Gm-Message-State: AElRT7GQ22AxLp9rmvkXyzFFqhATZbMye1lrLwBKCEU3CUKOVO1q2xWC Y1/dQBopbN9ahOJrcFz8vn8eYFHjsnXA0pq/wA== X-Received: by 10.55.15.22 with SMTP id z22mr30120544qkg.184.1520472313486; Wed, 07 Mar 2018 17:25:13 -0800 (PST) MIME-Version: 1.0 Received: by 10.12.178.131 with HTTP; Wed, 7 Mar 2018 17:24:52 -0800 (PST) In-Reply-To: References: <1519949975-13548-1-git-send-email-richard.gong@linux.intel.com> <1519949975-13548-5-git-send-email-richard.gong@linux.intel.com> <20180307194745.657ewa6rtcta6eqm@rob-hp-laptop> From: Rob Herring Date: Wed, 7 Mar 2018 19:24:52 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCHv2 4/7] dt-bindings: fpga: add Stratix10 SoC FPGA manager binding To: Alan Tull Cc: Richard Gong , Catalin Marinas , Will Deacon , Dinh Nguyen , Mark Rutland , Moritz Fischer , Arnd Bergmann , Greg Kroah-Hartman , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-kernel , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-fpga@vger.kernel.org, Yves Vandervennet Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 7, 2018 at 4:20 PM, Alan Tull wrote: > On Wed, Mar 7, 2018 at 1:47 PM, Rob Herring wrote: >> On Thu, Mar 01, 2018 at 06:19:32PM -0600, richard.gong@linux.intel.com wrote: >>> From: Alan Tull >>> >>> Add a Device Tree binding for the Intel Stratix10 SoC FPGA manager. >>> >>> Signed-off-by: Alan Tull >>> --- >>> v2: this patch is added in patch set version 2 >>> --- >>> .../devicetree/bindings/fpga/intel-stratix10-soc-fpga-mgr.txt | 10 ++++++++++ >>> 1 file changed, 10 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/fpga/intel-stratix10-soc-fpga-mgr.txt >>> >>> diff --git a/Documentation/devicetree/bindings/fpga/intel-stratix10-soc-fpga-mgr.txt b/Documentation/devicetree/bindings/fpga/intel-stratix10-soc-fpga-mgr.txt >>> new file mode 100644 >>> index 0000000..78de689 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/fpga/intel-stratix10-soc-fpga-mgr.txt >>> @@ -0,0 +1,10 @@ >>> +Intel Stratix10 SoC FPGA Manager >>> + >>> +Required properties: >>> +- compatible : should contain "intel,stratix10-soc-fpga-mgr" >>> + >>> +Example: >>> + >>> + fpga_mgr: fpga-mgr@0 { >>> + compatible = "intel,stratix10-soc-fpga-mgr"; >> >> No reg or anything else? Is that because it all goes thru the service >> layer firmware? > > Yes. > > There will be a few more clients of the service layer: QSPI, Crypto > and warm reset. > >> Just get the service layer driver to instantiate a >> device for this driver or get rid of the 2 layers if that's all the >> firmware interface does. DT is not a Linux driver instantiation >> mechanism. > > Right, this should be describing hardware. > > I could add this to the service layer binding: > > firmware { > svc { > compatible = "intel,stratix10-svc"; > method = "smc"; > memory-region = <&service_reserved>; > fpga-mgr { > compatible = "intel,stratix10-soc-fpga-mgr"; Still, why do you need this node? If you don't have any other cross tree connections, then the service layer can instantiate the device(s). OTOH, QSPI would need a node because you'll need to describe its bus. Rob