Received: by 10.223.185.116 with SMTP id b49csp5809962wrg; Wed, 7 Mar 2018 19:10:11 -0800 (PST) X-Google-Smtp-Source: AG47ELtyxvzQjkdEodZXVsTlMDb1fhONtG3fONGD15lodoQh1vfg+EvR/zIauoDiKajq4sTrfecw X-Received: by 10.99.103.133 with SMTP id b127mr19681041pgc.155.1520478611706; Wed, 07 Mar 2018 19:10:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520478611; cv=none; d=google.com; s=arc-20160816; b=k5lkQJJGwPTUBY2d/tR3Nji9NX81DYj3v82UD01OSwXPzbOsANxN81amh+Cs1wcF6t alW4EO4gqznqdK3Y36KiZZABg1XwNxszk0EJjBuzGTtKPia8cvjLBDBpY8K1ioFlUcFP D9eohZMTJ/pU5GUGqNyecuaqdA69lEbKdVelC5y1r6NEmvuWvksonCMNuTHvnEI5j5JF gDRYo3/dea833tWh3ny0ELzb+wbPHMlYhVz0seYa/b5IweYMtgd2Dl8FT9BIwrHOdqDb otAiGu0kJEtVmnI5n0ZAP+WSMwTovZhltxjvMy8C0H01QumQdwNva9tyobiQFy1JxlBP u2Kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :references:in-reply-to:date:cc:to:from:subject:message-id :arc-authentication-results; bh=V9zN28cA8MgtaulaOJD053o8BXVnwvnjz7Lj8RU8pCs=; b=k6Sk1Ue3KhTnooCH7qKkS14jfWn27Z4ei6tv3Y4VFvmAc922+vOYB3mJ3Q/DIdtN2a LGbQMkzv3U8vBzvjEdYtg3bkbX72yz0X2SMiJwEAzYgkyOJsTqvbwSwQ2Xg9qg9C6rNo dRTgA7fU3mPpasfVYJ7s44hlcvjfHV2qCrLWRWzh+C+kQhCMheUEtQ9McOft8F4ivISW XGQ/WgjhnbqkSm5nSoDGeoHN3/hgeqPSGfBcO+HKqLH+HbGf4/EhEC2ijVD0a6I6GcLR eK5s3N5M8Tk05yUoUx6zjte8Hhfgzl+TcAFjptGnaAa+muSR+BDA/VHS/ITsAQAwd01Y cKPw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w130si14864537pfd.280.2018.03.07.19.09.55; Wed, 07 Mar 2018 19:10:11 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934609AbeCHDI6 (ORCPT + 99 others); Wed, 7 Mar 2018 22:08:58 -0500 Received: from mailgw02.mediatek.com ([210.61.82.184]:7942 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S932759AbeCHDI4 (ORCPT ); Wed, 7 Mar 2018 22:08:56 -0500 X-UUID: 162e289610ba48058ef9ccd942fab38e-20180308 Received: from mtkexhb02.mediatek.inc [(172.21.101.103)] by mailgw02.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 592655197; Thu, 08 Mar 2018 11:08:50 +0800 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs01n2.mediatek.inc (172.21.101.79) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Thu, 8 Mar 2018 11:08:49 +0800 Received: from [172.21.77.33] (172.21.77.33) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1210.3 via Frontend Transport; Thu, 8 Mar 2018 11:08:50 +0800 Message-ID: <1520478530.4049.3.camel@mtkswgap22> Subject: Re: [PATCH v3 0/4] PINCTRL: Mediatek pinctrl driver for mt2712 From: Sean Wang To: Zhiyong Tao CC: , , , , , , , , , , , , , , , Date: Thu, 8 Mar 2018 11:08:50 +0800 In-Reply-To: <1520249745-6757-1-git-send-email-zhiyong.tao@mediatek.com> References: <1520249745-6757-1-git-send-email-zhiyong.tao@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Zhiyong you should checkpatch every patch before sending them out because I saw tons of check messages like below result for scanning v3 3/4 CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #152: FILE: drivers/pinctrl/mediatek/pinctrl-mt2712.c:85: +static int mt2712_spec_pull_set(struct regmap *regmap, unsigned int pin, + unsigned char align, bool isup, unsigned int r1r0) CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #353: FILE: drivers/pinctrl/mediatek/pinctrl-mt2712.c:286: +static int mt2712_ies_smt_set(struct regmap *regmap, unsigned int pin, + unsigned char align, int value, enum pin_config_param arg) CHECK:LINE_SPACING: Please don't use multiple blank lines #423: FILE: drivers/pinctrl/mediatek/pinctrl-mt2712.c:356: + + CHECK:LINE_SPACING: Please don't use multiple blank lines #473: FILE: drivers/pinctrl/mediatek/pinctrl-mt2712.c:406: + + CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #719: FILE: drivers/pinctrl/mediatek/pinctrl-mtk-mt2712.h:14: + MTK_PIN( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #731: FILE: drivers/pinctrl/mediatek/pinctrl-mtk-mt2712.h:26: + MTK_PIN( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #742: FILE: drivers/pinctrl/mediatek/pinctrl-mtk-mt2712.h:37: + MTK_PIN( .... total: 0 errors, 1 warnings, 214 checks, 2619 lines checked On Mon, 2018-03-05 at 19:35 +0800, Zhiyong Tao wrote: > This series includes four patches: > 1.Add mt2712 pintcrl head file. > 2.Add mt2712 pinctrl device node. > 3.Add mt2712 pinctrl driver. > 4.Support bias-disable of generic and special pins simultaneously. > > Changes in patch v3: > 1)Use SPDX identifiers for all new files. > 2)Use right data for Copyright and Author. > 3)Correct some spelling mistake. > 4)Reusing original logic and change solution to support bias-disable of generic and special pins simultaneously. > 5)Add some comments for the speical path of special pins bias-disable. > > Changes in patch v2: > 1)Separate patch4 for supporting bias-disable of generic and special pins. > 2)GPIO16~17 direction setting is changed as generic pins in mt2712 E2, > So remove GPIO16~17 special direction setting and remove apmixedsys node in pinctrl device node. > 3)Add pinmux define in "mt2712-pinfunc.h" and "pinctrl-mtk-mt2712.h" for mt2712 E2 design. > > Zhiyong Tao (4): > arm64: dts: mt2712: add pintcrl file > arm64: dts: mt2712: add pintcrl device node. > pinctrl: add mt2712 pinctrl driver > pintcrl: support bias-disable of generic and special pins > simultaneously > > arch/arm64/boot/dts/mediatek/mt2712-pinfunc.h | 1123 ++++++++++++++ > arch/arm64/boot/dts/mediatek/mt2712e.dtsi | 18 + > drivers/pinctrl/mediatek/Kconfig | 7 + > drivers/pinctrl/mediatek/Makefile | 1 + > drivers/pinctrl/mediatek/pinctrl-mt2712.c | 632 ++++++++ > drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 6 + > drivers/pinctrl/mediatek/pinctrl-mtk-mt2712.h | 1967 +++++++++++++++++++++++++ > 7 files changed, 3754 insertions(+) > create mode 100644 arch/arm64/boot/dts/mediatek/mt2712-pinfunc.h > create mode 100644 drivers/pinctrl/mediatek/pinctrl-mt2712.c > create mode 100644 drivers/pinctrl/mediatek/pinctrl-mtk-mt2712.h > > -- > 2.6.4 > > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek