Received: by 10.223.185.116 with SMTP id b49csp5966972wrg; Wed, 7 Mar 2018 22:51:23 -0800 (PST) X-Google-Smtp-Source: AG47ELtRXQFFA9O9mQtwiZRUDpNA4cCDKjcHfb4FLL6WzRKDazNzN+v3DPOWzWGAfTgJSH8h2IDs X-Received: by 10.99.3.6 with SMTP id 6mr936513pgd.5.1520491883783; Wed, 07 Mar 2018 22:51:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520491883; cv=none; d=google.com; s=arc-20160816; b=fKn0L3rmfT3gxlUkt54LtPap6HT64IJBSQllUyUZmaLFNcaEYnCOOahu5t9sjnutth 4JQi95vcqzlXwudJmhD1zXc1KpDSQFRsQuxVEo6SQlGYXMmw7jrLMBYBZNSaxGXDF8Sa iMbeJOmw/5ADWHBqtJsp52YCCp/Vu4WbTuc1PgNPncC0U4Vo82FGO0eG5jGb75NBYdIc Mh75N+yLIj67U0MxwFLXvj4dIVm+T4hH87mO0M2NtY4c1VQgIzy2Psbx4jCGdkVAA68A kSvP/R9Qj99jxeLDQgm4L7CORZkUy0OrmVz2wC3BG0F627krjItssyFij6ZYQZ28QyCX gCyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :spamdiagnosticmetadata:spamdiagnosticoutput:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=DHzTkmWov34e75OzwivOXqgUUPVMau5NjkKS3lIL7QI=; b=w50CpIz3cdSS4YPYkJIAr9/ZrJtqzwC4OF3FSa2xeNDsS85y3Ox3h+V/bcGLadR9ER 8NLpF+xzWw/ai/QlkVvFBDli/4hGBIUx/m9RIlu2isa6+k+vFyv+srxJi52umvhfVTI4 KCRbtFMgvoAgv8+R6y0FSmVQFDTcz11WtrXjmaFCaeru0TpYzhJ+NaNwK7NX8F73GFiO 8U3pAreVWD0NdamL9WMFw7mLzj9Z0kAiigOg+hGDKfPEsDMOw/Anah2yCLo3nUd67IPF 2tXQ6B78Evj9PscT86ogCWyD69VLz0+ew0ipFp1e5mu1kNPdOkDur1kFsNmff1PMpE3/ bVLw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=ijpM6n71; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x1si12520627pgp.89.2018.03.07.22.51.09; Wed, 07 Mar 2018 22:51:23 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=ijpM6n71; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965487AbeCHGuV (ORCPT + 99 others); Thu, 8 Mar 2018 01:50:21 -0500 Received: from mail-by2nam03on0101.outbound.protection.outlook.com ([104.47.42.101]:17968 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S965057AbeCHE6O (ORCPT ); Wed, 7 Mar 2018 23:58:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=DHzTkmWov34e75OzwivOXqgUUPVMau5NjkKS3lIL7QI=; b=ijpM6n71kkG5b0c61iAYvjDhdORnOXZJgUOxuxYcs3vFkVJ9ekNuYaNeXbE9niPjICTRFKawSxdNTaYi4jAp4yGIW64xx/XE6swPMt4k0m2nN16hxhT9QWUpr8d2nqHMN9iI9nTBcywdIXM49jDMWpqnTt7RSyasa+JnAR0UfDg= Received: from DM5PR2101MB1032.namprd21.prod.outlook.com (52.132.128.13) by DM5PR2101MB0808.namprd21.prod.outlook.com (10.167.110.156) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.588.1; Thu, 8 Mar 2018 04:58:12 +0000 Received: from DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::8063:c68a:b210:7446]) by DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::8063:c68a:b210:7446%2]) with mapi id 15.20.0588.008; Thu, 8 Mar 2018 04:58:12 +0000 From: Sasha Levin To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" CC: Ron Economos , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH AUTOSEL for 4.14 18/67] media: [RESEND] media: dvb-frontends: Add delay to Si2168 restart Thread-Topic: [PATCH AUTOSEL for 4.14 18/67] media: [RESEND] media: dvb-frontends: Add delay to Si2168 restart Thread-Index: AQHTtpn7b7I8zGGJXU2Obh9xwEToTA== Date: Thu, 8 Mar 2018 04:57:39 +0000 Message-ID: <20180308045641.7814-18-alexander.levin@microsoft.com> References: <20180308045641.7814-1-alexander.levin@microsoft.com> In-Reply-To: <20180308045641.7814-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DM5PR2101MB0808;20:R06XrvPg6nGMTAU2+2nFP7nvBbKqaJ+kSCUb2J+MSvttXDAya/H1XThV4zzBJF4cJ7H/YPqWFLEmNuXmFzogyKQpcHPNAYtV8e6ENzcBQPtYNFO2QKFHeP77UEP4d4js0nKd9t53xo3wAoijfmp+gc3AIzmrbqRogL/btH84hFg= x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 61f00f57-9dad-45dc-5b9e-08d584b13214 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7193020);SRVR:DM5PR2101MB0808; x-ms-traffictypediagnostic: DM5PR2101MB0808: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(68173958961439)(89211679590171); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(61425038)(6040501)(2401047)(8121501046)(5005006)(93006095)(93001095)(3231220)(944501244)(52105095)(10201501046)(3002001)(6055026)(61426038)(61427038)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123560045)(20161123562045)(20161123558120)(6072148)(201708071742011);SRVR:DM5PR2101MB0808;BCL:0;PCL:0;RULEID:;SRVR:DM5PR2101MB0808; x-forefront-prvs: 060503E79B x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(39380400002)(396003)(39860400002)(366004)(376002)(346002)(199004)(189003)(22452003)(99286004)(76176011)(2906002)(105586002)(3846002)(86612001)(478600001)(72206003)(14454004)(8666007)(2900100001)(8676002)(102836004)(68736007)(5660300001)(316002)(6116002)(54906003)(26005)(6506007)(575784001)(1076002)(86362001)(36756003)(186003)(10090500001)(110136005)(106356001)(6306002)(4326008)(6512007)(6486002)(7736002)(5250100002)(3280700002)(3660700001)(2501003)(6666003)(81166006)(2950100002)(305945005)(53936002)(107886003)(8936002)(6436002)(81156014)(66066001)(25786009)(10290500003)(97736004)(966005)(22906009)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5PR2101MB0808;H:DM5PR2101MB1032.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: ErxagfGm30puv/F2OLiEK9hwryy+jxF6GpFv7rbbutaVMPpgK6hgysGk8fuQK6nuAcqju5yKPyI4D303QGm3WTlMYw3f2x3ADn6nRKp6vWlIh6Mpk76fLmpPIZMy4M+luXfHlrqzbHEWXlSD7d3tJg18Aw5aj60KLSdYmMGIkUITLIPkmeEnKph1QdPyzz7Js4RBl0K89NqYDcEpUCjZYX3MTxsk2YNx8gTJDxkHGUGl8TDdve4v0S/Gil/0vVXnabzJrP2sslkiRLC//JgiuIjxc3YmyQ5zcRIbu4p7YdZsUmpUs8ZEGV0oiTtOerCLJ0WF1ub9CZfpVAnBbg5t5A== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 61f00f57-9dad-45dc-5b9e-08d584b13214 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Mar 2018 04:57:39.3983 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR2101MB0808 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ron Economos [ Upstream commit 380a6c86457573aa42d27ae11e025eb25941a0b7 ] On faster CPUs a delay is required after the resume command and the restart= command. Without the delay, the restart command often returns -EREMOTEIO a= nd the Si2168 does not restart. Note that this patch fixes the same issue as https://patchwork.linuxtv.org/= patch/44304/, but I believe my udelay() fix addresses the actual problem. Signed-off-by: Ron Economos Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/dvb-frontends/si2168.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/dvb-frontends/si2168.c b/drivers/media/dvb-front= ends/si2168.c index 172fc367ccaa..24840a2e5a75 100644 --- a/drivers/media/dvb-frontends/si2168.c +++ b/drivers/media/dvb-frontends/si2168.c @@ -14,6 +14,8 @@ * GNU General Public License for more details. */ =20 +#include + #include "si2168_priv.h" =20 static const struct dvb_frontend_ops si2168_ops; @@ -435,6 +437,7 @@ static int si2168_init(struct dvb_frontend *fe) if (ret) goto err; =20 + udelay(100); memcpy(cmd.args, "\x85", 1); cmd.wlen =3D 1; cmd.rlen =3D 1; --=20 2.14.1