Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Felipe Balbi <balbi@kernel.org>
To:     William Wu <william.wu@rock-chips.com>, gregkh@linuxfoundation.org,
        Roger Quadros <rogerq@ti.com>
Cc:     heiko@sntech.de, linux-kernel@vger.kernel.org,
        linux-usb@vger.kernel.org, linux-rockchip@lists.infradead.org,
        frank.wang@rock-chips.com, huangtao@rock-chips.com,
        dianders@google.com, briannorris@google.com, groeck@google.com,
        daniel.meng@rock-chips.com, John.Youn@synopsys.com,
        william.wu@rock-chips.com, lin.huang@rock-chips.com
Subject: Re: [PATCH] usb: dwc3: core: power on PHYs before initializing core
In-Reply-To: <1515729616-8639-1-git-send-email-william.wu@rock-chips.com>
References: <1515729616-8639-1-git-send-email-william.wu@rock-chips.com>
Date:   Thu, 08 Mar 2018 12:43:40 +0200
Message-ID: <87ina6vodf.fsf@linux.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha512; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable


Hi Roger,

William Wu <william.wu@rock-chips.com> writes:
> The dwc3_core_init() gets the PHYs and initializes the PHYs with
> the usb_phy_init() and phy_init() functions before initializing
> core, and power on the PHYs after core initialization is done.
>
> However, some platforms (e.g. Rockchip RK3399 DWC3 with Type-C
> USB3 PHY), it needs to do some special operation while power on
> the Type-C PHY before initializing DWC3 core. It's because that
> the RK3399 Type-C PHY requires to hold the DWC3 controller in
> reset state to keep the PIPE power state in P2 while configuring
> the Type-C PHY, otherwise, it may cause waiting for the PIPE ready
> timeout. In this case, if we power on the PHYs after the DWC3 core
> initialization is done, the core will be reset to uninitialized
> state after power on the PHYs.
>
> Fix this by powering on the PHYs before initializing core. And
> because the GUID register may also be reset in this case, so we
> need to configure the GUID register after powering on the PHYs.
>
> Signed-off-by: William Wu <william.wu@rock-chips.com>

does this cause any regressions for your boards?

=2D-=20
balbi

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAlqhE9wACgkQzL64meEa
mQbo8xAAtDhCIfBTcs4q9JOVmKiY9BpJ/u7lRXkm5jgNkuUD/DXSFIDiJAXijoNk
jVLw3sHf0HV+ba8EN8PM2TM18Ivv1K+ZFqQJOW06HKiE1xjrPlxoirWyxi97VdxM
wX9I9rQR/V/8O6WwM/nWLFeXlyaF7O7sNO+08zntExtPWeOK4L4yCkvAvpsH3csk
HfV4xGsnDKsU0rJ8xFo7TKOlB102f6NO5UL1kLowCLWSo8jRsnUDA7/NDpbl5yF7
sHmZbQmcBFCu2vzwdZqwxRIC+ziKjeWi/zbvTLH+8AH3fvDXtAY/0LAv1Um2ifrV
Q7XBOXYyJCcGNFA/uMS27KhGUFkOoHK3WB5+aLqbc6z544h5ZKf3PDo0g2CgzjEo
itkSrW/duxF7x/eXkn03JIuJN5X8UbTMsj6P9jdAw+NmKqnZZFQVYMtAAjK55q8o
+vN9hGbjGhq8kfaPoSL8Lm0TSYIglNcS/HliAd7VlgVP64K2ETEwZhaq8l7+MUIK
mScHu6KIFSkSq6BMBYm1GTILnXt8rVoTr5yPSmfPzki5V9W4Msa5HDZ35yoxHhFo
oEs2InHTLBZMeC+Vv6w77v8xy0X7mSGdz/BaXoJAlPRj/PfbzgKenP3z7/KnKqOo
YyMqKFnSKRpLFmUHGS2AscgnJhm5bQFAd5iRiJjq16FUmazeLJc=
=QuP9
-----END PGP SIGNATURE-----
--=-=-=--