Received: by 10.223.185.116 with SMTP id b49csp6175588wrg; Thu, 8 Mar 2018 03:09:27 -0800 (PST) X-Google-Smtp-Source: AG47ELsHwNOfIAMyLLlaFaQQeh0YVqGPuajcsEovwtbTNE0T7YoHWuP6WljSuHMd3EbAFY1+ZPq1 X-Received: by 10.98.171.24 with SMTP id p24mr25962941pff.71.1520507367313; Thu, 08 Mar 2018 03:09:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520507367; cv=none; d=google.com; s=arc-20160816; b=B6l1dV9WT0JfZ8Uet5+6hOKXw8pYdXGSk/HIEqV+IR7SUsWGHLkZo1QsDLQZ1tXOPe X1QxUB0dzc/6aClMqnBOra72kkJeaZzMgAdNr0T9KMPlKwX6LOU2SM4ZzFYhnXu4YiKN zz29EsKv0n2l8DKwc3m/9BVn9VVusyFASD9lOyi5ZA4QDp2HC1+2jB6sq9uWYP/XFmSR nCR9BubrF7Mfow43LNe6CX6N4LJyKhPKDUrVtoBxeA1GiwbjVu+c6k+m7Pbluvv/1e7a 1qHgp0QIbR8Gn3T+2mxXTCeh/7xovAXkxHvSSprmNk+BLnJ2xrKP6/XsXe/1w+iKNyUz ovXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=hauWjqS8dkuDmI4hbu3da9d7tOgbMJTQx86Ky0uuhSw=; b=kWw3gpDaZ9o6RxxeqX+ZEKZgLBMcVZX4vCWix1u/HosBBnZVVPxlNrLG6sYh+4xxEQ FlhquyBuRMzbouzAx6CsnbgAsodCvkANdjncqMKN9I9p7sF6HYONl5nHyHV72C1/VVJr aH6e1U9afFdf16LmQ2yKPC3QRgMFHlYZjuzNefjpK3bPbYWu0DZeemYYT+qh5gPgDMHd MZq5QMABweZ9YXgRpSM2AZA7iy8hkhc/W2DJbkEYd59M2z08z6JWC+it15A74BhlRzaB Ap+SSmcL20SufQP5zQ5CHgbY2cRrlsvXzmi5obvEFBxUufxK48sOCx20d91FVLTvHt1W O1Jg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=ITTigp8L; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z1-v6si5940405plo.743.2018.03.08.03.09.11; Thu, 08 Mar 2018 03:09:27 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=ITTigp8L; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755623AbeCHLIM (ORCPT + 99 others); Thu, 8 Mar 2018 06:08:12 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:53350 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751971AbeCHLIK (ORCPT ); Thu, 8 Mar 2018 06:08:10 -0500 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w28AufI1121549; Thu, 8 Mar 2018 11:07:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2017-10-26; bh=hauWjqS8dkuDmI4hbu3da9d7tOgbMJTQx86Ky0uuhSw=; b=ITTigp8Lj8bigRELbPYuc/AdoA1j8oQaMleJEHraruIT/0K2tmcyfWCHRMna9Gi/mh4Y S/ax/2ojJ9MjEzwofWcS7O419MJZLzB4BEjbzXDDjkedivueib26/pFCrkP5qjGlyq+n Y7r7/jzFCEgJVO1OizQ0TU/noyTjeixLbPMKKqTqmuH316SAFsm9SRlvR/dvHCUUONE3 yXdMU03JJ+2As3WXSQqwGzjgnM1lL+5iya2E+KxMKW2jyP5OOY+6mtb8wCDtThIR7gku 33Jd/ZMaZMLHQqjdmugP7BJTdd53Kx8J+x7ozKPEuwxaBI7jRAr7ftYxJyAtgcW5wpzu cA== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp2120.oracle.com with ESMTP id 2gk3ud024x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 08 Mar 2018 11:07:56 +0000 Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w28B2tXH010757 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 8 Mar 2018 11:02:55 GMT Received: from abhmp0007.oracle.com (abhmp0007.oracle.com [141.146.116.13]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w28B2rrP022800; Thu, 8 Mar 2018 11:02:53 GMT Received: from mwanda (/197.254.35.146) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 08 Mar 2018 03:02:52 -0800 Date: Thu, 8 Mar 2018 14:02:44 +0300 From: Dan Carpenter To: Paul Lawrence Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, Todd Kjos , Greg Kroah-Hartman , stable@vger.kernel.org, Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Martijn Coenen , Ben Hutchings Subject: Re: [PATCH] staging: android: ashmem: Remove deadlock Message-ID: <20180308110244.htlc5uh5aqtltgol@mwanda> References: <20180307214042.135109-1-paullawrence@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180307214042.135109-1-paullawrence@google.com> User-Agent: NeoMutt/20170609 (1.8.3) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8825 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=836 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1803080131 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks! Somebody already sent this. On Wed, Mar 07, 2018 at 01:40:30PM -0800, Paul Lawrence wrote: > Regression introduced in commit ce8a3a9e76d0193e2e8d74a06d275b3c324ca652 > ("staging: android: ashmem: Fix a race condition in pin ioctls") > causing deadlock. Use the Fixes tag for this. The format is: Fixes: ce8a3a9e76d0 ("staging: android: ashmem: Fix a race condition in pin ioctls") Then you only need one stable CC line. Just the oldest kernel which needs to be patched. Cc: # 3.18.x The extra git hash after the stable CC is for if a bug requires several patches to fix it. In this case it only requires just this patch so there's no need to have the hash. Basically you did extra work which isn't required. Anyway, this fix was already merged so no need to resend or anything. regards, dan carpenter