Received: by 10.223.185.116 with SMTP id b49csp6209329wrg; Thu, 8 Mar 2018 03:46:21 -0800 (PST) X-Google-Smtp-Source: AG47ELsxGubyuWYlXKu+wexeDoMNnTSQBY6uL2/7JhhKLWOwebiXjWNyEOYJQUSNmFLhkPIHbuIo X-Received: by 10.101.102.21 with SMTP id w21mr21602307pgv.247.1520509581092; Thu, 08 Mar 2018 03:46:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520509581; cv=none; d=google.com; s=arc-20160816; b=nPfO85NQcHUdO28Us1nhmIiVV7hfuhZdy+MLMKb814u7+Sqfl45NECy177P33jGKVR gH/9M1G1UCkpUsQUNdyClQP5nEcIGGx+ayBAY++F4cFGyJG1XWYSdSdKCuOxSo2kdqzq tkcwEUmUPHiatXHZ5Za028PCZwfC3/B5Ek2VVra3rZ7dZWHDxEWieVDD+i3Q8UYEQIaZ qGMRA0rfUibJmvm6mkRhZMrxJx4lRcMCSJddhwkiORl/TfN39OaTxl7KICKRLkvcFcKE 1b8GIC0y8MIYKflpFLgXrjba9u0aQoNa6CFOMPzly6AGcBfKzcn9ogNKKcBHUgspL0nH +vAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:arc-authentication-results; bh=1YteyPtSX8ag26mj+Fh0ptLqV8yphc54B1yaUfSFpVU=; b=kEuf11hqe6fCyoojtq5PmqAtzT4XEy6M5igG7svJCaLi2uSEAwLyZGSMFO3HM7PtME 52LJSJVgFd4WMmdxrmoRRnuz01+56657R7mQRYYRV41XtFMedIFRvS+yjA7WPA7/nrF0 Cl0T+FV9evKzuVG8YzvPsfhDaDLNJuug3xxKSJ9eu0qgRd1h83kZFmSvm2Dm+lM4zcsF bReg6sk2KfVhfoXRLSGy7JobC05A+6heb9wpqxvzsk8LxQ0pHD9GdLrA6fAQRh06n/v1 vzMID7bxYHcUY13CFgck/5XxIzFfvKHB2YaVIiy36/KrJESTUvxWULaZDq8rWFc2eRm1 Xg0w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v10si12877783pgs.164.2018.03.08.03.46.06; Thu, 08 Mar 2018 03:46:21 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935836AbeCHLoN (ORCPT + 99 others); Thu, 8 Mar 2018 06:44:13 -0500 Received: from ozlabs.org ([103.22.144.67]:41963 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934653AbeCHLoM (ORCPT ); Thu, 8 Mar 2018 06:44:12 -0500 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPSA id 3zxpZL3XPvz9shR; Thu, 8 Mar 2018 22:44:10 +1100 (AEDT) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au From: Michael Ellerman To: Mathieu Malaterre Cc: Benjamin Herrenschmidt , Paul Mackerras , Jiri Slaby , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Mathieu Malaterre Subject: Re: [PATCH 21/21] powerpc: Add missing prototypes in setup_32.c In-Reply-To: <20180225172236.29650-22-malat@debian.org> References: <20180225172236.29650-1-malat@debian.org> <20180225172236.29650-22-malat@debian.org> Date: Thu, 08 Mar 2018 22:44:06 +1100 Message-ID: <876066eqrd.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mathieu Malaterre writes: > This commit add the prototypes for the following function: > > - early_init > - machine_init I'd rather these were in asm-prototypes.h, it's the header for functions called from asm. I made that change. > - ppc_setup_l2cr > - ppc_setup_l3cr > - ppc_init These three can just be static. So I did that. cheers