Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 08 Mar 2018 13:57:29 +0100
Message-ID: <s5h371a913a.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     "Dennis Wassenberg" <dennis.wassenberg@secunet.com>
Cc:     "Hui Wang" <hui.wang@canonical.com>,
        "Jaroslav Kysela" <perex@perex.cz>, <alsa-devel@alsa-project.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] hda: realtek: Make dock sound work on ThinkPad L570
In-Reply-To: <46c65214-2a41-77ce-6484-979b08fc44c1@secunet.com>
References: <46c65214-2a41-77ce-6484-979b08fc44c1@secunet.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 08 Mar 2018 13:17:54 +0100,
Dennis Wassenberg wrote:
> 
> One version of Lenovo Thinkpad T570 did not use ALC298
> (like other Kaby Lake devices). Instead it uses ALC292.
> In order to make the Lenovo dock working with that codec
> the dock quirk for ALC292 will be used.
> 
> Signed-off-by: Dennis Wassenberg <dennis.wassenberg@secunet.com>

So, although the PCI SSID appears to be a new one, this still needs
the old quirk, not for T470 dock?  Just to be sure.


thanks,

Takashi

> ---
>  sound/pci/hda/patch_realtek.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index b9c93fa..b5d0f8c 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -6508,6 +6508,7 @@ enum {
>  	SND_PCI_QUIRK(0x17aa, 0x2245, "Thinkpad T470", ALC298_FIXUP_TPT470_DOCK),
>  	SND_PCI_QUIRK(0x17aa, 0x2246, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
>  	SND_PCI_QUIRK(0x17aa, 0x2247, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
> +	SND_PCI_QUIRK(0x17aa, 0x2249, "Thinkpad", ALC292_FIXUP_TPT460),
>  	SND_PCI_QUIRK(0x17aa, 0x224b, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
>  	SND_PCI_QUIRK(0x17aa, 0x224c, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
>  	SND_PCI_QUIRK(0x17aa, 0x224d, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
> -- 
> 1.9.1
> 
> 
>