Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4B56A205F4
Date:   Thu, 8 Mar 2018 10:39:31 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     Agustin Vega-Frias <agustinv@codeaurora.org>
Cc:     linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Andi Kleen <ak@linux.intel.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>, timur@codeaurora.org
Subject: Re: [RFC V4] perf, tools: Support wildcards on pmu name in dynamic
 pmu events
Message-ID: <20180308133931.GA7273@kernel.org>
References: <1520454947-16977-1-git-send-email-agustinv@codeaurora.org>
 <20180308130358.GC3701@kernel.org>
 <ae102272a8186f0351363511f4ed07f8@codeaurora.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ae102272a8186f0351363511f4ed07f8@codeaurora.org>
User-Agent: Mutt/1.9.1 (2017-09-22)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Em Thu, Mar 08, 2018 at 08:28:13AM -0500, Agustin Vega-Frias escreveu:
> On 2018-03-08 08:03, Arnaldo Carvalho de Melo wrote:
> > Em Wed, Mar 07, 2018 at 03:35:47PM -0500, Agustin Vega-Frias escreveu:
> > > +++ b/tools/perf/util/parse-events.y
> > > @@ -8,6 +8,7 @@
> > > 
> > >  #define YYDEBUG 1
> > > 
> > > +#include <fnmatch.h>
> > >  #include <linux/compiler.h>
> > >  #include <linux/list.h>
> > >  #include <linux/types.h>
> > > @@ -234,6 +235,10 @@ PE_NAME opt_event_config
> > >  	if (parse_events_add_pmu(_parse_state, list, $1, $2)) {
> > >  		struct perf_pmu *pmu = NULL;
> > >  		int ok = 0;
> > > +		char *pattern;
> > > +
> > > +		if (asprintf(&pattern, "%s*", $1) < 0)
> > > +			YYABORT;

> > +               if (asprintf(&pattern, "?(uncore_)%s*", $1) < 0)

> > I completely overlook that you were using this and thus needed that
> > extension, duh, thanks for the patience 8-) and for the new patch.

Further trying to remove my brown paper bag: I thought the '?(...)' type
of thing would be something _users_ would pass on the perf tool command
line, not something used by the tool itself, like on the original
patch.... :-)
 
> NP Arnaldo, thanks for the quick turnaround on these patches :o)
> Just so I know, since these are my first patches on perf tools,
> where are perf tools patches queued once acked?

git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git perf/core

If they are super urgent, then they will go to a different branch,
perf/urgent, that is targetted for the current merge window, i.e. right
now:

 perf/core   -> 4.17
 perf/urgent -> 4.16

Thanks, and keep the patches flowing!

- Arnaldo