Received: by 10.223.185.116 with SMTP id b49csp6380204wrg; Thu, 8 Mar 2018 06:34:51 -0800 (PST) X-Google-Smtp-Source: AG47ELskA/uQoApZKsIQ671auZOUPY4/5772OVfE4u6q3GIEQGyfiLwOQ8AtwPozO21ALmjR8wlZ X-Received: by 10.98.218.7 with SMTP id c7mr21579849pfh.162.1520519691709; Thu, 08 Mar 2018 06:34:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520519691; cv=none; d=google.com; s=arc-20160816; b=GW0rmQySdYEilsjLQc/7UJcbQAdObtMqJ1u/Z6kwNt2FlMU7P2bfgCohbXpGO0ofNn v4N3AkORDeyAKCeFQG2PE0av+fMq8MupI23Gb1gFg2C6SfaSaYvNTubGf1eOd4Tpmqie vLAuuG8qDsmVk0eD2t3iwy18sofdo12mQqvtt2YGikAYO10drrFZjQv64bRzIs31+IwH P+4z/HVZ1LDf8766ELpemYvCCQFgMb9V+n0ExVpgXBiXQJWw6A5TXh3Awx+oAtzQEgqN 6OMQCNkY3czVtZt4BEcgHOzUy5zVldhccCGnaKadsMN4ooqzpGsuRbxfL+r+7l/EzC+3 Zr7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=VbFF4lTqG6Z9MnWYPsGjrh9jp33yGB3YzYJwz1OH7Y0=; b=aC4/Pav5YmOCwTL4/AYp0L8Rl7JnU72xH4wcRaiKT5rN0mogwBgyvrF2xhBbBMnlRE E2Cs92wIasJb9VkUIGPzIn/fXaxNlzsXUrLWs/wIsAQuONVJ33sKuHC49/tzKW5I5f9b Vg8ACWRKiwCzNdPdnfd5NPnyeZJIANSE4uknR98oOjn1QL5bE3Pp+dIIxSTd9WvA/jV3 4gAGfjMNnrh3Us9uq52QINAQQdHHYVokpzAVEK+gKficdL0sdA5CHS2oqhjpilyRs3bw /qysRiLA4JYwCOkpfS7nZuUPwhRoGgVI9cgnPYlCmahzkFsxy18prjb8mef3Cbh1PoWj OILw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=G37E/xLd; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e5si13035473pgr.444.2018.03.08.06.34.36; Thu, 08 Mar 2018 06:34:51 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=G37E/xLd; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934320AbeCHOdY (ORCPT + 99 others); Thu, 8 Mar 2018 09:33:24 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:59904 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933415AbeCHOdX (ORCPT ); Thu, 8 Mar 2018 09:33:23 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w28EVvJU046586; Thu, 8 Mar 2018 14:32:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2017-10-26; bh=VbFF4lTqG6Z9MnWYPsGjrh9jp33yGB3YzYJwz1OH7Y0=; b=G37E/xLd/BwO7DB79ZGKsH5D4h8Ska1a+O4QL6SQ2aDVjbREhwjf5w6Ln5ANnY73CMY5 DZV+L+GevuAxurJL9F8E7U2k/3+Dmbc2tuP3Lsn0y/KgLW1ti7Cz/rUzWOFtF08ViVqf Yv5EASQ8y/CGaAaI+j4j5x8S1fP/lIXANv1QQtKw5KwYi85ACDfrGN/lIWUBKkYfw1qe waPQxDw3+GomryFSekgBDL1cFNqqSCyn3n7KaKAdT8J+fHBaqdT+i04/VbeqhhmwAFJD W7VIrf4uC5yXWX23CW8E5l07ILFyPplQEomPDE7fopPezdT5OosOqLmD6UrKLtpoLy+z hA== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by aserp2120.oracle.com with ESMTP id 2gk63y091f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 08 Mar 2018 14:32:52 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w28EWpa4005569 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 8 Mar 2018 14:32:51 GMT Received: from abhmp0018.oracle.com (abhmp0018.oracle.com [141.146.116.24]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w28EWo5h001845; Thu, 8 Mar 2018 14:32:50 GMT Received: from [10.191.23.54] (/10.191.23.54) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 08 Mar 2018 06:32:50 -0800 Subject: Re: [PATCH V4 1/5] nvme: do atomically bit operations on nvme_request.flags To: Christoph Hellwig Cc: axboe@fb.com, sagi@grimberg.me, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, keith.busch@intel.com References: <1520489971-31174-1-git-send-email-jianchao.w.wang@oracle.com> <1520489971-31174-2-git-send-email-jianchao.w.wang@oracle.com> <20180308075736.GB16084@lst.de> From: "jianchao.wang" Message-ID: Date: Thu, 8 Mar 2018 22:32:55 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180308075736.GB16084@lst.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8825 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=846 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1803080170 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Christoph Thanks for your precious time for reviewing this. On 03/08/2018 03:57 PM, Christoph Hellwig wrote: >> - u8 flags; >> u16 status; >> + unsigned long flags; > Please align the field name like the others, though Yes, I will change this next version. Thanks Jianchao