Received: by 10.223.185.116 with SMTP id b49csp6515378wrg; Thu, 8 Mar 2018 08:40:18 -0800 (PST) X-Google-Smtp-Source: AG47ELs5GysaQ9wUbeoOtrugzi6ozrNib04/xwxLBMHUjoYfPNj+tC7br9HVmxEgdxdfJ6rYx4Xp X-Received: by 2002:a17:902:33c2:: with SMTP id b60-v6mr25139492plc.222.1520527218394; Thu, 08 Mar 2018 08:40:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520527218; cv=none; d=google.com; s=arc-20160816; b=BDzqfpEOn6vQ+iXcqVOTPQUHHtcf1QdDOtNnEG1TcVpkuZVSEmNJbijUtqL418eC5i iRgBVVVbM8F53ASw898VS8IEVf4u2zRz2XnvCQp7YKEoKzkb8ynEf8Bf8XeHfczYEd6e yUmiDzLqcVaKcxy4kk3tFf1pHkQE2/Zqz6St3AyjetXTXg+58f+gC2oa9xE7K3f8mXFN 3ijVeCBLJE4XV0jOSITO0dXquOk4kA0KF/okYGDcMoBwSpW+FgBe24VANGz+4S9KApuR zvKMiaYJOJbDSRNIgYIYz+M3FR5Miv3gI8Qkg/q50FJ/CS6Xt2xmXZQh7Q6lGMAqAGV1 K7Yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=15Eazo9BHWReBGO5wpthQXbDWPbx5Qoj8qaYi5/8TO8=; b=v2I+/QgM4iUqDzGs1skP0cOSexFT1qbUx75ktAT+HQ3VWXnJu7lR1mnVQSLpv0D/fA VQdMqPNzqsddG2Hk/dg0iHVExvYQf+x32JFEFHrAA4JXTUt9stOBndpoRTU10+FEcoMf pO5WYzd/RJpTRMeTIrtel1bZVwrIRQAhxEhgsNHsCHCauj+rusLqN/h7VNGhWk0F5V4P 61tel4WADTWInZXrs3GfYfeKjAWzOd8rojz3sd1BGDrHG/TR8bXioDnqifN0Rl5aC43+ qkUyan9BgP9Er7CU/dfAaR8dlyjuFneS5IzWyNhnjD85FgmAuc2AY57Kll1pM7XpDXtP Kq5Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v17si15788810pfe.186.2018.03.08.08.40.03; Thu, 08 Mar 2018 08:40:18 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934016AbeCHQiu convert rfc822-to-8bit (ORCPT + 99 others); Thu, 8 Mar 2018 11:38:50 -0500 Received: from gloria.sntech.de ([95.129.55.99]:53244 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932087AbeCHQir (ORCPT ); Thu, 8 Mar 2018 11:38:47 -0500 Received: from ip9234b559.dynamic.kabel-deutschland.de ([146.52.181.89] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.1:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.80) (envelope-from ) id 1etyZ1-0008Am-Hr; Thu, 08 Mar 2018 17:38:43 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Enric Balletbo i Serra Cc: Sandy Huang , Andrzej Hajda , linux-rockchip@lists.infradead.org, Archit Taneja , linux-kernel@vger.kernel.org, Russell King , Neil Armstrong , dri-devel@lists.freedesktop.org, Jose Abreu , Hans Verkuil , Laurent Pinchart , Jernej Skrabec , linux-arm-kernel@lists.infradead.org, David Airlie , Jeffy Chen , kernel@collabora.com Subject: Re: [PATCH v9 3/5] drm/rockchip: inno_hdmi: reorder clk_disable_unprepare call in unbind Date: Thu, 08 Mar 2018 17:38:42 +0100 Message-ID: <7281273.So3vQhM8Nz@diego> In-Reply-To: <20180302175757.28192-4-enric.balletbo@collabora.com> References: <20180302175757.28192-1-enric.balletbo@collabora.com> <20180302175757.28192-4-enric.balletbo@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Freitag, 2. M?rz 2018, 18:57:55 CET schrieb Enric Balletbo i Serra: > From: Jeffy Chen > > In bind the clk_prepare_enable of the HDMI pclk is called before adding the > i2c_adapter. So it should be the other way around in unbind, first remove > the i2c_adapter and then call the clk_disable_unprepare. > > Fixes: 412d4ae6b7a5 ("drm/rockchip: hdmi: add Innosilicon HDMI support") > Signed-off-by: Jeffy Chen > Signed-off-by: Thierry Escande > Signed-off-by: Enric Balletbo i Serra applied to drm-misc-next Thanks Heiko