Received: by 10.223.185.116 with SMTP id b49csp6611873wrg; Thu, 8 Mar 2018 10:11:11 -0800 (PST) X-Google-Smtp-Source: AG47ELvFeKGwpd4r+BMGZyU71sv8/I7LHw9rsfJrtIVis+wenQw+oubTNsCF3V8prB4Yr5nX1Z2U X-Received: by 10.99.164.81 with SMTP id c17mr21951857pgp.114.1520532671751; Thu, 08 Mar 2018 10:11:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520532671; cv=none; d=google.com; s=arc-20160816; b=UjUQZCxDbHiBc1VPciadpnQm3DzbdKDXwEmP13Qo/RweWupZOs0OVQ0Jq546GAVoSb 7A9Zltp5v1lbqbZdxfHGVyhpD9cAKQuaeOCxjTWAK/PtEMyGQi/yh/L0/KU2qRIAMz5Z gD4CNOLw2hxFazfKIkVwGFLtKNYJwzz53wrrhysc8bueBSPQQELdMoqADxoOENM3twmU YwreITYcBSXTO5+nojwzdEd+y6vuQ7Bsb65bqwoDDH8Sk9GtGFSDGVIQ4hzeexUyg1am M1ki3S/RmtTroPJdnk2wk5oQNEmYYDQb+hYpU3wMyrpbMcXsR8pD/3ZZfcpias6facR2 r6YA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date :arc-authentication-results; bh=RIRiV+qwopew0A+7oyQxMESwcoDijyEo4Cu2a+mYt8k=; b=dw3QszJOAuX2+xfWSl6ePIqh6Y0pCjmtFXrUNnl9ykTleuxGXrBdWQ4InFWSt6JM1s GlDlve08JyJb2Ch/+W9FwO3CjIGiJpB18x64jJZjXpte8y8lYKguaos7UGVIzK9aUN07 HGG2sc777oqO8irSpvKKD/9eniLxI2stboUoUwIGL+lFWgyMgctkpltI769/e5TwnIS2 qnjK2l4wJrPjNQOhM9rPqSbpyD06kM+5I4osM2DHUrl7ZjHlJzv2tCWo66sdLKl5zyZe ilE+GXxcEnSvGojP7cGeQj02jSkIMhTUJL5a19n94t5YXxW1oeLCEVb5upZy0axbODe6 MoKg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 64-v6si15376943ply.209.2018.03.08.10.10.56; Thu, 08 Mar 2018 10:11:11 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936038AbeCHSJw (ORCPT + 99 others); Thu, 8 Mar 2018 13:09:52 -0500 Received: from resqmta-ch2-08v.sys.comcast.net ([69.252.207.40]:39334 "EHLO resqmta-ch2-08v.sys.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933221AbeCHSJv (ORCPT ); Thu, 8 Mar 2018 13:09:51 -0500 Received: from resomta-ch2-13v.sys.comcast.net ([69.252.207.109]) by resqmta-ch2-08v.sys.comcast.net with ESMTP id tzypeuk7dgH2ntzzDeSqD0; Thu, 08 Mar 2018 18:09:51 +0000 Received: from gentwo.org ([98.222.162.64]) by resomta-ch2-13v.sys.comcast.net with SMTP id tzzBeS2SsrEP9tzzCeO6Ow; Thu, 08 Mar 2018 18:09:50 +0000 Received: by gentwo.org (Postfix, from userid 1001) id 420CE1160312; Thu, 8 Mar 2018 12:09:49 -0600 (CST) Received: from localhost (localhost [127.0.0.1]) by gentwo.org (Postfix) with ESMTP id 3EA291160150; Thu, 8 Mar 2018 12:09:49 -0600 (CST) Date: Thu, 8 Mar 2018 12:09:49 -0600 (CST) From: Christopher Lameter X-X-Sender: cl@nuc-kabylake To: Chintan Pandya cc: Matthew Wilcox , penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] slub: Fix misleading 'age' in verbose slub prints In-Reply-To: Message-ID: References: <1520423266-28830-1-git-send-email-cpandya@codeaurora.org> <20180307182212.GA23411@bombadil.infradead.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-CMAE-Envelope: MS4wfJVKUAmpm5Tr1XYPCWphAvU+gD4wFLCXiZOOJkSzuFFBqqfxK57Y+RoPbwBZwOAuRncnNTnsl2kqAL2dnu6FUfDQhonBG/sdtoTI744eTn4ctm77tgqX VzgDYjkQi0Q/5r3hizZMUiQFua69IgLlnxp1AgOAIIm0mf24y0tW9xjllF+SwzQg3CamZ7fByHXqSwnWEOKBbNLeQl6p5cugR9AfCqLgqYgoD+nHaP8foZ6/ owjfwrWKis4MsondOq3j4xmXqtuTPU6HJTztXHmnZ8fPKXzeM2yRrc5iHGaXik18DjkQ7AiV2yyn/E4U7HcJbzPDodE33pRrAVBIm2ernc7asoYfIrgJXkwH FdOk86d/NzHuPPjAH904uB7IlkfdbEjqPMh/sJgZHUpR/OSlBXA= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 8 Mar 2018, Chintan Pandya wrote: > > If you print the raw value, then you can do the subtraction yourself; > > if you've subtracted it from jiffies each time, you've at least introduced > > jitter, and possibly enough jitter to confuse and mislead. > > > This is exactly what I was thinking. But looking up 'age' is easy compared to > 'when' and this seems required as from Christopher's > reply. So, will raise new patch cleaning commit message a bit. Well then you need to provide some sort of log text processor I think. Otherwise you need to get the object address from the log message, then scan back through the log to find the correct allocation entry, retrieve both jiffy values and subtract them. If the age is there then you can simply see how far in the past the object was allocated. One advantage in favor of jiffies would be the ability to correlate multiple events if each log line would have a jiffies like timestamps. But it does not. So I think outputting jiffies there is causing more problems that benefits.