Received: by 10.223.185.116 with SMTP id b49csp6619228wrg; Thu, 8 Mar 2018 10:18:07 -0800 (PST) X-Google-Smtp-Source: AG47ELtfhv4wWhxnuxWwJFBH3Us6vT3x/l53c3zYGd9pEmUMVN9NRFnfc140z/tR8zkoNKtoiEzA X-Received: by 10.98.1.88 with SMTP id 85mr27149718pfb.226.1520533087579; Thu, 08 Mar 2018 10:18:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520533087; cv=none; d=google.com; s=arc-20160816; b=b+emR97cEmqMMGfm1Ziai13ACaYSAcMXJYjIW8fmHGSuYYN9uHXJqYOq4+79Ek7/xy wwZlkG0xgDgPuMucgGIuZvieRmPcYhzHKaTCnUhvPwGnT/51BfgR16zffwc2e+5ATCYt g404Z1puth8tNUsCNLEFNb1NLpUcIEv91d0EBFGolpWssMxDgOKH8Q8vIHa4m5TP7jWH xG9dP300GffD2uDi9tRYU5adNnPhCRzV8NiwHi5ecBMy5tkXHJ0KpnS22jAkE81jwqf9 m142oxs05UX6BtFbq9/D8RVCtlwFb5oY2jx9ZuzuXRvyQbsKgPZjV6bV6fRQ1u5Kb8Ln GOrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=qCuEgKMU3OMLpWXsyXG2uX+KCURz5s+4it84+WbNiUU=; b=uRVnatDbgb9WuniMxIMWhGoB3vg+F1rQfZ9OzaV8Jj0HaqIEydJnmAQDt9LzZnjEUM Ylcsrrompb6HbManhSDO4yDDAeRN2QPQCUOdPoep3Gi8Q4H/Eu+qyTzfVMZeRsqTqqEw ajefxAX8ULPPZkBn0n+UZy0vCqJUpMgfGIIZAEjGCFIBCURsVgtf3tnEms0rttL6bX+J DPo9TCKmfeq4ItO4fGUpFulybHixDbDFq8XZ7vH0GyCA015K31DrsfFZ3S1HkgaWJTSa So3EZ5dnTMCnbt/CBRTZN3Yn9YgBOv1qUVgSGN/wwpkocpCVsyKuN9oWrZjwzBz5XELM KKkA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=u2GNQq10; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a10si13330117pgq.174.2018.03.08.10.17.51; Thu, 08 Mar 2018 10:18:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=u2GNQq10; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754891AbeCHSQZ (ORCPT + 99 others); Thu, 8 Mar 2018 13:16:25 -0500 Received: from mail-pl0-f66.google.com ([209.85.160.66]:43570 "EHLO mail-pl0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752151AbeCHSQX (ORCPT ); Thu, 8 Mar 2018 13:16:23 -0500 Received: by mail-pl0-f66.google.com with SMTP id f23-v6so3755467plr.10; Thu, 08 Mar 2018 10:16:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=qCuEgKMU3OMLpWXsyXG2uX+KCURz5s+4it84+WbNiUU=; b=u2GNQq109e+wT/31Xwm+L6xPXJziCXIeHF/ZMh/U8KynSWkRVfqjOrQ18U7g8NVdBL EnX+hUX/+te13q4/wZuouL5BqHEUOpNyjy8SvgVaRI35/BocF+EIKeCZEeZGiiJ+Yxmm KUnb2wivMcG/rODV/HcLfeeoT7XmcyulP85ssb6NfRLXwrUuuESWXt4JBDEAkx79rz42 wzb5fhPXv/o7yOQKoXL06f9WOsHND0PcOhGtbGE7yGYkrMAj+6NGpAukVAlYtPXYsH9N wJX5MRMc00Crwd30obWUeN/iMkdy9bBRDo+PUCnAVAjfrqCqgv6f/adQLWqzVyghF+wK UwXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=qCuEgKMU3OMLpWXsyXG2uX+KCURz5s+4it84+WbNiUU=; b=lhoD9iyW80+6SrfV9S3mijwnssCviTAJPxFmXr/RpjA6REN1bF87fo8b9qyK21UgnI 9UjeBHrUceVeWHWbRmSIS4YOdRlr8sZyrNotyv2IqinR9rmj9YIXxVTSWspKRk+sF6BW WT5prG/CPYWnNsmDzC0WqEy4rpbaP911/bskgy074SfTUeMXniPtV7T56FfVQsajFYYn /4+Gy9C71j1QUPG9dJ4J2+ZQdPg4RlIfLQdennvcCMrIvKngsYm4eATZ2Xa64FT8p/sL RxM3cruEcapjsbDhJWzR+ywB1OJyuV3YxO8/jBlxuJV8yNLerxlRoRSEkdIyYWj6C2s5 LnHA== X-Gm-Message-State: AElRT7G3YioltwvuBCRzwfxAyftqvRacQd7jljAH0PP0NkTzxB2qEMgS eAF15tr1lBNe3tjct/p9mzI= X-Received: by 2002:a17:902:b185:: with SMTP id s5-v6mr5695370plr.109.1520532983221; Thu, 08 Mar 2018 10:16:23 -0800 (PST) Received: from shreeya-VirtualBox ([103.212.140.137]) by smtp.gmail.com with ESMTPSA id l19sm36169157pgn.31.2018.03.08.10.16.21 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 08 Mar 2018 10:16:21 -0800 (PST) From: Shreeya Patel To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, knaack.h@gmx.de, pmeerw@pmeerw.net, gregkh@linuxfoundation.org, linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, daniel.baluta@gmail.com Cc: Shreeya Patel Subject: [PATCH v4] Staging: iio: adis16209: Change some macro names Date: Thu, 8 Mar 2018 23:46:17 +0530 Message-Id: <1520532977-10653-1-git-send-email-shreeya.patel23498@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Make some of the macro names according to the names given in the datasheet of the adis16209 driver and have slight indentation in field definitions to make them clearly different from the register addresses. Signed-off-by: Shreeya Patel --- Changes in v4 -Have slight indentation in field definitions. drivers/staging/iio/accel/adis16209.c | 48 +++++++++++++++++------------------ 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/drivers/staging/iio/accel/adis16209.c b/drivers/staging/iio/accel/adis16209.c index eb5c878..19636e2 100644 --- a/drivers/staging/iio/accel/adis16209.c +++ b/drivers/staging/iio/accel/adis16209.c @@ -68,21 +68,21 @@ #define ADIS16209_MSC_CTRL_ACTIVE_HIGH BIT(1) #define ADIS16209_MSC_CTRL_DATA_RDY_DIO2 BIT(0) -#define ADIS16209_STAT_REG 0x3C -#define ADIS16209_STAT_ALARM2 BIT(9) -#define ADIS16209_STAT_ALARM1 BIT(8) -#define ADIS16209_STAT_SELFTEST_FAIL_BIT 5 -#define ADIS16209_STAT_SPI_FAIL_BIT 3 -#define ADIS16209_STAT_FLASH_UPT_FAIL_BIT 2 +#define ADIS16209_DIAG_STAT_REG 0x3C +#define ADIS16209_DIAG_STAT_ALARM2 BIT(9) +#define ADIS16209_DIAG_STAT_ALARM1 BIT(8) +#define ADIS16209_DIAG_STAT_SELFTEST_FAIL_BIT 5 +#define ADIS16209_DIAG_STAT_SPI_FAIL_BIT 3 +#define ADIS16209_DIAG_STAT_FLASH_UPT_BIT 2 /* Power supply above 3.625 V */ -#define ADIS16209_STAT_POWER_HIGH_BIT 1 +#define ADIS16209_DIAG_STAT_POWER_HIGH_BIT 1 /* Power supply below 3.15 V */ -#define ADIS16209_STAT_POWER_LOW_BIT 0 +#define ADIS16209_DIAG_STAT_POWER_LOW_BIT 0 -#define ADIS16209_CMD_REG 0x3E -#define ADIS16209_CMD_SW_RESET BIT(7) -#define ADIS16209_CMD_CLEAR_STAT BIT(4) -#define ADIS16209_CMD_FACTORY_CAL BIT(1) +#define ADIS16209_GLOB_CMD_REG 0x3E +#define ADIS16209_GLOB_CMD_SW_RESET BIT(7) +#define ADIS16209_GLOB_CMD_CLEAR_STAT BIT(4) +#define ADIS16209_GLOB_CMD_FACTORY_CAL BIT(1) #define ADIS16209_ERROR_ACTIVE BIT(14) @@ -238,29 +238,29 @@ static const struct iio_info adis16209_info = { }; static const char * const adis16209_status_error_msgs[] = { - [ADIS16209_STAT_SELFTEST_FAIL_BIT] = "Self test failure", - [ADIS16209_STAT_SPI_FAIL_BIT] = "SPI failure", - [ADIS16209_STAT_FLASH_UPT_FAIL_BIT] = "Flash update failed", - [ADIS16209_STAT_POWER_HIGH_BIT] = "Power supply above 3.625V", - [ADIS16209_STAT_POWER_LOW_BIT] = "Power supply below 3.15V", + [ADIS16209_DIAG_STAT_SELFTEST_FAIL_BIT] = "Self test failure", + [ADIS16209_DIAG_STAT_SPI_FAIL_BIT] = "SPI failure", + [ADIS16209_DIAG_STAT_FLASH_UPT_BIT] = "Flash update failed", + [ADIS16209_DIAG_STAT_POWER_HIGH_BIT] = "Power supply above 3.625V", + [ADIS16209_DIAG_STAT_POWER_LOW_BIT] = "Power supply below 3.15V", }; static const struct adis_data adis16209_data = { .read_delay = 30, .msc_ctrl_reg = ADIS16209_MSC_CTRL_REG, - .glob_cmd_reg = ADIS16209_CMD_REG, - .diag_stat_reg = ADIS16209_STAT_REG, + .glob_cmd_reg = ADIS16209_GLOB_CMD_REG, + .diag_stat_reg = ADIS16209_DIAG_STAT_REG, .self_test_mask = ADIS16209_MSC_CTRL_SELF_TEST_EN, .self_test_no_autoclear = true, .startup_delay = ADIS16209_STARTUP_DELAY_MS, .status_error_msgs = adis16209_status_error_msgs, - .status_error_mask = BIT(ADIS16209_STAT_SELFTEST_FAIL_BIT) | - BIT(ADIS16209_STAT_SPI_FAIL_BIT) | - BIT(ADIS16209_STAT_FLASH_UPT_FAIL_BIT) | - BIT(ADIS16209_STAT_POWER_HIGH_BIT) | - BIT(ADIS16209_STAT_POWER_LOW_BIT), + .status_error_mask = BIT(ADIS16209_DIAG_STAT_SELFTEST_FAIL_BIT) | + BIT(ADIS16209_DIAG_STAT_SPI_FAIL_BIT) | + BIT(ADIS16209_DIAG_STAT_FLASH_UPT_BIT) | + BIT(ADIS16209_DIAG_STAT_POWER_HIGH_BIT) | + BIT(ADIS16209_DIAG_STAT_POWER_LOW_BIT), }; static int adis16209_probe(struct spi_device *spi) -- 2.7.4