Received: by 10.223.185.116 with SMTP id b49csp6642540wrg; Thu, 8 Mar 2018 10:41:54 -0800 (PST) X-Google-Smtp-Source: AG47ELsRd327Cffcrj/K1jzKagDZJ4YA/+xEsoskiBp/MC2epI45HU0p/nwitA1e6Zfu7Zn860jk X-Received: by 10.99.3.87 with SMTP id 84mr46758pgd.418.1520534514317; Thu, 08 Mar 2018 10:41:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520534514; cv=none; d=google.com; s=arc-20160816; b=phz7mBPUX3bJHJTW/B7heA+cgGLU6Fl/QDUeteff0Ma/vgYH2WIGQ/TfYwRf1yyz6R RhcOlBiqBKOxiNYXcxuN140X7Y/syfion9rvjvoWcaL3iofZo8huFqNPPvsjrtkGrEpV Npcg6nht+xd9CKHpsEtzH7qV2QFw+trk3jJK90Zwo0Z//gQHaDnzD4q02eHn2s1QpA+O FtrdCW+zpJTKGn1uczfBXX4TcZ/UDxHOZu4g1oKAbqzLv5QygCfuqM6u2NzB+EdvoLcX o6c9359s/uL41JrqFj3mKdeTM3f+knto+5ZzR8vdlC9x8kFIh6kw9HTL/X/sPdjs0IQ8 4A2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=zSo41Bo2IEImLh4ZN7AuREnnpfEkF0gY6xBHBUHifPg=; b=AnOd3e1FNDcHyX57ClwjWF0QEUTvSqqHuI4ewd39Nh5LK8VZPru2DjbM+7VlhcS3rz wAqtasAlqVPkNPG1TFIEVPrnMtavFAWuJSE9YAg8VZ4fuoJsKfgzJREvqXWV9st6Yrjq c0xYXpVXR38LvBkJxDvspaAbiPvnG1HnJqLOYrLXgJCG6anGdAhIvDoplOgC+1H7y27g DUUo3VxkLMFUepXQqDSTk35J+C6/7udg29i6MfAlTh31mvrdqi1JZRvvYmywbRMLJXtD uOq+TZNof/R8LaHcrgHNH8xCIV24kQp2GX9vIy7hIxRxo/4MV+mLaECtUKbj+CHt0Cn5 CLdQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v133si13260867pgb.740.2018.03.08.10.41.39; Thu, 08 Mar 2018 10:41:54 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755674AbeCHSkh (ORCPT + 99 others); Thu, 8 Mar 2018 13:40:37 -0500 Received: from orcrist.hmeau.com ([104.223.48.154]:37178 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751652AbeCHSkg (ORCPT ); Thu, 8 Mar 2018 13:40:36 -0500 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtp (Exim 4.84_2 #2 (Debian)) id 1eu0Sp-0004ag-32; Fri, 09 Mar 2018 02:40:27 +0800 Received: from herbert by gondobar with local (Exim 4.84_2) (envelope-from ) id 1eu0Si-0002iX-45; Fri, 09 Mar 2018 02:40:20 +0800 Date: Fri, 9 Mar 2018 02:40:20 +0800 From: Herbert Xu To: Eric Dumazet Cc: Greg Hackmann , Steffen Klassert , "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] net: xfrm: use preempt-safe this_cpu_read() in ipcomp_alloc_tfms() Message-ID: <20180308184020.GA10422@gondor.apana.org.au> References: <20180307192416.233202-1-ghackmann@google.com> <20180308073328.GA8111@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 08, 2018 at 08:31:47AM -0800, Eric Dumazet wrote: > > Because that would not be nice. > > this_cpu_read() is faster than going through raw_smp_processor_id() and > per_cpu_ptr() I see. In that case I have no objections to this patch. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt